X2Go Bug report logs - #820
Fwd: [X2Go-Dev] Patch: x2goserver: x2goruncommand - set IMEXIT="true" for gnome-terminal

Package: x2goserver; Maintainer for x2goserver is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver is src:x2goserver.

Reported by: Rok Mandeljc <rok.mandeljc@gmail.com>

Date: Tue, 17 Mar 2015 05:45:02 UTC

Severity: normal

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#820: [X2Go-Dev] Bug#820: Fwd: Patch: x2goserver: x2goruncommand - set IMEXIT="true" for gnome-terminal
Reply-To: Rok Mandeljc <rok.mandeljc@gmail.com>, 820@bugs.x2go.org
Resent-From: Rok Mandeljc <rok.mandeljc@gmail.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 17 Mar 2015 10:10:02 +0000
Resent-Message-ID: <handler.820.B820.14265869474917@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 820
X-X2Go-PR-Package: x2goserver
X-X2Go-PR-Keywords: 
Received: via spool by 820-submit@bugs.x2go.org id=B820.14265869474917
          (code B ref 820); Tue, 17 Mar 2015 10:10:02 +0000
Received: (at 820) by bugs.x2go.org; 17 Mar 2015 10:09:07 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham version=3.3.2
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id C80065DAA2
	for <820@bugs.x2go.org>; Tue, 17 Mar 2015 11:09:05 +0100 (CET)
Received: by wixw10 with SMTP id w10so6490974wix.0
        for <820@bugs.x2go.org>; Tue, 17 Mar 2015 03:09:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        bh=FE6PHdys3bOKnGSqBAph9QXg6DuikOkpvL3i9AFB80Q=;
        b=gEsYMzskaP1GjqlZrg+nX0MvpOffa/RqYTsT14AURjLlK0HxutvPTxf8Cgz5PsDUQK
         vQBVGOHIiTv5NYQLfIqj9Z7jjhoI7QZvt6/+YW2RVKwBP0QxVJxQwr/zvxj9ZrVTAFul
         rcwYrv91V7up44HmECTlxhUVHD4SANDzi4mZ6FMUX6uSYUWc5Nz7I0r+ZHzZueqBxdRy
         K7QkdANHrFJXoOEf79KWEZug7DA6nTmkw5mp7fCyXRM+yCStahJPLP525YNxAYqidGvU
         mqYkTZu5EYZ05KHNF9//IDokeXJCHKf1UMzW8z3vMw7ObJ3iC6VH7vHTJzoF9xJAgkQW
         bPfg==
X-Received: by 10.194.83.66 with SMTP id o2mr133634619wjy.55.1426586945370;
        Tue, 17 Mar 2015 03:09:05 -0700 (PDT)
Received: from [192.168.90.28] (natfe.fe.uni-lj.si. [193.2.84.130])
        by mx.google.com with ESMTPSA id l9sm1974775wij.16.2015.03.17.03.09.03
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Tue, 17 Mar 2015 03:09:04 -0700 (PDT)
Message-ID: <5507FD3E.90904@gmail.com>
Date: Tue, 17 Mar 2015 11:09:02 +0100
From: Rok Mandeljc <rok.mandeljc@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Mihai Moldovan <ionic@ionic.de>, 820@bugs.x2go.org
References: <550752A1.1070807@gmail.com> <5507BE76.1060309@ionic.de> <5507C377.4060008@ionic.de>
In-Reply-To: <5507C377.4060008@ionic.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 17. 03. 2015 07:02, Mihai Moldovan wrote:
> Control: submitter -1 Rok Mandeljc <rok.mandeljc@gmail.com>
> Thanks
>
>
> On 17.03.2015 06:41 AM, Mihai Moldovan wrote:
>> I have been trying to set up x2goserver on my Fedora 21 boxes, and
>> gnome-terminal seems to be failing with symptoms similar to those
>> described in #268.
>>
>> It seems that x2goruncommand has been reworked a bit since that patch,
>> and now attempts to force the forking programs to stay in the foreground
>> by capturing their output to STDOUT. Unfortunately, this does not seem
>> to work for gnome-terminal; the terminal window appears on the client
>> for a second, then closes and the session is proclaimed to be finished.
>> This can be fixed by explicitly setting IMEXIT="true" if called binary
>> is gnome-terminal, which is done by the attached patch.
> This looked weird at first glance, because you've previously (two years
> ago) sent a patch to explicitly disable IMEXIT for GNOME Terminal.
>
> However, Mike#1 changed the IMEXIT behavior with commit
> c3afe1c154dfeb0ba052f7506f0cadc5f6c62871 and that's also why it's now
> failing for GNOME Terminal.

Indeed :)

> I'll be adding IMEXIT="true" and your comment where gnome-terminal is
> defined, if that's OK with you?

If you are talking about the if [ "$cmd" == "TERMINAL" ] switch, then I
think it will not fix the case when session is "single command" and the
"gnome-terminal" is manually entered as a binary (with or without path).
I use such session definition on couple of workstations that have both
KDE and GNOME installed to get gnome-terminal instead of konsole... Not
sure how wide-spread that use case is, though; or if it could perhaps be
done better?

>
> Will craft and commit a patch tomorrow.
>
> Thanks for contributing!
>
>
>
> Mihai
>
>
> N.B.: shouldn't this be also required for KDE4's konsole? Looks like it,
> but I'm not a KDE user, so... input welcome.

Capturing konsole's output to STDOUT seems to do the trick, at least at
the moment. So for now, it works correctly without setting IMEXIT.

Regards,
    Rok

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 14:49:39 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.