X2Go Bug report logs - #812
x2gogetapps should ignore NoDisplay=true desktop application entries

version graph

Package: x2goserver; Maintainer for x2goserver is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver is src:x2goserver.

Reported by: Jason Alavaliant <alavaliant@ra09.com>

Date: Tue, 10 Mar 2015 08:35:01 UTC

Severity: normal

Tags: patch, pending

Found in version 4.0.1.19

Fixed in versions 4.0.1.20, 4.1.0.0

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log


🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#812: [X2Go-Dev] Bug#812: x2gogetapps should ignore NoDisplay=true desktop application entries
Reply-To: Mihai Moldovan <ionic@ionic.de>, 812@bugs.x2go.org
Resent-From: Mihai Moldovan <ionic@ionic.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Wed, 11 Mar 2015 20:15:02 +0000
Resent-Message-ID: <handler.812.B812.142610487614315@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 812
X-X2Go-PR-Package: x2goserver
X-X2Go-PR-Keywords: patch
Received: via spool by 812-submit@bugs.x2go.org id=B812.142610487614315
          (code B ref 812); Wed, 11 Mar 2015 20:15:02 +0000
Received: (at 812) by bugs.x2go.org; 11 Mar 2015 20:14:36 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from Root24.de (powered.by.root24.eu [5.135.3.88])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id CC4BD3BE7C
	for <812@bugs.x2go.org>; Wed, 11 Mar 2015 21:14:34 +0100 (CET)
Received: from nopileos.local (home.ionic.de [217.92.117.31])
	by mail.ionic.de (Postfix) with ESMTPSA id AF1DF4F088B5;
	Wed, 11 Mar 2015 21:14:32 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1426104874; bh=13m/v+mehFIik2hrnh40brYfEydpoVqJcjn5rLvVSCI=;
	h=Date:From:To:Subject:References:In-Reply-To:From;
	b=l2NU7SMuXGXwWeKLheQ1fERh3bnsw5bxtrfEJeGSBjFPSoXoRHAxlbP90Azm/K3IM
	 hlGFNTRvjyIU66U5sHL4OaEBxlaRL69jrdLxWqrkyn35g0NN4e6kMwHsosU4F5UrEN
	 BFzby8R+Loe5lACGPt1sJfFV+Q3eDgGJBj3vdCIU=
Message-ID: <5500A221.7090301@ionic.de>
Date: Wed, 11 Mar 2015 21:14:25 +0100
From: Mihai Moldovan <ionic@ionic.de>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Jason Alavaliant <alavaliant@ra09.com>, 812@bugs.x2go.org
References: <54FEABB7.5090705@ra09.com>
In-Reply-To: <54FEABB7.5090705@ra09.com>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="rEuJobtmsM3gTXBmnXQIi29dpBIoQDc4K"
[Message part 1 (text/plain, inline)]
Hi Jason,


On 10.03.2015 09:30 AM, Jason Alavaliant wrote:
> Currently the x2gogetapps command prints out all .desktop application
> files irrespective of if they have the value NoDisplay=true set in the
> file or not.
> [...]
> The attached patch updates the x2gogetapps command to check the file
> to see if NoDisplay=true is set and if so doesn't print out the
> contents of that file removing all the duplicates and other entries
> not intended to be listed in a normal application launch menu.

Thank you for the patch!


I've reviewed your patch and re-implemented it.

First, there's also a "Hidden" key which indicates that the application
shall be regarded as deleted (and not show up either.) We didn't respect
that either, previously.

Further, there's no need to read the whole file once we stumble upon
Hidden or NoDisplay. We can stop processing there. The same goes when
finding a non-Desktop Entry group after a Desktop Entry group.

The new patch can be seen here:

http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=e617a5baec4b8971606bf37f5cef76c29ccd7423

or downloaded here:

http://code.x2go.org/gitweb?p=x2goserver.git;a=blobdiff_plain;f=x2goserver/bin/x2gogetapps;h=84a5779c317299618b7308a48e07d4bc2e550dc8;hp=43a2fec7d606a834d828def79e49f5a2e74ad899;hb=e617a5baec4b8971606bf37f5cef76c29ccd7423;hpb=bbad5d6593df3e5659f561d2345a99ef571b30d1

Can you please test if my patch fixes your problem, too? I'd rather
commit this more complete patch to the main branches.



Mihai



[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Tue Jan 19 19:10:14 2021; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.