X2Go Bug report logs - #81
get rid of remnant html tags in client<->broker communications

Full log

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 7 Dec 2012 08:06:01 +0000
From mike.gabriel@das-netzwerkteam.de  Fri Dec  7 09:06:01 2012
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir (Postfix) with ESMTPS id 2AD575DA79
	for <submit@bugs.x2go.org>; Fri,  7 Dec 2012 09:06:01 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id EA5F81F4
	for <submit@bugs.x2go.org>; Fri,  7 Dec 2012 09:06:00 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id D543F3BB2B
	for <submit@bugs.x2go.org>; Fri,  7 Dec 2012 09:06:00 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 3rduKSwbG4Hr for <submit@bugs.x2go.org>;
	Fri,  7 Dec 2012 09:06:00 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id A89463BF0C
	for <submit@bugs.x2go.org>; Fri,  7 Dec 2012 09:06:00 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 865423BB2B
	for <submit@bugs.x2go.org>; Fri,  7 Dec 2012 09:06:00 +0100 (CET)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	grimnir.das-netzwerkteam.de
X-Spam-Flag: NO
X-Spam-Status: No, hits=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_20
	autolearn=ham version=3.3.1 running as userid=
X-Spam-Level: 
X-Spam-Bayes-Score: 0.0752
Received: by grimnir.das-netzwerkteam.de (Postfix, from userid 33)
	id 1297A3BF0C; Fri,  7 Dec 2012 09:06:00 +0100 (CET)
Received: from nocatv2.tng.de (nocatv2.tng.de [213.178.75.58]) by
 mail.das-netzwerkteam.de (Horde Framework) with HTTP; Fri, 07 Dec 2012
 09:06:00 +0100
Message-ID: <20121207090600.117438jpjzttqsfc@mail.das-netzwerkteam.de>
X-Priority: 3 (Normal)
Date: Fri, 07 Dec 2012 09:06:00 +0100
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: submit@bugs.x2go.org
Subject: get rid of remnant html tags in client<->broker communications
MIME-Version: 1.0
Content-Type: multipart/signed;
 boundary="=_5udywwv27vs";
 protocol="application/pgp-signature";
 micalg="pgp-sha1"
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) H3 (4.3.4)

[Message part 1 (text/plain, inline)]

Package: x2goclient
Severity: normal
Version: 3.99.3.1-HEAD
Tags: patch confirmed

Hi Alex,

I have taken a closer look at the httpbrokerclient.cpp code in  
x2goclient. Most replies from the httpbroker are compliant with a  
text/plain content type. This is good IMHO.

However, in HttpBrokerClient::createIniFile x2goclient expects <br>  
html tags as line breaks. If these <br> tags are missing, the session  
profile won't get recognized by x2goclient.

With the current developmental code in x2gobroker.git, I try to  
implement the current broker API with no html elements at all, so I'd  
be happy if these last required <br>s could be made unnecessary.

Currently, as a list of session profiles the httpbroker client code in  
x2goclient expects some broker output like this:

"""
START_USER_SESSIONS<br>[b00830a9-aec4-4e9e-88f8-ddbffeb1c8ea]defsndport=1<br>sndport=4713<br>xinerama=1<br>variant=<br>useiconv=0<br>iconvfrom=UTF-8<br>height=600<br>usekbd=1<br>applications=TERMINAL,WWWBROWSER,MAILCLIENT,OFFICE<br>host=localhost<br>export=<br>user=<br>fstunnel=1<br>quality=9<br>sshport=22<br>sound=1<br>fullscreen=0<br>rootless=0<br>layout=<br>name=LOCALHOST<br>sshproxyport=22<br>soundsystem=pulse<br>speed=2<br>iconvto=UTF-8<br>soundtunnel=1<br>useexports=1<br>width=800<br>command=KDE<br>multidisp=0<br>print=1<br>setdpi=0<br>type=auto<br>dpi=96<br>pack=16m-jpeg<br>
END_USER_SESSIONS<br>
"""

So, I am quite keen on x2goclient being able to _also_ handle broker  
output that looks like this, instead:

"""
[47af8619-d619-43de-bf00-2c30c47772d1]
defsndport=1
sndport=4713
xinerama=1
variant=
useiconv=0
iconvfrom=UTF-8
height=600
usekbd=1
applications=TERMINAL,WWWBROWSER,MAILCLIENT,OFFICE
host=localhost
export=
user=
fstunnel=1
quality=9
sshport=22
sound=1
fullscreen=0
rootless=0
layout=
name=LOCALHOST
sshproxyport=22
soundsystem=pulse
speed=2
iconvto=UTF-8
soundtunnel=1
useexports=1
width=800
command=KDE
multidisp=0
print=1
setdpi=0
type=auto
dpi=96
pack=16m-jpeg
END_USER_SESSIONS
"""

Attached to this post you find a patch against httpbrokerclient.* that  
makes x2goclient understand both variants of httpbroker output (IMHO).  
Can you please cross-check if that patch keeps x2goclient working with  
all other broker implementations that are currently deployed at your  
customers' sites?

Greets,
Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[httpbrokerclient-no-br-tags-anymore.patch (text/x-diff, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.