X2Go Bug report logs - #804
slot argument mismatch in ONMainWindow::slotTunnelOk causes hang during connect

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Will Wagner <willw@carallon.com>

Date: Fri, 6 Mar 2015 11:30:02 UTC

Severity: normal

Tags: pending

Found in version 4.0.3.2

Fixed in version 4.0.4.0

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

Message #57 received at 804@bugs.x2go.org (full text, mbox, reply):

Received: (at 804) by bugs.x2go.org; 12 Mar 2015 13:21:59 +0000
From ionic@ionic.de  Thu Mar 12 14:21:57 2015
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,T_DKIM_INVALID,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from Root24.de (powered.by.root24.eu [5.135.3.88])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 9E84A5E15D
	for <804@bugs.x2go.org>; Thu, 12 Mar 2015 14:21:57 +0100 (CET)
Received: from nopileos.local (home.ionic.de [217.92.117.31])
	by mail.ionic.de (Postfix) with ESMTPSA id 22DB24F088D0;
	Thu, 12 Mar 2015 14:21:57 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1426166517; bh=nf9GloWLkV4Yz1fs8wlOD16klL52CMI6REBFq4q6ZgY=;
	h=Date:From:To:Subject:References:In-Reply-To:From;
	b=LGZyKyh9K8Mo33B15158jki8A33wjtBBRTplQsOGWY9C+lGcjpTJ20qxooE1xZGEH
	 G7Dsce5BJSX4ZK1Eh5tTAy/5T9uzXPHeewQpXJNKssU84QyhCpXCFM7J+mhcSiOfTZ
	 4mUbGy4vyUtZitPc51HvmElTRgJGGEg7ThF4w8OY=
Message-ID: <550192F0.9080005@ionic.de>
Date: Thu, 12 Mar 2015 14:21:52 +0100
From: Mihai Moldovan <ionic@ionic.de>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Will Wagner <willw@carallon.com>, 804@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#804: slot argument mismatch in ONMainWindow::slotTunnelOk
 causes hang during connect
References: <54F98E42.9090408@carallon.com> <54FA5DDB.2040607@ionic.de> <54FDF871.4040300@carallon.com> <54FDF96D.3000805@ionic.de> <54FECAD7.8030501@carallon.com> <54FF1A44.4000403@ionic.de> <55019015.3080306@carallon.com>
In-Reply-To: <55019015.3080306@carallon.com>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="IQTiOO5fsfiNvPfAIqKPIe8OIUt0MpC33"

[Message part 1 (text/plain, inline)]
On 12.03.2015 02:09 PM, Will Wagner wrote:
> On 10/03/2015 16:22, Mihai Moldovan wrote:
>> Yes. The problem at hand is that this parameter is purely optional
>> anyway and never used.
>>
>> I totally missed that "this" in that context does not refer to
>> slotTunnelOk(int) but QSingleShotTimer::timeout(), which has no
>> parameter.
>>
>> [URL]
>
> Have test repeatedly and I can't make it go wrong any more. Thanks for
> fixing this.

Thank you for getting back!

I have merged the fix-fix into our master branch.



Mihai


[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 17:08:13 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.