X2Go Bug report logs - #804
slot argument mismatch in ONMainWindow::slotTunnelOk causes hang during connect

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Will Wagner <willw@carallon.com>

Date: Fri, 6 Mar 2015 11:30:02 UTC

Severity: normal

Tags: pending

Found in version 4.0.3.2

Fixed in version 4.0.4.0

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#804: [X2Go-Dev] Bug#804: slot argument mismatch in ONMainWindow::slotTunnelOk causes hang during connect
Reply-To: Mihai Moldovan <ionic@ionic.de>, 804@bugs.x2go.org
Resent-From: Mihai Moldovan <ionic@ionic.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 10 Mar 2015 16:25:01 +0000
Resent-Message-ID: <handler.804.B804.142600455626842@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 804
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: pending
Received: via spool by 804-submit@bugs.x2go.org id=B804.142600455626842
          (code B ref 804); Tue, 10 Mar 2015 16:25:01 +0000
Received: (at 804) by bugs.x2go.org; 10 Mar 2015 16:22:36 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from Root24.de (powered.by.root24.eu [5.135.3.88])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id D16145E15C
	for <804@bugs.x2go.org>; Tue, 10 Mar 2015 17:22:34 +0100 (CET)
Received: from nopileos.local (home.ionic.de [217.92.117.31])
	by mail.ionic.de (Postfix) with ESMTPSA id 2E1E94F08880;
	Tue, 10 Mar 2015 17:22:34 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1426004554; bh=/1xMoV/5MkbTtfR4RPE0mesLClp3slc2ySGdJn+1wqU=;
	h=Date:From:To:Subject:References:In-Reply-To:From;
	b=bK2plTyZNoZfY/B3hTocNCmvPCxqIlc5tipjLixuGWtlo+KV1Y1Q0WqcffSd2d8Uy
	 f0HaP2sBxatcUMcJWvy2nr8/3ok8hCgRWFBb99MDlsY+xbdK8vm/szk4RpqYZ1EUHA
	 lzPXENFn6qaokgdpqV/dN61jgo5jkeg/RgRVNNFE=
Message-ID: <54FF1A44.4000403@ionic.de>
Date: Tue, 10 Mar 2015 17:22:28 +0100
From: Mihai Moldovan <ionic@ionic.de>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Will Wagner <willw@carallon.com>, 804@bugs.x2go.org
References: <54F98E42.9090408@carallon.com> <54FA5DDB.2040607@ionic.de> <54FDF871.4040300@carallon.com> <54FDF96D.3000805@ionic.de> <54FECAD7.8030501@carallon.com>
In-Reply-To: <54FECAD7.8030501@carallon.com>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="u2LDGxHn4kvGHQ2IPqi2Rsci5r6IwEuxu"

[Message part 1 (text/plain, inline)]
On 10.03.2015 11:43 AM, Will Wagner wrote:
> So today I can unfortunately still reproduce this issue. It seems
> like yesterday there must have been something going on with my
> network which altered the timing of events.

Btw, I think this has nothing to do with the network. On Windows, Xorg
(and sshd) must be started whenever X2Go Client starts up, so if you
start X2Go Client and connect to a session *fast enough* after startup,
you can trigger this race condition.


> The debug log I get now is: [...]
> x2go-DEBUG-../src/onmainwindow.cpp:5176> Waiting for win-servers.
> QObject::connect: Incompatible sender/receiver arguments
> QSingleShotTimer::timeout() --> ONMainWindow::slotTunnelOk(int)
> x2go-DEBUG-../src/sshprocess.cpp:157> Direct tunnel: waiting for
> connections on "localhost":31004
>
> x2go-DEBUG-../src/onmainwindow.cpp:9316> got localhost
> x2go-DEBUG-../src/onmainwindow.cpp:9344> Port already used: 6001
> x2go-DEBUG-../src/onmainwindow.cpp:9498> X is started.
> x2go-DEBUG-../src/onmainwindow.cpp:9865> All winservers are started.
>
>
>
> Looking at the change you made I don't believe you are allowed to
> connect a signal emitting no arguments to a slot that requires an
> argument and hence the incompatible sender/receiver argument error.

Yes. The problem at hand is that this parameter is purely optional
anyway and never used.

I totally missed that "this" in that context does not refer to
slotTunnelOk(int) but QSingleShotTimer::timeout(), which has no parameter.

http://code.x2go.org/releases/binary-win32/x2goclient/tmp/x2goclient-4.0.4.0-2015.03.10-ffc56f3-setup.exe



Mihai



[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Sun Nov 24 05:15:57 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.