X2Go Bug report logs - #799
x2golistdesktops returns nothing

version graph

Package: x2goserver; Maintainer for x2goserver is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver is src:x2goserver.

Reported by: Anatoly Smaznov <mrjavum@gmail.com>

Date: Sun, 1 Mar 2015 09:35:01 UTC

Severity: normal

Tags: pending

Fixed in version 4.0.1.20

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#799: x2golistdesktops - ss options
Reply-To: Orion Poplawski <orion@cora.nwra.com>, 799@bugs.x2go.org
Resent-From: Orion Poplawski <orion@cora.nwra.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Thu, 22 Sep 2016 03:55:01 +0000
Resent-Message-ID: <handler.799.B799.14745164142505@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 799
X-X2Go-PR-Package: x2goserver
X-X2Go-PR-Keywords: 
Received: via spool by 799-submit@bugs.x2go.org id=B799.14745164142505
          (code B ref 799); Thu, 22 Sep 2016 03:55:01 +0000
Received: (at 799) by bugs.x2go.org; 22 Sep 2016 03:53:34 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=3.0 tests=BAYES_20,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 71BAB5DA96
	for <799@bugs.x2go.org>; Thu, 22 Sep 2016 05:53:31 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id jfXtyfBnYwOh for <799@bugs.x2go.org>;
	Thu, 22 Sep 2016 05:53:24 +0200 (CEST)
X-Greylist: delayed 567 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Thu, 22 Sep 2016 05:53:23 CEST
Received: from mail.nwra.com (mail.nwra.com [72.52.192.72])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id E14F25DA94
	for <799@bugs.x2go.org>; Thu, 22 Sep 2016 05:53:23 +0200 (CEST)
Received: from pacas.cora.nwra.com (c-73-229-183-36.hsd1.co.comcast.net [73.229.183.36])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.nwra.com (Postfix) with ESMTPSA id 0B222340466
	for <799@bugs.x2go.org>; Wed, 21 Sep 2016 20:43:53 -0700 (PDT)
To: 799@bugs.x2go.org
From: Orion Poplawski <orion@cora.nwra.com>
Message-ID: <78b50c98-b003-7f16-52b0-dcfe9d2f6fdd@cora.nwra.com>
Date: Wed, 21 Sep 2016 21:43:51 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

So, it appears to be well known that 'ss -lxu' has been broken on some 
systems and returns nothing.  This is currently true on EL 7.2 though 
appears fixed in 7.3 beta.

However, why is -u being passed to ss in the first place?  We're doing:

my $lines=system_capture_stdout_output("ss", "-lxu");
my @lines=split("\n", "$lines");
my @outp = grep ( /(@| )\/tmp\/.X11-unix\/X.*/, @lines);
for(my $i=0;$i<@outp;$i++)
{
...

so we're filtering the output of ss for lines that look like unix 
sockets (/tmp/.X11-unix/X*), so -lx is appropriate.  But why use '-u' to 
show UDP sockets?  No X server that I know of listens on UDP and we 
certainly would filter it out anyway.

diff --git a/x2goserver/bin/x2golistdesktops 
b/x2goserver/bin/x2golistdesktops
index 386ed17..1cbc7ef 100755
--- a/x2goserver/bin/x2golistdesktops
+++ b/x2goserver/bin/x2golistdesktops
@@ -66,7 +66,7 @@ my $uname=$ENV{'USER'};
 # -> so we need to tweak the PATH env var a little here...
 my $old_PATH=$ENV{'PATH'};
 $ENV{'PATH'}="$ENV{'PATH'}:/usr/sbin:/sbin";
-my $lines=system_capture_stdout_output("ss", "-lxu");
+my $lines=system_capture_stdout_output("ss", "-lx");
 $ENV{'PATH'}=$old_PATH;
 undef $old_PATH;

See also https://bugzilla.redhat.com/show_bug.cgi?id=1371690

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA/CoRA Division                    FAX: 303-415-9702
3380 Mitchell Lane                  orion@cora.nwra.com
Boulder, CO 80301              http://www.cora.nwra.com

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 16:11:02 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.