X2Go Bug report logs - #744
user-local keystrokes.cfg does not work

version graph

Package: x2goagent; Maintainer for x2goagent is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goagent is src:nx-libs.

Reported by: Horst Schirmeier <horst@schirmeier.com>

Date: Thu, 15 Jan 2015 15:20:01 UTC

Severity: normal

Tags: patch, pending

Found in version 2:3.5.0.29-0x2go1~git20150113.557+wheezy.heuler.1

Fixed in version 2:3.5.0.29

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#744: [X2Go-Dev] Bug#744: user-local keystrokes.cfg does not work
Reply-To: Mihai Moldovan <ionic@ionic.de>, 744@bugs.x2go.org
Resent-From: Mihai Moldovan <ionic@ionic.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Thu, 15 Jan 2015 21:00:02 +0000
Resent-Message-ID: <handler.744.B744.142135545712973@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 744
X-X2Go-PR-Package: x2goagent
X-X2Go-PR-Keywords: 
Received: via spool by 744-submit@bugs.x2go.org id=B744.142135545712973
          (code B ref 744); Thu, 15 Jan 2015 21:00:02 +0000
Received: (at 744) by bugs.x2go.org; 15 Jan 2015 20:57:37 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from Root24.de (powered.by.root24.eu [5.135.3.88])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 783713BC67
	for <744@bugs.x2go.org>; Thu, 15 Jan 2015 21:57:35 +0100 (CET)
Received: from nopileos.local (HSI-KBW-078-042-092-253.hsi3.kabel-badenwuerttemberg.de [78.42.92.253])
	by mail.ionic.de (Postfix) with ESMTPSA id AEBAE4F00137;
	Thu, 15 Jan 2015 21:57:34 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1421355454; bh=4KpubytMo0cXQqTi+toESJuUoFHce8QdYgRYuenxZeo=;
	h=Date:From:To:CC:Subject:References:In-Reply-To:From;
	b=K1ZxXe78FFPwYnvrtHcv3NlktrPANu3901Pj5Y47lC4mL1GNn/G/AGbsbn+X42uJl
	 XCMHs6c5+Srt50EkI/RRuEedBqQidoM5m2PsoVl0apyDNgVrJTj6Bw+/ykarutay77
	 8iDQyf3SoLB5975T02NR2tvYx9gLnb+K/1+sPkpM=
Message-ID: <54B829B7.4030902@ionic.de>
Date: Thu, 15 Jan 2015 21:57:27 +0100
From: Mihai Moldovan <ionic@ionic.de>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Horst Schirmeier <horst@schirmeier.com>
CC: 744@bugs.x2go.org
References: <20150115151045.GI22378@quickstop.soohrt.org>
In-Reply-To: <20150115151045.GI22378@quickstop.soohrt.org>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="mQo4XlOGGeo5fMOoQF3f2cdP0WanhVAWE"

[Message part 1 (text/plain, inline)]
On 15.01.2015 04:10 PM, Horst Schirmeier wrote:
>  debian/wrappers/x2goagent | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/debian/wrappers/x2goagent b/debian/wrappers/x2goagent
> index 129c7ca..750c651 100644
> --- a/debian/wrappers/x2goagent
> +++ b/debian/wrappers/x2goagent
> @@ -29,7 +29,15 @@ test -x $NX_LIBS/../x2go/bin/$NXAPP && export NX_LIBS=$NX_LIBS
>  
>  export LD_LIBRARY_PATH
>  
> -NXAGENT_KEYSTROKEFILE=/etc/x2go/keystrokes.cfg
> -export NXAGENT_KEYSTROKEFILE
> +for CONFIG in ~/.x2go/config/keystrokes.cfg ~/.nx/config/keystrokes.cfg \
> +              /etc/x2go/keystrokes.cfg /etc/nxagent/keystrokes.cfg

Do we actually WANT to make ~/.nx/foo override /etc/x2go/foo *for
x2goagent*? Or do we rather want to get rid of ~/.nx and /etc/nxagent
entirely within x2go components (which, really, would make some sort of
sense, especially if $SOMETHING created ~/.nx/config/keystrokes.cfg and
users wonder why /etc/x2go/keystrokes.cfg does not take any effect.)

Actually, I see another problem there. Wouldn't it be smarter to
consider both ~/.x2go/foo and /etc/x2go/keystrokes.cfg (if existent),
with values in ~/.x2go/foo overriding those of the global configuration
file? A priority-based merge would really be the thing we're looking
for. I've got something like that lying around.

It's not exactly small, though. And would benefit from being shared
code, as it could (and also would) be used in both x2goagent and x2goserver.



Mihai


[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Wed Dec 4 08:47:22 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.