#744 - user-local keystrokes.cfg does not work

X2Go Bug report logs - #744
user-local keystrokes.cfg does not work

Reported by: Horst Schirmeier <horst@schirmeier.com>

Date: Thu, 15 Jan 2015 15:20:01 UTC

Severity: normal

Tags: patch, pending

Found in version 2:3.5.0.29-0x2go1~git20150113.557+wheezy.heuler.1

Fixed in version 2:3.5.0.29

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

X-Loop: owner@bugs.x2go.org
Subject: Bug#744: [X2Go-Dev] Bug#744: user-local keystrokes.cfg does not work
Reply-To: Horst Schirmeier <horst@schirmeier.com>, 744@bugs.x2go.org
Resent-From: Horst Schirmeier <horst@schirmeier.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Thu, 15 Jan 2015 21:35:01 +0000
Resent-Message-ID: <handler.744.B744.142135762215476@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 744
X-X2Go-PR-Package: x2goagent
X-X2Go-PR-Keywords: 
Received: via spool by 744-submit@bugs.x2go.org id=B744.142135762215476
          (code B ref 744); Thu, 15 Jan 2015 21:35:01 +0000
Received: (at 744) by bugs.x2go.org; 15 Jan 2015 21:33:42 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=ham
	version=3.3.2
X-Greylist: delayed 399 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Thu, 15 Jan 2015 22:33:41 CET
Received: from quickstop.soohrt.org (quickstop.soohrt.org [85.131.246.152])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id A14363BC67
	for <744@bugs.x2go.org>; Thu, 15 Jan 2015 22:33:41 +0100 (CET)
Received: (qmail 1781 invoked by uid 1014); 15 Jan 2015 21:27:01 -0000
Date: Thu, 15 Jan 2015 22:27:01 +0100
From: Horst Schirmeier <horst@schirmeier.com>
To: Mihai Moldovan <ionic@ionic.de>
Cc: 744@bugs.x2go.org
Message-ID: <20150115212701.GN22378@quickstop.soohrt.org>
References: <20150115151045.GI22378@quickstop.soohrt.org>
 <54B829B7.4030902@ionic.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="lildS9pRFgpM/xzO"
Content-Disposition: inline
In-Reply-To: <54B829B7.4030902@ionic.de>
User-Agent: Mutt/1.5.21 (2010-09-15)

[Message part 1 (text/plain, inline)]

On Thu, 15 Jan 2015, Mihai Moldovan wrote: > Do we actually WANT to make ~/.nx/foo override /etc/x2go/foo *for > x2goagent*? Or do we rather want to get rid of ~/.nx and /etc/nxagent > entirely within x2go components (which, really, would make some sort of > sense, especially if $SOMETHING created ~/.nx/config/keystrokes.cfg and > users wonder why /etc/x2go/keystrokes.cfg does not take any effect.) I have no objection removing ~/.nx and /etc/nxagent from the file list in my patch, keeping ~/.x2go/config/keystrokes.cfg and /etc/x2go/keystrokes.cfg. As ~/.nx does not work at all at the moment, this wouldn't even break existing setups (but would require updating the documentation in the wiki). > Actually, I see another problem there. Wouldn't it be smarter to > consider both ~/.x2go/foo and /etc/x2go/keystrokes.cfg (if existent), > with values in ~/.x2go/foo overriding those of the global configuration > file? A priority-based merge would really be the thing we're looking > for. I've got something like that lying around. > > It's not exactly small, though. And would benefit from being shared > code, as it could (and also would) be used in both x2goagent and x2goserver. This may or may not be a good idea. For example, IMHO it'd require introducing a way to completely remove/disable /etc/x2go/keystrokes.cfg definitions via directives in user-local files, instead of only overriding key definitions. Also, it has the potential of not being compatible to existing setups. Nevertheless, I suggest opening a new bug for this, as #744 needs to be fixed either way. Horst -- PGP-Key 0xD40E0E7A

[signature.asc (application/pgp-signature, inline)]

X2Go Developers <owner@bugs.x2go.org>. Last modified: Wed Dec 4 08:32:11 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

X2Go Bug report logs - #744 user-local keystrokes.cfg does not work

X2Go Bug report logs - #744
user-local keystrokes.cfg does not work