X2Go Bug report logs - #742
Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: "George Trakatelis" <trakatelis@uom.edu.gr>

Date: Wed, 14 Jan 2015 19:10:02 UTC

Severity: normal

Tags: patch, pending

Found in version 4.0.3.0

Fixed in version 4.0.3.2

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#742: X2Go issue (in src:x2goclient) has been marked as pending for release
Reply-To: "George Trakatelis" <trakatelis@uom.edu.gr>, 742@bugs.x2go.org
Resent-From: "George Trakatelis" <trakatelis@uom.edu.gr>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 27 Jan 2015 22:25:01 +0000
Resent-Message-ID: <handler.742.B742.14223973388989@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 742
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: pending patch
Received: via spool by 742-submit@bugs.x2go.org id=B742.14223973388989
          (code B ref 742); Tue, 27 Jan 2015 22:25:01 +0000
Received: (at 742) by bugs.x2go.org; 27 Jan 2015 22:22:18 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,
	RCVD_IN_DNSWL_BLOCKED,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 075965DB52
	for <742@bugs.x2go.org>; Tue, 27 Jan 2015 23:22:15 +0100 (CET)
Received: by mail-we0-f174.google.com with SMTP id w55so12108419wes.5
        for <742@bugs.x2go.org>; Tue, 27 Jan 2015 14:22:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=uom.edu.gr; s=google;
        h=from:to:cc:references:in-reply-to:subject:date:message-id
         :mime-version:content-type:content-transfer-encoding:thread-index
         :content-language;
        bh=vefjMoI0MEUjI9w46zzC6k2kDbcRRH2jo4rvKuk3W3g=;
        b=dWfUgdeNkyzAlM0yK096F+rh8+xPIKxxHNuOuW9ixoUl7SM3ok1xu7wri7WE1+0Al/
         oUaNt+8cEafU2DGPtkJdPPv1AwBc2UynNTTwMyYgXBHQgqhcNnyosTmGPqBlskTJMXLK
         3ej5ItlguK7U4ufHGTjACgAckZKgzvvlfUAcg=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date
         :message-id:mime-version:content-type:content-transfer-encoding
         :thread-index:content-language;
        bh=vefjMoI0MEUjI9w46zzC6k2kDbcRRH2jo4rvKuk3W3g=;
        b=UXqKeqPI1nahhUZjX/4rJwg1vtWi6EaBAStyoVaTq8FJWbfICwysU1zxb+JEGR/XXQ
         Lo+m1MuG0RZ0Lq4Yl6k+JznXp/S3dZ1MdPQNNC3b6Nz3ARvzrWWhq74g2JQVUxeiZS/G
         8bDzRkY3WeTidOh5Un++hMpe4gsRUnp1N9MZDYCWao+BFCKplRCNK+eNqsGeBybMRQ/X
         2gF3X0/IXMDj6/xk83qir9FvAljeid/xqlA7h0/tneWh9lzaCrGRL8FZ+TZj6mXGCI8e
         ov/FBlE2cSLKpwcFgYvJyUshuJhIU+w3jdRFZ9XKuCo/Ryxci6mlw39Tdv3eZsYBQHDc
         HGKw==
X-Gm-Message-State: ALoCoQlBnDRXNkpQQHUlb5v6ZF1e6G3cOZ5YQqTnszT+ZVDVm2Diu4P/2OeNVy49vwpurF+rHs4c
X-Received: by 10.194.20.67 with SMTP id l3mr633825wje.94.1422397335567;
        Tue, 27 Jan 2015 14:22:15 -0800 (PST)
Received: from HomePC (46-198-127-233.adsl.cyta.gr. [46.198.127.233])
        by mx.google.com with ESMTPSA id ev7sm3546915wjb.47.2015.01.27.14.22.14
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Tue, 27 Jan 2015 14:22:15 -0800 (PST)
From: "George Trakatelis" <trakatelis@uom.edu.gr>
To: "'Mike DePaulo'" <mikedep333@gmail.com>,
	<ionic@ionic.de>
Cc: <742@bugs.x2go.org>
References: <20150125145249.E38405DB54@ymir.das-netzwerkteam.de>
In-Reply-To: <20150125145249.E38405DB54@ymir.das-netzwerkteam.de>
Date: Wed, 28 Jan 2015 00:22:14 +0200
Message-ID: <000001d03a7f$b4be6aa0$1e3b3fe0$@edu.gr>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: AdA4rufoLKcvcPaXRNaUF57JKk+SWABy7o/w
Content-Language: el

Hi Mike#2 and Mihai, 

I just traced x2goclient's code back and found that 
the last release of x2goclient for Windows that executed parec was 3.99.2.2. 
The programming error I'm referring to was introduced in release 3.99.3.0.  
From then on, parec never had the chance to execute. 
In fact, executing it makes x2goclient really slow. 

So, to be precise, this fix removes an unnecessary endless check 
testing if it's time to execute parec. 
I don't know if it's worth mentioning it and 
I don't have a clue about the implications (if any) of the error 
back in November 2012 (when x2goclient 3.99.3.0 was out). 

George

> -----Original Message-----
> From: Mike DePaulo [mailto:mikedep333@gmail.com]
> Sent: Sunday, January 25, 2015 4:53 PM
> To: 742-submitter@bugs.x2go.org
> Cc: control@bugs.x2go.org; 742@bugs.x2go.org
> Subject: Bug#742: X2Go issue (in src:x2goclient) has been marked as
> pending for release
> 
> tag #742 pending
> fixed #742 4.0.3.2
> thanks
> 
> Hello,
> 
> X2Go issue #742 (src:x2goclient) reported by you has been fixed in X2Go
> Git. You can see the changelog below, and you can check the diff of the
> fix at:
> 
>     http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=fd1151e
> 
> The issue will most likely be fixed in src:x2goclient (4.0.3.2).
> 
> light+love
> X2Go Git Admin (on behalf of the sender of this mail)
> 
> ---
> commit fd1151e48ad325c18857f1d3daceb5b8e5edda9d
> Author: Mike DePaulo <mikedep333@gmail.com>
> Date:   Sun Jan 25 09:52:38 2015 -0500
> 
>     Update Changelog about #742
> 
> diff --git a/debian/changelog b/debian/changelog index 9e4d06b..e50be3b
> 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -58,6 +58,10 @@ x2goclient (4.0.3.2-0x2go1) UNRELEASED;
> urgency=medium
>        functionality, not the SSH server functionality.
>        0.6.4 also added 4 features related to ECDSA keys.
>      - Windows: Fix compatibility with PulseAudio 6.0
> +    - Windows: Remove workaround for audio input with old versions of
> +      PulseAudio (calling parec once per second)
> +      (Fixes: #742)
> +      Thanks George Trakatelis (uom.edu.gr) for submitting this
> change.
>      - Windows: Enable X2Go Client for Windows to build under VS2010
> nmake
>        (but not the VS2010 IDE due to a Qt4 Visual Studio Add-in
> limitation)
>        Note that the official builds are still build under MinGW.

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 19:07:46 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.