X2Go Bug report logs - #742
Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0

Full log

🔗 View this message in rfc822 format

MIME-Version: 1.0
X-Mailer: MIME-tools 5.502 (Entity 5.502)
X-Loop: owner@bugs.x2go.org
From: owner@bugs.x2go.org (X2Go Bug Tracking System)
Subject: Bug#742 closed by Michael DePaulo <mikedep333@gmail.com> (Re:
 [X2Go-Dev] Bug#742: Bug#742: Executing parec seems unnecessary now that
 X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0)
Message-ID: <handler.742.b742.14221447104356.notifdone@bugs.x2go.org>
References: <CAMKht8iDrp7g7pFsj7ZGD2vsAmJB=YnTUSNE56AQ_eouwOEB-w@mail.gmail.com>
X-X2go-PR-Keywords: patch
X-X2go-PR-Message: they-closed 742
X-X2go-PR-Package: x2goclient
X-X2go-PR-Source: x2goclient
Date: Sun, 25 Jan 2015 00:15:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1422144902-4961-0"

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your Bug report
which was filed against the x2goclient package:

#742: Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0

It has been closed by Michael DePaulo <mikedep333@gmail.com>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Michael DePaulo <mikedep333@gmail.com> by
replying to this email.


-- 
742: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=742
X2Go Bug Tracking System
Contact owner@bugs.x2go.org with problems

[Message part 2 (message/rfc822, inline)]

From: Michael DePaulo <mikedep333@gmail.com>

To: 742@bugs.x2go.org, George Trakatelis <trakatelis@uom.edu.gr>

Subject: Re: [X2Go-Dev] Bug#742: Bug#742: Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0

Date: Sat, 24 Jan 2015 19:11:48 -0500

Control: close -1 4.0.3.2

On Sat, Jan 24, 2015 at 6:30 PM, Michael DePaulo <mikedep333@gmail.com> wrote:
[...]
>> On  Mi 14 Jan 2015 20:05:46 CET, George Trakatelis wrote:
>>
>>>[...]
>>>
>>> The attached patch saves x2goclient from calling slotStartParec()
>>> once per second unnecessarily.
>> thanks for providing this patch, George.
>
> Thanks!
>
> I'll test the patch for regressions. If there are none, I will commit it.
> (I will however delete that 1 line rather than comment it out.)

I tested it successfully on XP 32-bit and on Windows 8.1 64-bit. So I
applied it (after deleting that one commented out line.)

Also, I did not bother to update the changelog because I feel this is
a very minor change, and I do not want to bombard users with too many
details in the changelog. I will confirm on x2go-project that doing so
is OK.

Thanks,

-Mike#2

[Message part 3 (message/rfc822, inline)]

From: "George Trakatelis" <trakatelis@uom.edu.gr>

To: <submit@bugs.x2go.org>

Cc: "'Michael DePaulo'" <mikedep333@gmail.com>

Subject: Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0

Date: Wed, 14 Jan 2015 21:05:46 +0200

[Message part 4 (text/plain, inline)]

Package: x2goclient
Version: 4.0.3.0

When trying to figure out why I get 
'Object::connect: No such slot ONMainWindow::slotSndTunOk(int)' 
in the debugging output of X2Go Client for Windows 4.0.3.0, 
I bumped onto a common error: 
Argument mismatch between function call and function definition. 
That prevents slotSndTunOk() from ever executing. 

slotStartParec() depends on slotSndTunOk() to execute parec. 
Executing parec was needed due to a PulseAudio's bug as explained in 
http://x2go-dev.x2go.narkive.com/wNgRoxTO/parec

One peculiar thing is that after fixing that mismatch, 
which enabled parec to execute, 
x2goclient became extremely sluggish. 
The only way to revert things back to normal 
was to prevent parec from ever executing. 
It seems that parec in not needed now that X2Go Client uses PulseAudio 5.0.

The attached patch saves x2goclient from calling slotStartParec() 
once per second unnecessarily. 

Dept. of Applied Informatics, University of Macedonia
George Trakatelis

[disable-calling-parec.patch (application/octet-stream, attachment)]

Send a report that this bug log contains spam.