X2Go Bug report logs - #74
make nxagent keybindings configurable

Package: x2goagent; Maintainer for x2goagent is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goagent is src:nx-libs.

Reported by: Alexander Wuerstlein <arw@arw.name>

Date: Mon, 3 Dec 2012 14:18:01 UTC

Severity: normal

Tags: pending

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

Message #47 received at control@bugs.x2go.org (full text, mbox, reply):

Received: (at control) by bugs.x2go.org; 6 Dec 2012 08:50:50 +0000
From mike.gabriel@das-netzwerkteam.de  Thu Dec  6 09:50:50 2012
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir (Postfix) with ESMTPS id 077FA3BC43;
	Thu,  6 Dec 2012 09:50:50 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id D49A01F4;
	Thu,  6 Dec 2012 09:50:49 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id C87213BB65;
	Thu,  6 Dec 2012 09:50:49 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 0WPLqJSS6-E0; Thu,  6 Dec 2012 09:50:49 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 9B9153BFE0;
	Thu,  6 Dec 2012 09:50:49 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 7FFFC3BB65;
	Thu,  6 Dec 2012 09:50:49 +0100 (CET)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	grimnir.das-netzwerkteam.de
X-Spam-Flag: NO
X-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00
	autolearn=ham version=3.3.1 running as userid=
X-Spam-Level: 
X-Spam-Bayes-Score: 0.0000
Received: by grimnir.das-netzwerkteam.de (Postfix, from userid 33)
	id 13A3D3BFD9; Thu,  6 Dec 2012 09:50:49 +0100 (CET)
Received: from nocatv2.tng.de (nocatv2.tng.de [213.178.75.58]) by
 mail.das-netzwerkteam.de (Horde Framework) with HTTP; Thu, 06 Dec 2012
 09:50:49 +0100
Message-ID: <20121206095049.195939xc33v4r0q1@mail.das-netzwerkteam.de>
X-Priority: 3 (Normal)
Date: Thu, 06 Dec 2012 09:50:49 +0100
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Alexander Wuerstlein <arw@arw.name>, 74@bugs.x2go.org
Cc: control@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#74: Fix build error caused by patch for #74
 (missing nxagentKeystrokeFile)
References: <20121204135344.54254nxpjlf4npso@mail.das-netzwerkteam.de>
 <1354748567-23433-1-git-send-email-arw@arw.name>
In-Reply-To: <1354748567-23433-1-git-send-email-arw@arw.name>
MIME-Version: 1.0
Content-Type: multipart/signed;
 boundary="=_7ccgu5plrop";
 protocol="application/pgp-signature";
 micalg="pgp-sha1"
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) H3 (4.3.4)

[Message part 1 (text/plain, inline)]
tag #74 pending
thanks

THANKS!
Committed:
http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=26901cc52224dbfbf308b9252640563e4b52e960

Package seems to build fine now.
Thanks for the quick response!!!

Mike

On Do 06 Dez 2012 00:02:47 CET Alexander Wuerstlein wrote:

> Adds command line argument -keystrokefile to nxagent which fills
> the nxagentKeystrokeFile variable
> ---
>  .../302_nxagent_configurable-keystrokes.full.patch |   42  
> ++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git  
> a/debian/patches/302_nxagent_configurable-keystrokes.full.patch  
> b/debian/patches/302_nxagent_configurable-keystrokes.full.patch
> index fb74739..8fb34df 100644
> --- a/debian/patches/302_nxagent_configurable-keystrokes.full.patch
> +++ b/debian/patches/302_nxagent_configurable-keystrokes.full.patch
> @@ -987,3 +987,45 @@ Description: Make nxagent-specific keyboard  
> bindings configurable
>  +regions_on_screen
>  +test_input
>  +deactivate_input_devices_grab
> +--- a/nx-X11/programs/Xserver/hw/nxagent/Args.c
> ++++ b/nx-X11/programs/Xserver/hw/nxagent/Args.c
> +@@ -148,6 +148,8 @@
> +
> + char nxagentVerbose = 0;
> +
> ++char *nxagentKeystrokeFile = NULL;
> ++
> + int ddxProcessArgument(int argc, char *argv[], int i)
> + {
> +   /*
> +@@ -1021,6 +1023,20 @@
> +     return 1;
> +   }
> +
> ++  if (!strcmp(argv[i], "-keystrokefile"))
> ++  {
> ++    if (i + 1 < argc)
> ++    {
> ++      if (NULL != (nxagentKeystrokeFile = strdup(argv[i + 1])))
> ++      {
> ++        return 2;
> ++      } else {
> ++	FatalError("malloc failed");
> ++      }
> ++    }
> ++    return 0;
> ++  }
> ++
> +   return 0;
> + }
> +
> +--- a/nx-X11/programs/Xserver/hw/nxagent/Args.h
> ++++ b/nx-X11/programs/Xserver/hw/nxagent/Args.h
> +@@ -83,4 +83,6 @@
> +
> + extern int nxagentRemoteMajor;
> +
> ++extern char *nxagentKeystrokeFile;
> ++
> + #endif /* __Args_H__ */
> +
> --
> 1.7.10.4
> _______________________________________________
> X2Go-Dev mailing list
> X2Go-Dev@lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/x2go-dev
>



-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Mon May 19 13:23:17 2025; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.