X2Go Bug report logs - #720
Unrecognized arguments when using --broker-krblogin

Full log

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 6 Jan 2015 18:25:42 +0000
From m.richardson@ed.ac.uk  Tue Jan  6 19:25:40 2015
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=ham
	version=3.3.2
X-Greylist: delayed 2133 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Tue, 06 Jan 2015 19:25:40 CET
Received: from treacle.ucs.ed.ac.uk (treacle.ucs.ed.ac.uk [129.215.16.102])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id B17783BC49
	for <submit@bugs.x2go.org>; Tue,  6 Jan 2015 19:25:40 +0100 (CET)
Received: from lmtp1.ucs.ed.ac.uk (lmtp1.ucs.ed.ac.uk [129.215.149.64])
	by treacle.ucs.ed.ac.uk (8.13.8/8.13.4) with ESMTP id t06HnrA1012120
	for <submit@bugs.x2go.org>; Tue, 6 Jan 2015 17:49:58 GMT
Received: from [129.215.183.3] (pcw3047.see.ed.ac.uk [129.215.183.3])
	(authenticated user=mrichar1 mech=PLAIN bits=0)
	by lmtp1.ucs.ed.ac.uk (8.13.8/8.13.7) with ESMTP id t06HnpuY010081
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT)
	for <submit@bugs.x2go.org>; Tue, 6 Jan 2015 17:49:52 GMT
Message-ID: <54AC203F.4050508@ed.ac.uk>
Date: Tue, 06 Jan 2015 17:49:51 +0000
From: Matthew Richardson <m.richardson@ed.ac.uk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: submit@bugs.x2go.org
Subject: Unrecognized arguments when using --broker-krblogin
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Edinburgh-Scanned: at treacle.ucs.ed.ac.uk
    with MIMEDefang 2.60, Sophie, Sophos Anti-Virus, Clam AntiVirus
X-Scanned-By: MIMEDefang 2.60 on 129.215.16.102
X-Scanned-By: MIMEDefang 2.52 on 129.215.149.64

Package: x2goclient
Version: 4.0.2.1 (Qt - 4.8.6)

I am running x2goclient using the following cmd-line options:

x2goclient --debug --broker-krblogin
--broker-url=ssh://broker.example.com:22/usr/bin/x2gobroker

This returns a suitable session from the broker, but then fails to
connect, giving an error about invalid arguments:

x2go-DEBUG-../onmainwindow.cpp:2199> Reading 1 session from config file.
x2go-DEBUG-../onmainwindow.cpp:2803> Starting session via smartcard,
ssh-agent or kerberos token.
x2go-DEBUG-../httpbrokerclient.cpp:282> called selectUserSessions
x2go-DEBUG-../httpbrokerclient.cpp:467> "usage: x2gobroker.orig [-h] [-M
BROKER_MODE] [-C CONFIG_FILE] [-d] [-i]
                       [-b BIND_ADDRESS] [-D] [-P PIDFILE] [-L LOGDIR]
                       [--task BROKER_TASK] [--user USER_NAME]
                       [--auth-cookie AUTH_ID] [--profile-id PROFILE_ID]
                       [--backend BROKER_BACKEND]
x2gobroker.orig: error: unrecognized arguments: echo
X2GODATAEND:4fc77554-09cf-446a-bd44-1c2abaf8238d
"

If I run the client without the '--broker-krblogin' option, and
authenticate to the broker using password or ssh key, this error never
appears and the connection to the server (from the downloaded session)
succeeds.

I tried replacing the x2gobroker with a wrapper that calls it via
strace, and I see the following in the strace output:

execve("/usr/bin/x2gobroker.orig", ["/usr/bin/x2gobroker.orig",
"--user", "mrichar1", "--authid",
"f4d2e31c-8438-4cd3-8248-4b35f86e07ff", "--task", "selectsession",
"--sid", "pool-icewm;", "echo",
"X2GODATAEND:9c607aa1-a3c3-4c29-a7dc-36847ec8ceb0"], [/* 24 vars */])

I notice that the semi-colon separating the sid value and the subsequent
command appears inside the sid value quotes, which seems wrong - indeed
running this as a test gives:

x2gobroker --debug --sid "test;" true

x2gobroker.orig: error: unrecognized arguments: true

Can this quoting be sorted out to allow the use of the --broker-krblogin
option?

Thanks,

Matthew



-- 
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.

Send a report that this bug log contains spam.