X2Go Bug report logs - #715
Cannot create X2Go Session Database on EPEL 5

version graph

Package: x2goserver; Maintainer for x2goserver is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver is src:x2goserver.

Reported by: Michael DePaulo <mikedep333@gmail.com>

Date: Sat, 3 Jan 2015 17:20:02 UTC

Severity: grave

Tags: pending

Found in version 4.0.1.18

Fixed in version 4.0.1.19

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log


Message #25 received at 715@bugs.x2go.org (full text, mbox, reply):

Received: (at 715) by bugs.x2go.org; 5 Jan 2015 15:22:44 +0000
From mike.gabriel@das-netzwerkteam.de  Mon Jan  5 16:22:43 2015
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 1B0315DB48
	for <715@bugs.x2go.org>; Mon,  5 Jan 2015 16:22:43 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id A15CB1307;
	Mon,  5 Jan 2015 16:22:42 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 95B393C86B;
	Mon,  5 Jan 2015 16:22:42 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id dX4i8l9nBPHg; Mon,  5 Jan 2015 16:22:42 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 749F53C862;
	Mon,  5 Jan 2015 16:22:42 +0100 (CET)
Received: from listrac.informatik.uni-kiel.de
 (listrac.informatik.uni-kiel.de [134.245.252.114]) by
 mail.das-netzwerkteam.de (Horde Framework) with HTTP; Mon, 05 Jan 2015
 15:22:42 +0000
Date: Mon, 05 Jan 2015 15:22:42 +0000
Message-ID: <20150105152242.Horde.7brnmUBgc6vG4pA8A_6Wjg9@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Michael DePaulo <mikedep333@gmail.com>
Cc: 715@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#715: Proposed patch
References: <CAMKht8iVc1bCg3BJ1Qg=CDtE+kSKYBeUFwT6JBS7Ou9m5PS2gw@mail.gmail.com>
 <20150105101334.Horde.2WQ_Ieu5pzXhDeMONJTlrg1@mail.das-netzwerkteam.de>
 <CAMKht8jgREGEjvu9pD6guspfzSQe9djxaEM_SMSAptJqB16_tg@mail.gmail.com>
In-Reply-To: <CAMKht8jgREGEjvu9pD6guspfzSQe9djxaEM_SMSAptJqB16_tg@mail.gmail.com>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.2)
Accept-Language: en,de
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 134.245.252.114
X-Remote-Browser: Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101
 Firefox/33.0 Iceweasel/33.1
Content-Type: multipart/signed; boundary="=_EiJqtWtkPxsHzj0G_oKmfA7";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0
[Message part 1 (text/plain, inline)]
Hi Michael,

On  Mo 05 Jan 2015 14:29:18 CET, Michael DePaulo wrote:

> Hi Mike#1,
>
> On Mon, Jan 5, 2015 at 5:13 AM, Mike Gabriel
> <mike.gabriel@das-netzwerkteam.de> wrote:
>> Hi Michael,
>>
>>
>> On  Mo 05 Jan 2015 05:12:04 CET, Michael DePaulo wrote:
>>
>>> Tags: patch
>>>
>>> I would like someone who knows Perl better, such as theUser2, to
>>> review this patch.
>>>
>>> Although this is a very small patch, theUser2 advised me to be careful
>>> when creating full paths.
>>>
>>> I tested it successfully under CentOS 5 and CentOS 6.
>>>
>>> I intended to use "make_path" instead of "mkpath" if File::Path 2.06
>>> or later was detected. However, I could not figure out how to write a
>>> statement like "use File::Path( make_path)" if File::Path->VERSION is
>>> 2.06 or later. Specifically, it appears that "use" statements are
>>> executed at compile time in Perl, so they cannot be used within an if
>>> block. And I cannot just specify "use File::Path" for all versions of
>>> File::Path because "make_path" is not exported by default.
>>>
>>> EPEL 5:
>>> http://perldoc.perl.org/5.8.8/File/Path.html
>>>
>>> EPEL 6:
>>> http://perldoc.perl.org/5.10.1/File/Path.html
>>>
>>> Latest:
>>> http://perldoc.perl.org/File/Path.html
>>
>>
>> I recommend a more conditional approach testing the existence of the
>> make_path (and the mkpath) function during runtimed using the "defined"
>> command.
>>
>> See:
>> http://stackoverflow.com/questions/433752/how-can-i-determine-if-a-perl-function-exists-at-runtime
>>
>> Mike
> [...]
>
> I will follow that advice for runtime, but I still need to figure out
> what to do at compile time.
>
> http://perldoc.perl.org/functions/use.html
> "Because use takes effect at compile time, it doesn't respect the
> ordinary flow control of the code being compiled. In particular,
> putting a use inside the false branch of a conditional doesn't prevent
> it from being processed."

Ah, ok.

Simply import (use) the complete File::Path package (use File::Path)  
and reference the make_path and the mkpath function under its full  
package+function name (i.e. "File::Path::make_path", e.g.).

Mike



-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 15:22:06 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.