X2Go Bug report logs -
#70
X2Go Client: some of the debug code fails to compile
Reported by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Date: Mon, 3 Dec 2012 09:18:02 UTC
Severity: minor
Found in version HEAD
Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Bug is archived. No further changes may be made.
Full log
🔗
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
This is an automatic notification regarding your Bug report
which was filed against the x2goclient package:
#70: X2Go Client: some of the debug code fails to compile
It has been closed by Mike Gabriel <mike.gabriel@das-netzwerkteam.de>.
Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Mike Gabriel <mike.gabriel@das-netzwerkteam.de> by
replying to this email.
--
70: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=70
X2Go Bug Tracking System
Contact owner@bugs.x2go.org with problems
[Message part 2 (message/rfc822, inline)]
[Message part 3 (text/plain, inline)]
Control: close -1
Closing a bug that should be fixed by now...
Mike
--
DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
[Message part 4 (application/pgp-signature, inline)]
[Message part 5 (message/rfc822, inline)]
[Message part 6 (text/plain, inline)]
Package: x2goclient
Severity: minor
Version: HEAD
Hi Alex,
some of the debug code lines fail to compile if a LOG_FILE has been set.
The below patch shows which lines I had to comment out to make X2Go
Client compile with debug output.
Greets,
Mike
diff --git a/onmainwindow.cpp b/onmainwindow.cpp
index 76f8ba9..1f2e2b7 100644
--- a/onmainwindow.cpp
+++ b/onmainwindow.cpp
@@ -261,7 +261,7 @@ ONMainWindow::ONMainWindow ( QWidget *parent )
:QMainWindow ( parent )
QDesktopWidget wd;
- x2goDebug<<"primary screen geometry:
"<<wd.screenGeometry(wd.screenNumber(this));
+ //x2goDebug<<"primary screen geometry:
"<<wd.screenGeometry(wd.screenNumber(this));
if ( wd.screenGeometry(wd.screenNumber(this)).width() <1024 ||
wd.screenGeometry(wd.screenNumber(this)).height() <768 )
@@ -9375,7 +9375,7 @@ void ONMainWindow::slotSetProxyWinFullscreen()
void ONMainWindow::resizeProxyWinOnDisplay(int disp)
{
QRect geom=QApplication::desktop()->screenGeometry(disp-1);
- x2goDebug<<"resizing proxy win to fit display
"<<disp<<"("<<geom<<")"<<endl;
+ //x2goDebug<<"resizing proxy win to fit display
"<<disp<<"("<<geom<<")"<<endl;
#ifdef Q_OS_LINUX
XSync(QX11Info::display(),false);
XMoveWindow(QX11Info::display(), proxyWinId,geom.x(),geom.y());
@@ -9425,7 +9425,7 @@ void ONMainWindow::slotConfigXinerama()
if (newGeometry==lastDisplayGeometry)
return;
lastDisplayGeometry=newGeometry;
- x2goDebug<<"New proxy geometry: "<<lastDisplayGeometry<<endl;
+// x2goDebug<<"New proxy geometry: "<<lastDisplayGeometry<<endl;
QDesktopWidget* root=QApplication::desktop();
QList<QRect> newXineramaScreens;
for (int i=0; i< root->numScreens(); ++i)
@@ -9437,17 +9437,17 @@ void ONMainWindow::slotConfigXinerama()
intersection=root->screenGeometry(i).intersected(lastDisplayGeometry);
if (!intersection.isNull())
{
- x2goDebug<<"intersected with "<<i<<": "<<intersection<<endl;
+// x2goDebug<<"intersected with "<<i<<": "<<intersection<<endl;
intersection.moveLeft(intersection.x()-lastDisplayGeometry.x());
intersection.moveTop(intersection.y()-lastDisplayGeometry.y());
- x2goDebug<<"xinerama screen: "<<intersection<<endl;
+// x2goDebug<<"xinerama screen: "<<intersection<<endl;
newXineramaScreens<<intersection;
}
}
if (xineramaScreens != newXineramaScreens)
{
xineramaScreens=newXineramaScreens;
- x2goDebug<<"xinerama screen changed, new screens:
"<<xineramaScreens<<endl;
+// x2goDebug<<"xinerama screen changed, new screens:
"<<xineramaScreens<<endl;
xineramaTimer->stop();
QStringList screens;
foreach (QRect disp, xineramaScreens)
--
DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
[Message part 7 (application/pgp-signature, inline)]
Send a report that this bug log contains spam.
X2Go Developers <owner@bugs.x2go.org>.
Last modified:
Sat Sep 7 23:44:14 2024;
Machine Name:
ymir.das-netzwerkteam.de
X2Go Bug tracking system
Debbugs is free software and licensed under the terms of the GNU
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.
Copyright © 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.