X2Go Bug report logs - #690
request another server from broker provided server is down

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Date: Tue, 2 Dec 2014 12:35:01 UTC

Severity: wishlist

Fix blocked by 684: add exclude-hosts parameter to selectsession task

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#684: [X2Go-Dev] Bug#684: select_session offers offline servers to X2Go Client
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 684@bugs.x2go.org
Resent-From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Sat, 06 Dec 2014 23:00:02 +0000
Resent-Message-ID: <handler.684.B684.14179065695851@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 684
X-X2Go-PR-Package: python-x2gobroker
Received: via spool by 684-submit@bugs.x2go.org id=B684.14179065695851
          (code B ref 684); Sat, 06 Dec 2014 23:00:02 +0000
Received: (at 684) by bugs.x2go.org; 6 Dec 2014 22:56:09 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 7AA1E5E0E0
	for <684@bugs.x2go.org>; Sat,  6 Dec 2014 23:56:07 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 06E87E26;
	Sat,  6 Dec 2014 23:56:07 +0100 (CET)
Received: from localhost (localhost [])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 707873BDE2;
	Sat,  6 Dec 2014 23:56:06 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([])
	by localhost (grimnir.das-netzwerkteam.de []) (amavisd-new, port 10024)
	with ESMTP id yB4i5TlKWPGa; Sat,  6 Dec 2014 23:56:06 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (localhost [])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 93A503BD2D;
	Sat,  6 Dec 2014 23:56:05 +0100 (CET)
Received: from p50815251.dip0.t-ipconnect.de (p50815251.dip0.t-ipconnect.de
 []) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Sat, 06 Dec 2014 22:56:05 +0000
Date: Sat, 06 Dec 2014 22:56:05 +0000
Message-ID: <20141206225605.Horde.h0QDOmvCPLZG5RzMvTt6XA3@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Sergey Savko <savko@tophouse.ru>, 684@bugs.x2go.org
References: <143861477.96320.1417796055431.JavaMail.zimbra@tophouse.ru>
In-Reply-To: <1123477056.96337.1417796091693.JavaMail.zimbra@tophouse.ru>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.2)
Accept-Language: en,de
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101
 Firefox/32.0 Iceweasel/32.0
Content-Type: multipart/signed; boundary="=_Oy8JzmEkPC0b2OV3XAc9SQ1";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0
[Message part 1 (text/plain, inline)]
Control: clone -1 -2 -3
Control: reassign -2 x2goclient
Control: reassign -3 python-x2go
Control: retitle -1 add exclude-hosts parameter to selectsession task
Control: retitle -2 request another server from broker provided server is down
Control: retitle -3 request another server from broker provided server is down
Control: severity -1 wishlist
Control: severity -2 wishlist
Control: severity -3 wishlist
Control: block -2 by -1
Control: block -3 by -1
Control: tag -1 - patch

Hi Sergey,

On  Fr 05 Dez 2014 17:14:51 CET, Sergey Savko wrote:

> This patch work after patch from  
> http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=686

After thinking this through a little, I come to the conclusion that  
the broker cannot decide if a machine is down or not.

We have to think very generically. There may be a scenario where the  
broker machine may be on an network segment where it cannot ping/reach  
the X2Go Servers.

The X2Go Clients can reach the X2Go Broker. The broker provides an  
X2Go Server address on the "selectsession" broker task to the X2Go  
Client. Then the X2Go Client should test if that X2Go Server address  
works (via a simple ping6/ping command, machines should always be  
pingable!!!). If the ping fails, X2Go Client should go back to the  
broker and say: hey, that server failed for me, give me another one  
(but not the one you already gave me).

I fear we need to do four things for this bug to get fixed:

  1. extend broker/client communication protocol (second/third/...  
     call with a list of hosts that did not work on previous attempts)
  2. extend X2Go Session Broker with an exclude-hosts (or so)  
parameter for the
     selectsession task
  3. Adapt X2Go Client: ping X2Go Server, go back to the broker if  
server is down
     and request another server
  4. Adapt Python X2Go: dito



mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Tue Sep 26 18:17:32 2023; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.