X2Go Bug report logs - #642
Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking

Full log

Message #92 received at 642@bugs.x2go.org (full text, mbox, reply):

Received: (at 642) by bugs.x2go.org; 3 Dec 2014 05:27:49 +0000
From mikedep333@gmail.com  Wed Dec  3 06:27:46 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 2691E5DCAE
	for <642@bugs.x2go.org>; Wed,  3 Dec 2014 06:27:46 +0100 (CET)
Received: by mail-wi0-f178.google.com with SMTP id em10so3670215wid.17
        for <642@bugs.x2go.org>; Tue, 02 Dec 2014 21:27:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=y7MfvtwnqlLTdeH1JnnGxua84Vf6PWX6w+BrUoVfDlU=;
        b=oIKNVJes0YoV0Z3JfYSGCzjoNC3G5JobegdJqQuRKPRiM43x3aVg/IXxuP4X/Q6dzF
         sAvn6o4brtiEAhO2cTMTJilWZuotjgAxAi0ykmyI48AVzF2d3QC4tc7P1Cy8pLa4RFBv
         QU/wb3kTGBo8kMd7JGLEc48tGRFUO7V3GotUa+Jau0/IOTr0YxNXi7JaYRB4pUhUbL+g
         6bXO7EHP1+3ur+Q1AR4+DLdgH3o+DtFs4Y4p4Zbfgxs0SNOa2SAC4CilfYzOCxaPRCSz
         Yj4fl/82nN92yIqAaePbvfueIAEQbFjomxypQgpkhSxkBQQRVBZDiaw41nA5yF5lsl2W
         WXfQ==
MIME-Version: 1.0
X-Received: by 10.194.6.199 with SMTP id d7mr4215337wja.124.1417584465781;
 Tue, 02 Dec 2014 21:27:45 -0800 (PST)
Received: by 10.180.20.226 with HTTP; Tue, 2 Dec 2014 21:27:45 -0800 (PST)
In-Reply-To: <000a01d00e8a$836403f0$8a2c0bd0$@edu.gr>
References: <000a01d00e8a$836403f0$8a2c0bd0$@edu.gr>
Date: Wed, 3 Dec 2014 00:27:45 -0500
Message-ID: <CAMKht8gMtUujtO=Xn89fMXanba13WpDdydBJeT4PkqNJ6Onu1w@mail.gmail.com>
Subject: Re: Bug#642: Changes in X2Go Client for Windows to enable it conform
 to Visual Studio's stricter type checking
From: Michael DePaulo <mikedep333@gmail.com>
To: George Trakatelis <trakatelis@uom.edu.gr>
Cc: 642@bugs.x2go.org
Content-Type: multipart/mixed; boundary=047d7b5d43a685c3790509491afd

[Message part 1 (text/plain, inline)]

Hi George, see below

On Tue, Dec 2, 2014 at 6:48 PM, George Trakatelis <trakatelis@uom.edu.gr> wrote:
>
> Hi Michael,
>
> I built x2goclient 4.0.3.0 with MSVC2010's nmake.
> Unfortunately couldn't do so with Visual Studio 2010 IDE.
>
> > I have made a lot of progress, but I am having trouble finding a build
> > of libssh that includes the .lib file(s), and that is new enough. I
> > think the .lib file(s) are specific to MSVC.
>
> I attach a release build of libssh 0.6.3 (please rename .doc to .zip).
> The sources are from libssh-0.6.3-762055b-pageant-support-mingw482.src.zip
> with a minor patch to enable libssh compile under MSVC2010.
>
Please share that patch. When I try to "generate" the VS2010 project
files under CMake 3.0.2, I get these 2 errors:

You have called ADD_LIBRARY for library ssh_threads_shared without any
source files. This typically indicates a problem with your
CMakeLists.txt file

CMake Error: CMake can not determine linker language for target:
ssh_threads_shared

I've attached the log from CMake.

> > The 0.5.0 win32 build that includes the .lib file appears to be too old
>
> I'm not aware of the build you are referring to.
>
It doesn't matter anymore, but I was referring to this:
http://www.libssh.org/files/win32/0.5/
Which is linked to from here:
http://www.libssh.org/get-it/

> > I get this error during compile:
> > .\sshmasterconnection.cpp(297) : error C3861:
> > 'ssh_channel_accept_forward': identifier not found
>
> That seems to be a missing function declaration from libssh.h.
> Apparently, something like
> ...
> LIBSSH_API ssh_channel ssh_channel_accept_forward(ssh_session session, int
> timeout_ms, int *destination_port);
> ...
> is missing.
>
It sounds like libssh 0.5 is too old. Let's not worry about it since
we have 0.6.3 working.

>
> Please let me know if the attached ssh.lib (for compiling) and ssh.dll (for
> runtime) are ok.
>
They work :) I had to copy over the .h files,  but that took me
minimal time. Please share the aforementioned patch though.

> George

I committed an update to the x2goclient changelog. This bug should be
marked as fixed based on that commit.

Also, I am keeping rough notes on how to compile X2Go Client under VS2010 here:
https://docs.google.com/spreadsheets/d/1F5cVkCesXzTlo4oDJrGTdVFB074kkY-5q5-hgJUiXr4/edit?usp=sharing

Think of that as the delta against the MinGW instructions:
http://wiki.x2go.org/doku.php/wiki:development:build-howto-mswin:x2goclient

-Mike

[libssh-0.6.3-762055b-pageant-support-mingw482.src - VS2010 - CMake 3.0.2 Generate log.txt (text/plain, attachment)]

Send a report that this bug log contains spam.