X2Go Bug report logs - #578
nx-libs, Jpeg.cpp compilation error with jpeg-9a, with suggested patch

Full log

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 20 Aug 2014 03:25:21 +0000
From gabemarcano@yahoo.com  Wed Aug 20 05:25:19 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham version=3.3.2
Received: from nm23-vm5.bullet.mail.ne1.yahoo.com (nm23-vm5.bullet.mail.ne1.yahoo.com [98.138.91.245])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 4ED1F5DB11
	for <submit@bugs.x2go.org>; Wed, 20 Aug 2014 05:25:18 +0200 (CEST)
Received: from [98.138.100.117] by nm23.bullet.mail.ne1.yahoo.com with NNFMP; 20 Aug 2014 03:25:17 -0000
Received: from [98.138.89.173] by tm108.bullet.mail.ne1.yahoo.com with NNFMP; 20 Aug 2014 03:25:17 -0000
Received: from [127.0.0.1] by omp1029.mail.ne1.yahoo.com with NNFMP; 20 Aug 2014 03:25:17 -0000
X-Yahoo-Newman-Property: ymail-3
X-Yahoo-Newman-Id: 400997.29639.bm@omp1029.mail.ne1.yahoo.com
Received: (qmail 32203 invoked by uid 60001); 20 Aug 2014 03:25:17 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1408505117; bh=IFOIeNC6SZZ8A1PL8fcuwoLKp1Vmn/hK/6vzmz43SeQ=; h=Message-ID:Date:From:Reply-To:Subject:To:MIME-Version:Content-Type; b=RbGEXf4z3lndTjef3VVRUn9OYQ92hNO8KIXJq0mhpEMXQGCtlQTmAC6PUuur1QDjBY/UuHskI0HO9QzwPouxjz84uCyVBhlg6ncx2rnnQIMNZWouYbuMYs3vYXekwr5NztNmLKeGqYC6OAfcSwcEJCQyqf++/edWv1nN9dqqgZc=
X-YMail-OSG: hWEINOUVM1l14yOnYSGnfJeCG0MIM8X2k74RJg.LJeE1Rri
 HCLRVg8yZz5slN4FP4_doP0IL3K5n.i12Rs1HoXV.CFKJ.tbrZVVuOuPdxJb
 _CIbh83XSySxYebD5Jw1FhXvJ9MQan66519kXnRfPteZp1l2I7J7BYY5c6WR
 tC7v6qD3P1lGbeo9mrtidvVh42Bu38Oi15fTcHlXGHJmmiRirEX0nxsGcldC
 tmQVqFfZ5Wd.Z84V3oSfpNliimuWAOtbRsaMSrEHjseyOtvDzA6nEkPVH78c
 8J93_foVHytqAJfconIDRdoCTlRPshuhEpn.HRqtv_MyTdyByjUrAfRa7vRH
 KPGocpTVW0oO4pZWpkKjsb60.1gw19Bsmsm..QlJJPQIMzQlJvXK85CIdVDF
 m4p92waTO4XKZR.wHiiRKP3u8XB5NTONofMkBkeci3mTKCuPOin0W0ZAdcjB
 R_kSbOzThdKoOQVKkQa.2KVjvthDlKWRVV4M0G3jtYo2qjyu3AUP6uhOsYan
 7opg.wwOQmkdiemIDeqAlvs57wznms7Jz8gcIeADorkNoNvgntponXVY7Rbo
 biN6Oiw2j.P1fg.MER2YB.eoGaN4SRmIDxXh.fix6aDJv7U_TTlEQfDuGwg_
 oAVXaAiEkteN9LSz6VgmIYMYcZbTQBnPSguIs6yCgfpJqVz8Z9JWN2eY-
Received: from [68.187.217.134] by web125203.mail.ne1.yahoo.com via HTTP; Tue, 19 Aug 2014 20:25:17 PDT
X-Rocket-MIMEInfo: 002.001,UGFja2FnZTogbngtbGlicwpWZXJzaW9uOiBIRUFEClRhZ3M6IFBhdGNoCgpGb3VuZCB0aGlzIHByb2JsZW0gd2hpbGUgYnJvd3Npbmc6CsKgwqDCoCBodHRwczovL2J1Z3MuZ2VudG9vLm9yZy9zaG93X2J1Zy5jZ2k_aWQ9NDgxMzYwCgpDb21waWxpbmcgbngtbGlicyBhZ2FpbnN0IGpwZWctOWEgbGVhZHMgdG8gYSBjb21waWxhdGlvbiBlcnJvci4gU3BlY2lmaWNhbGx5OgoKwqDCoMKgIGcrKyAtYyAtTzMgLWZuby1ydHRpIC1mbm8tZXhjZXB0aW9ucyAtSS4uL254LVgxMS9leHBvcnRzL2luY2x1ZGUKwqDCoAEwAQEBAQ--
X-Mailer: YahooMailWebService/0.8.201.700
Message-ID: <1408505056.5466.YahooMailNeo@web125203.mail.ne1.yahoo.com>
Date: Tue, 19 Aug 2014 20:24:16 -0700
From: Gabriel Marcano <gabemarcano@yahoo.com>
Reply-To: Gabriel Marcano <gabemarcano@yahoo.com>
Subject: nx-libs, Jpeg.cpp compilation error with jpeg-9a, with suggested patch
To: "submit@bugs.x2go.org" <submit@bugs.x2go.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="-1476983308-2018442305-1408505117=:5466"

[Message part 1 (text/plain, inline)]

Package: nx-libs
Version: HEAD
Tags: Patch

Found this problem while browsing:
    https://bugs.gentoo.org/show_bug.cgi?id=481360

Compiling nx-libs against jpeg-9a leads to a compilation error. Specifically:

    g++ -c -O3 -fno-rtti -fno-exceptions -I../nx-X11/exports/include
        -Wmissing-declarations -fPIC -DIN_ADDR_T=in_addr_t -DVERSION=\"3.5.0\"
        -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\"
        -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -Wall
        -Wpointer-arith   Jpeg.cpp
    Jpeg.cpp: In function ‘int DecompressJpeg16(unsigned char*, int,
        unsigned int, unsigned int, unsigned char*, int)’:
    Jpeg.cpp:443:29: error: invalid conversion from ‘int’ to ‘boolean’
        [-fpermissive]
    jpeg_read_header(&cinfo, 1);
                                ^
    In file included from Jpeg.cpp:29:0:
    /usr/include/jpeglib.h:1039:13: note: initializing argument 2 of ‘int
        jpeg_read_header(j_decompress_ptr, boolean)’
    EXTERN(int) jpeg_read_header JPP((j_decompress_ptr cinfo,
                ^
    Jpeg.cpp: In function ‘int DecompressJpeg24(unsigned char*, int,
        unsigned int, unsigned int, unsigned char*, int)’:
    Jpeg.cpp:584:29: error: invalid conversion from ‘int’ to ‘boolean’
        [-fpermissive]
    jpeg_read_header(&cinfo, 1);
                                ^
    In file included from Jpeg.cpp:29:0:
    /usr/include/jpeglib.h:1039:13: note: initializing argument 2 of ‘int
        jpeg_read_header(j_decompress_ptr, boolean)’
    EXTERN(int) jpeg_read_header JPP((j_decompress_ptr cinfo,
                ^
    Jpeg.cpp: In function ‘int DecompressJpeg32(unsigned char*, int, unsigned
        int, unsigned int, unsigned char*, int)’:
    Jpeg.cpp:721:29: error: invalid conversion from ‘int’ to ‘boolean’
        [-fpermissive]
    jpeg_read_header(&cinfo, 1);
                                ^
    In file included from Jpeg.cpp:29:0:
    /usr/include/jpeglib.h:1039:13: note: initializing argument 2 of ‘int
        jpeg_read_header(j_decompress_ptr, boolean)’
    EXTERN(int) jpeg_read_header JPP((j_decompress_ptr cinfo,
                ^
    Jpeg.cpp: In function ‘boolean JpegFillInputBuffer(j_decompress_ptr)’:
    Jpeg.cpp:836:10: error: invalid conversion from ‘int’ to ‘boolean’
        [-fpermissive]
    return 1;
            ^
    Makefile:82: recipe for target 'Jpeg.o' failed
    make: *** [Jpeg.o] Error 1

I am attaching a patch to address the problem. Specifically, it appears that
jpeg-9a changed the definition for its "boolean" type from an int to some other
 type (bool in C++, it seems). Using TRUE and FALSE, as provided by the jpeg
library, is what was done to address the problem. After applying the patch
to HEAD (commit 0e3b414ea6ecb6cc359d3b95f5cfeb6096066139), Jpeg.cpp compiles
fine.


Configuration:

Compiling against jpeg-9a.

$ gcc -v
    Using built-in specs.
    COLLECT_GCC=/usr/x86_64-pc-linux-gnu/gcc-bin/4.9.0/gcc
    COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/4.9.0/lto-wrapper
    Target: x86_64-pc-linux-gnu
    Configured with: /var/tmp/portage/sys-devel/gcc-4.9.0/work/gcc-4.9.0/configure
    --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr
    --bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/4.9.0
    --includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/include
    --datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.9.0
    --mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.9.0/man
    --infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.9.0/info
    --with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/include/g++-v4
    --with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/4.9.0/python
    --enable-languages=c,c++,fortran --enable-obsolete --enable-secureplt
    --disable-werror --with-system-zlib --enable-nls --without-included-gettext
    --enable-checking=release --with-bugurl=https://bugs.gentoo.org/
    --with-pkgversion='Gentoo 4.9.0 p1.0, pie-0.6.0' --enable-libstdcxx-time
    --enable-shared --enable-threads=posix --enable-__cxa_atexit
    --enable-clocale=gnu --enable-multilib --with-multilib-list=m32,m64
    --disable-altivec --disable-fixed-point --enable-targets=all
    --disable-libgcj --enable-libgomp --disable-libmudflap --disable-libssp
    --enable-lto --without-cloog
    Thread model: posix
    gcc version 4.9.0 (Gentoo 4.9.0 p1.0, pie-0.6.0) 

$ autoreconf --version
    autoreconf (GNU Autoconf) 2.69


Steps to reproduce:

1. "git clone git://code.x2go.org/nx-libs.git" repository.
2. Change to the "nxcomp" directory.
3. Run "autoreconf" and then do "make Jpeg.o".

Expected outcome:
Successful compilation.

Actual outcome:
Compilation failure, see earlier in the report for the error messages.

[nxlibs-jpeg9a.patch (text/x-patch, attachment)]

Send a report that this bug log contains spam.