X2Go Bug report logs - #528
Version strings like "4.0.2.0+build4" are not rendered properly in NSIS Windows installers

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Michael DePaulo <mikedep333@gmail.com>

Date: Mon, 30 Jun 2014 02:35:01 UTC

Severity: minor

Tags: pending

Found in version 4.0.2.0

Fixed in version 4.0.2.1

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#528: Version strings like "4.0.2.0+build4" are not rendered properly in NSIS Windows installers
Reply-To: Michael DePaulo <mikedep333@gmail.com>, 528@bugs.x2go.org
Resent-From: Michael DePaulo <mikedep333@gmail.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 30 Jun 2014 02:35:01 +0000
Resent-Message-ID: <handler.528.B.140409555820675@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: report 528
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
Received: via spool by submit@bugs.x2go.org id=B.140409555820675
          (code B); Mon, 30 Jun 2014 02:35:01 +0000
Received: (at submit) by bugs.x2go.org; 30 Jun 2014 02:32:38 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham version=3.3.2
Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id F19795DB53
	for <submit@bugs.x2go.org>; Mon, 30 Jun 2014 04:32:37 +0200 (CEST)
Received: by mail-wg0-f48.google.com with SMTP id n12so7429528wgh.31
        for <submit@bugs.x2go.org>; Sun, 29 Jun 2014 19:32:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:date:message-id:subject:from:to:content-type;
        bh=C1rqdMU5B01wvEl9yHFcFCDotVMAyvN8O0nAmJPUjqU=;
        b=EjcbrovEJRsOq/iGllLc0JdqzI1vHLSQ55vxZ8pHkhYg8ohCKRskg6XpJAPkE9zaJ1
         t0Yrlj09tMCTcIOWl8OzPWgk9Hsr6dT7u0OTbvzK47spnCmgO53rTvJHTC+b6oRIZA9i
         7QoVaqr9GsLfqsx1XcxfTZ7KuYw7j6MOPWOeP2SQ1YJM0gSiSqxaC94HYuOlZ4XjqoPM
         hnt6Wx0TEN8/t4PwCt1ylJ65YHIXLQVAmbRvp5WvpZTdbZCWfFT0y4VcZrWHZcAsn1se
         +V94Vg9Iznh6bs1vT7a5FAZgy4ETzIdTxrbm/qut2/8K+YymKa4iAxZEnXNFedKESRrv
         Fb+Q==
MIME-Version: 1.0
X-Received: by 10.180.89.143 with SMTP id bo15mr25537021wib.78.1404095557590;
 Sun, 29 Jun 2014 19:32:37 -0700 (PDT)
Received: by 10.180.98.233 with HTTP; Sun, 29 Jun 2014 19:32:37 -0700 (PDT)
Date: Sun, 29 Jun 2014 22:32:37 -0400
Message-ID: <CAMKht8j4PWmr6V72WFUYRicwgdao9stiHnHvXPwKBmw9yRfU2Q@mail.gmail.com>
From: Michael DePaulo <mikedep333@gmail.com>
To: submit@bugs.x2go.org
Content-Type: text/plain; charset=UTF-8

Package: x2goclient
Version: 4.0.2.0
Severity: minor

Screenshot 2 under this album demonstrates this bug:
http://imgur.com/a/UlNjI

I've already determined an easy fix:
Switch from regular NSIS (2.46) to NSIS Unicode (2.46.5).
See screenshot 4 under that album.

Further justifications for switching to NSIS Unicode:
1. It appears to be better maintained.
2. Lots of major open source projects have switched to it.
3. If there does happen to be a bug, we can revert to regular NSIS
with almost no effort.*

regular NSIS:
http://nsis.sourceforge.net/Main_Page
(Yes 3.0b0 is out, but that is a beta release of 3.0, so I am not
bothering to try it. 3.0 was in alpha until 3.0b0 came out in May 11
2014.)

NSIS Unicode:
http://www.scratchpaper.com/

*If the bug is caught after 4.0.2.1 is released, we would call the
build 4.0.2.1+build2. All that would be required is to change the PATH
under nsis-builder.bat (buildscripts.git) to correct future builds,
edit the version string on x2goclient.nsi, and re-run the .nsi script.
On our X2Go-WinBuilder VM, we keep each release's binaries, ready to
be packaged up by the corresponding .nsi script, under:
D:\Build\windows\ .

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 17:36:18 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.