X2Go Bug report logs - #356
Fwd: [X2Go-User] x2gocleansessions fix

Toggle useless messages

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: submit@bugs.x2go.org

Cc: Gerald Richter - ECOS <richter@ecos.de>

Subject: Fwd: [X2Go-User] x2gocleansessions fix

Date: Sat, 07 Dec 2013 22:15:18 +0000

[Message part 1 (text/plain, inline)]

Package: x2goserver
Severity: important
Version: 4.0.0.7

Hi Gerald,

thanks for this pointer. Let's get this into X2Go Server LTS (aka Baikal).

Mike


----- Weitergeleitete Nachricht von Gerald Richter - ECOS  
<richter@ecos.de> -----
  Datum: Fri, 6 Dec 2013 06:46:43 +0100
    Von: Gerald Richter - ECOS <richter@ecos.de>
Betreff: [X2Go-User] x2gocleansessions fix
     An: "x2go-user@lists.berlios.de" <x2go-user@lists.berlios.de>

Hi,

 
x2gocleansessions sometimes fails for me, because there is a lot of  
extra output in the log like “Proxy: WARNING! Detected drift in system  
timer. Resetting to current time.”. The following patch fixes the  
problem:

 
--- /usr/sbin/x2gocleansessions.orig     2013-12-06 06:37:46.000000000 +0100

+++ /usr/sbin/x2gocleansessions           2013-12-06 06:38:45.000000000 +0100

@@ -56,7 +56,7 @@

                my $sess=shift;

                my $user=shift;

                my $log="/tmp/.x2go-${user}/session-C-${sess}.log";

-              my $text=`tail -1 $log 2>/dev/null`;

+             my $text=`grep Session: $log 2>/dev/null|tail -1`;

                if ($text =~ m/Session suspended/)

                {

                               return 0;

 
Regards

 
Gerald

 
 
 

----- Ende der weitergeleiteten Nachricht -----

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Message #10 received at 356@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: 356-submitter@bugs.x2go.org

Cc: control@bugs.x2go.org, 356@bugs.x2go.org

Subject: X2Go issue (in src:x2goserver) has been marked as pending for release

Date: Sat, 7 Dec 2013 23:20:23 +0100 (CET)

tag #356 pending
fixed #356 4.0.0.8
thanks

Hello,

X2Go issue #356 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=08a2780

The issue will most likely be fixed in src:x2goserver (4.0.0.8).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 08a2780f1448da0fd00e68f11177b1ca1672da04
Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Date:   Sat Dec 7 23:19:24 2013 +0100

    Improve parsing of the NX session.log file where unexpected extra logging takes place during session suspension/resumption. Thanks to Gerald Richter for finding this!!! (Fixes: #356).

diff --git a/debian/changelog b/debian/changelog
index b39bfac..932b33c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,12 @@
 x2goserver (4.0.0.8-0x2go1) UNRELEASED; urgency=low
 
-  * Use mktemp instead of tempfile (because Fedora does not have the tempfile
-    binary). (Fixes: #347).
-  * Replace makepasswd by pwgen (because Fedora does not have makepasswd).
+  * New upstream version (4.0.0.8):
+    - Use mktemp instead of tempfile (because Fedora does not have the tempfile
+      binary). (Fixes: #347).
+    - Replace makepasswd by pwgen (because Fedora does not have makepasswd).
+    - Improve parsing of the NX session.log file where unexpected extra logging
+      takes place during session suspension/resumption. Thanks to Gerald Richter
+      for finding this!!! (Fixes: #356).
 
  -- Mike Gabriel <mike.gabriel@das-netzwerkteam.de>  Thu, 28 Nov 2013 16:14:32 +0100
 

Message #22 received at 356@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: 356-submitter@bugs.x2go.org

Cc: control@bugs.x2go.org, 356@bugs.x2go.org

Subject: X2Go issue (in src:x2goserver) has been marked as closed

Date: Mon, 6 Jan 2014 18:28:53 +0100 (CET)

close #356
thanks

Hello,

we are very hopeful that X2Go issue #356 reported by you
has been resolved in the new release (4.0.0.8) of the
X2Go source project »src:x2goserver«.

You can view the complete changelog entry of src:x2goserver (4.0.0.8)
below, and you can use the following link to view all the code changes
between this and the last release of src:x2goserver.

    http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=6b2da3a6dced741db618d0cd6580bda396758f15;hp=f10d9a7e17da3a7be2c5d169a7aa01d633f7065e

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:x2goserver.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:x2goserver
Version: 4.0.0.8-0x2go1
Status: RELEASE
Date: Fri, 03 Jan 2014 11:30:54 +0100
Fixes: 347 356
Changes: 
 x2goserver (4.0.0.8-0x2go1) RELEASED; urgency=low
 .
   * New upstream version (4.0.0.8):
     - Use mktemp instead of tempfile (because Fedora does not have the tempfile
       binary). (Fixes: #347).
     - Replace makepasswd by pwgen (because Fedora does not have makepasswd).
     - Improve parsing of the NX session.log file where unexpected extra logging
       takes place during session suspension/resumption. Thanks to Gerald Richter
       for finding this!!! (Fixes: #356).
     - Avoid one argument system calls and backticks in x2gocleansessions and
       x2golistsessions_root.
     - Avoid one argument system calls and backticks in x2golistsessions.
     - Avoid one argument system calls and backticks in x2goprint.
     - Avoid backticks in x2goshowblocks, move script to <prefix>/sbin/ as it is
       for being run with root privileges.
     - Sanitize session ID string, port numbers, display numbers and agent PID
       numbers before writing them as strings to the session DB.

Send a report that this bug log contains spam.