X2Go Bug report logs - #349
Make shadow sessions work with --hide option

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#349: [X2Go-Dev] Bug#349: Make shadow sessions work with --hide option
Reply-To: Marco André Dinis <marcoandredinis@gmail.com>, 349@bugs.x2go.org
Resent-From: Marco André Dinis <marcoandredinis@gmail.com>
Resent-To: x2go-dev@lists.berlios.de
Resent-CC: X2Go Developers <x2go-dev@lists.berlios.de>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 09 Dec 2013 11:18:02 +0000
Resent-Message-ID: <handler.349.B349.1386587030341@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 349
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: moreinfo
Received: via spool by 349-submit@bugs.x2go.org id=B349.1386587030341
          (code B ref 349); Mon, 09 Dec 2013 11:18:02 +0000
Received: (at 349) by bugs.x2go.org; 9 Dec 2013 11:03:50 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	HTML_MESSAGE,RCVD_IN_DNSWL_LOW,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham
	version=3.3.2
Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173])
	by ymir (Postfix) with ESMTPS id 7CF1D5DA7B
	for <349@bugs.x2go.org>; Mon,  9 Dec 2013 12:03:49 +0100 (CET)
Received: by mail-we0-f173.google.com with SMTP id u57so3240739wes.18
        for <349@bugs.x2go.org>; Mon, 09 Dec 2013 03:03:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        bh=2W1peW57MhS2OhNuF9ZamA0R0JXWfyRhJlnpIwXZE+Q=;
        b=r9yRHUi3GNJbLZ5Y5AZ+HdJJLgBNibm9ppowCbZl7OZGsZvHV5Q+pSDUAXTAor4Lsc
         pjyrCAQgO7CTyPw/rowK1TBL4bwIdA2nYHYO0QjL1g+mv6aeP8DyU4w4lsMnQKAfRqy3
         lLAm5rSCPIDjlO/bsl95IsM9TSzCGD3bN8CD1QgxbHbo5gcdr94BhJ9WJlxKqbXkPN4N
         e3E0z+5ti1qkiyYkzAGEWXiXgFW6mdACTHu4dJSSiE1nzUFC0qYiA6KbVOmNVzxWysvt
         k6cho57JjIQm3jUoY2c6FMCp89gABtWZNLNpLAwUclzDXdWLINQRKfUu1Ety2D6BKtpo
         CPjg==
X-Received: by 10.180.96.106 with SMTP id dr10mr13340189wib.27.1386587029163;
 Mon, 09 Dec 2013 03:03:49 -0800 (PST)
MIME-Version: 1.0
Received: by 10.216.58.71 with HTTP; Mon, 9 Dec 2013 03:03:34 -0800 (PST)
In-Reply-To: <CAJxG8spv3bF9v3f_F1U3mAZuzmjeuxmNyUrEqPDBaxhspyHEkQ@mail.gmail.com>
References: <14138471.B8Tpv8tqIx@mcdtux> <20131127104626.Horde.w5hvLxXG3VoCZDC6svrcQA2@mail.das-netzwerkteam.de>
 <CAJxG8spv3bF9v3f_F1U3mAZuzmjeuxmNyUrEqPDBaxhspyHEkQ@mail.gmail.com>
From: Marco André Dinis <marcoandredinis@gmail.com>
Date: Mon, 9 Dec 2013 11:03:34 +0000
Message-ID: <CAJxG8soAwOMnj0bVx7VWMuxcH0ZoaDX+7f2-Fim77kADeNe+=g@mail.gmail.com>
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Cc: 349@bugs.x2go.org
Content-Type: multipart/alternative; boundary=f46d0418270252d6b904ed17f304

[Message part 1 (text/plain, inline)]

Any news on implementing this?


On Thu, Nov 28, 2013 at 10:16 AM, Marco André Dinis <
marcoandredinis@gmail.com> wrote:

> Hi
>
> I'm sending the patch.
>
> However this is not the final fix. There are 2 modes: full access and
> only view. Right now it starts full access.
> That decision could be made using the session info. For example,
> create the command SHADOWFULL
>
> On Wed, Nov 27, 2013 at 10:46 AM, Mike Gabriel
> <mike.gabriel@das-netzwerkteam.de> wrote:
> > Control: retitle -1 Make shadow sessions work with --hide option
> > Control: tag -1 moreinfo
> > Control: clone -1 -2
> > Control: reassign -2 x2godesktopsharing
> > Control: retitle -2 Add --no-icon cmdline option to x2godesktopsharing
> > Control: severity -2 wishlist
> >
> > Hi Marco,
> >
> > with this mail I split up your report into to separate bug reports. One
> for
> > x2goclient, one for x2godesktopsharing...
> >
> > On  Di 26 Nov 2013 17:01:41 CET, marcoandredinis wrote:
> >
> >> I'm developing a program that will use X2Go software. I dont want
> >> users to notice they are using any other program besides my own.
> >>
> >> I have two problems right now:
> >>
> >> A) X2GoClient
> >> Using SHADOW mode with "--hide" does not work. The interface waits for
> >> selection of Display (usually ":0") and, since there's no input from
> >> user (there's no window) the program does not show anything.
> >> There are possible ways of fixing/improving this situation:
> >> -allow user to set the default display on sessions' file
> >> -create one flag and run program like these: "x2goclient --hide
> >> --sessionid=xxx --select-first-display"
> >>
> >> Anyway, i modified the code of x2goclient/onmainwindow.cpp and added
> >> these lines:
> >> l4348:..if( shadowSession )
> >> l4349:....slotShadowSess();
> >> Compiled the program, and now i can run "./x2goclient --hide
> >> --sessionid=xxx" and the window will show up.
> >> This is NOT a fix, this is a nasty workaround. It wontn show the list
> >> even when the "hide" flag is not present.
> >
> >
> > Please provide a patch for what you did.
> >
> > Please improve your patch so it is not a workaround anymore. I guess, I
> > agree with you, that the X2Go Client window should pop up, if there are
> more
> > than one sharable desktops to select from. If there is only one sharable
> > desktop, this should be auto-selected. Can you code that into X2Go
> Client,
> > please?
> >
> >> B) X2GoDesktopSharing
> >> Just the icon on SystemTray. If we could pass a flag like "--no-icon"
> >> would be great
> >
> >
> > This part will be handled in a separate bug. I will reply to this once
> the
> > separate bug is created in X2Go BTS.
> >
> >> I could do these simple changes on my own, but i rather see this
> >> changes on the official code.
> >
> >
> > Let's try to get your needs into upstream code...
> >
> > Mike
> >
> > --
> >
> > DAS-NETZWERKTEAM
> > mike gabriel, herweg 7, 24357 fleckeby
> > fon: +49 (1520) 1976 148
> >
> > GnuPG Key ID 0x25771B31
> > mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
> >
> > freeBusy:
> >
> https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
>

[Message part 2 (text/html, inline)]

Send a report that this bug log contains spam.