X2Go Bug report logs - #349
Make shadow sessions work with --hide option

Full log

Message #21 received at 349@bugs.x2go.org (full text, mbox, reply):

Received: (at 349) by bugs.x2go.org; 28 Nov 2013 10:16:51 +0000
From marcoandredinis@gmail.com  Thu Nov 28 11:16:51 2013
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_DNSWL_LOW,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170])
	by ymir (Postfix) with ESMTPS id 1680B5DA6C
	for <349@bugs.x2go.org>; Thu, 28 Nov 2013 11:16:51 +0100 (CET)
Received: by mail-wi0-f170.google.com with SMTP id hq4so716804wib.1
        for <349@bugs.x2go.org>; Thu, 28 Nov 2013 02:16:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        bh=EFwUFTBaO55P2QTO0knce/bkRyw3UZnMROVz8G/4EEo=;
        b=MVNBgndUkYQRpP+LeCiuytheGzpIbwVrbNG7dHXIf7HWTgaYO89i1JgoISyjDkA5ub
         J4BzzW/wn+xlyAeAumh6Y8OBwTYmnTy7OPv94nbdwoKmOZ5DLXvgYKyn9/4RP4cRrLYa
         rZ5i5TOD8bQgGRAhKM6WOjcbHZWK1E5r1CMoMW923qKUxUUeBRTQ9GPBPlHRCgqBtnCe
         LHPcc8poLFfN+jzJDOZY+bQPVtog9uZUA35haQiC/NnJPu5fWVpfBFMPhj/cMl2c53kz
         bV2Y2Hl3mZ/vfhjFdwhUPoIzb2IbuiWX913WX2DVDYdYNDndEjS7RCaidf0y1woDmFfy
         xR7Q==
X-Received: by 10.180.11.169 with SMTP id r9mr1816107wib.26.1385633809217;
 Thu, 28 Nov 2013 02:16:49 -0800 (PST)
MIME-Version: 1.0
Received: by 10.216.77.198 with HTTP; Thu, 28 Nov 2013 02:16:32 -0800 (PST)
In-Reply-To: <20131127104626.Horde.w5hvLxXG3VoCZDC6svrcQA2@mail.das-netzwerkteam.de>
References: <14138471.B8Tpv8tqIx@mcdtux> <20131127104626.Horde.w5hvLxXG3VoCZDC6svrcQA2@mail.das-netzwerkteam.de>
From: Marco André Dinis <marcoandredinis@gmail.com>
Date: Thu, 28 Nov 2013 10:16:32 +0000
Message-ID: <CAJxG8spv3bF9v3f_F1U3mAZuzmjeuxmNyUrEqPDBaxhspyHEkQ@mail.gmail.com>
Subject: Re: [X2Go-Dev] Bug#349: Make shadow sessions work with --hide option
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Cc: 349@bugs.x2go.org
Content-Type: multipart/mixed; boundary=001a11c24de8fcd79904ec3a0265

[Message part 1 (text/plain, inline)]

Hi

I'm sending the patch.

However this is not the final fix. There are 2 modes: full access and
only view. Right now it starts full access.
That decision could be made using the session info. For example,
create the command SHADOWFULL

On Wed, Nov 27, 2013 at 10:46 AM, Mike Gabriel
<mike.gabriel@das-netzwerkteam.de> wrote:
> Control: retitle -1 Make shadow sessions work with --hide option
> Control: tag -1 moreinfo
> Control: clone -1 -2
> Control: reassign -2 x2godesktopsharing
> Control: retitle -2 Add --no-icon cmdline option to x2godesktopsharing
> Control: severity -2 wishlist
>
> Hi Marco,
>
> with this mail I split up your report into to separate bug reports. One for
> x2goclient, one for x2godesktopsharing...
>
> On  Di 26 Nov 2013 17:01:41 CET, marcoandredinis wrote:
>
>> I'm developing a program that will use X2Go software. I dont want
>> users to notice they are using any other program besides my own.
>>
>> I have two problems right now:
>>
>> A) X2GoClient
>> Using SHADOW mode with "--hide" does not work. The interface waits for
>> selection of Display (usually ":0") and, since there's no input from
>> user (there's no window) the program does not show anything.
>> There are possible ways of fixing/improving this situation:
>> -allow user to set the default display on sessions' file
>> -create one flag and run program like these: "x2goclient --hide
>> --sessionid=xxx --select-first-display"
>>
>> Anyway, i modified the code of x2goclient/onmainwindow.cpp and added
>> these lines:
>> l4348:..if( shadowSession )
>> l4349:....slotShadowSess();
>> Compiled the program, and now i can run "./x2goclient --hide
>> --sessionid=xxx" and the window will show up.
>> This is NOT a fix, this is a nasty workaround. It wontn show the list
>> even when the "hide" flag is not present.
>
>
> Please provide a patch for what you did.
>
> Please improve your patch so it is not a workaround anymore. I guess, I
> agree with you, that the X2Go Client window should pop up, if there are more
> than one sharable desktops to select from. If there is only one sharable
> desktop, this should be auto-selected. Can you code that into X2Go Client,
> please?
>
>> B) X2GoDesktopSharing
>> Just the icon on SystemTray. If we could pass a flag like "--no-icon"
>> would be great
>
>
> This part will be handled in a separate bug. I will reply to this once the
> separate bug is created in X2Go BTS.
>
>> I could do these simple changes on my own, but i rather see this
>> changes on the official code.
>
>
> Let's try to get your needs into upstream code...
>
> Mike
>
> --
>
> DAS-NETZWERKTEAM
> mike gabriel, herweg 7, 24357 fleckeby
> fon: +49 (1520) 1976 148
>
> GnuPG Key ID 0x25771B31
> mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
>
> freeBusy:
> https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[autostartSession.patch (text/x-patch, attachment)]

Send a report that this bug log contains spam.