X2Go Bug report logs - #286
keyboard layout isn't applied to the session (when starting)

version graph

Package: x2goserver; Maintainer for x2goserver is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver is src:x2goserver.

Reported by: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>

Date: Mon, 5 Aug 2013 00:18:01 UTC

Severity: normal

Found in version 4.0.1.3

Fixed in version 4.0.1.7

Full log

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 5 Aug 2013 00:15:05 +0000
From mail@maciej.szmigiero.name  Mon Aug  5 02:15:04 2013
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: *
X-Spam-Status: No, score=1.3 required=5.0 tests=RDNS_NONE autolearn=no
	version=3.3.2
X-Greylist: delayed 1752 seconds by postgrey-1.34 at ymir; Mon, 05 Aug 2013 02:15:04 CEST
Received: from vps-vb.mhejs.net (unknown [37.28.154.113])
	by ymir (Postfix) with ESMTPS id 931B05DB35
	for <submit@bugs.x2go.org>; Mon,  5 Aug 2013 02:15:04 +0200 (CEST)
Received: from 89-71-103-214.dynamic.chello.pl ([89.71.103.214] helo=[192.168.1.3])
	by vps-vb.mhejs.net with esmtps (TLSv1:CAMELLIA256-SHA:256)
	(Exim 4.77)
	(envelope-from <mail@maciej.szmigiero.name>)
	id 1V67zj-0008Kh-0B
	for submit@bugs.x2go.org; Mon, 05 Aug 2013 01:45:51 +0200
Message-ID: <51FEE7A9.7060001@maciej.szmigiero.name>
Date: Mon, 05 Aug 2013 01:45:45 +0200
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130217 Thunderbird/17.0.2
MIME-Version: 1.0
To: submit@bugs.x2go.org
Subject: keyboard layout selected in x2go client isn't applied to the session
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Package: x2goserver
Version: 4.0.1.3

It seems that the keyboard layout selected in x2go client isn't applied to the session.

I've tracked the issue to "keyboard" blocking directory being created by x2gostartagent script:
if [ "$X2GO_SET_KBD" == "0" ] || [ "$X2GO_KBD_TYPE" != "auto" ]; then
	$X2GO_LIB_PATH/x2gosyslog "$0" "info" "blocking creation of agent's keyboard file ${SESSION_DIR}/keyboard as requested by session startup command"
	mkdir -p ${SESSION_DIR}/keyboard
fi

X2GO_KBD_TYPE contains the actual keyboard type, so its not "auto" and the blocking directory gets created.
I've changed it to "[ "$X2GO_KBD_TYPE" == "auto" ]" and the keyboard layouts gets applied on session startup.

There is also similar code in x2goresume-session:
# set client-side keyboard model, type, variant, etc.
if [ "$X2GO_SET_KBD" != "0" ] && [ "$X2GO_KBD_TYPE" == "auto" ]; then

Here it should probably be "[ "$X2GO_KBD_TYPE" != "null\/null" ]", as few lines earlier the script
will change X2GO_KBD_TYPE to this value when it is set to "auto" or when X2GO_SET_KBD is zero.

Best regards,
Maciej Szmigiero

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 15:24:54 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.