X2Go Bug report logs - #286
keyboard layout isn't applied to the session (when starting)

Full log

Message #10 received at 285@bugs.x2go.org (full text, mbox, reply):

Received: (at 285) by bugs.x2go.org; 5 Aug 2013 10:16:58 +0000
From mike.gabriel@das-netzwerkteam.de  Mon Aug  5 12:16:58 2013
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=URIBL_BLOCKED autolearn=ham
	version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir (Postfix) with ESMTPS id 0E2245DB1E;
	Mon,  5 Aug 2013 12:16:58 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 9C1ECAF6;
	Mon,  5 Aug 2013 12:16:57 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 29DA83BBA2;
	Mon,  5 Aug 2013 12:16:57 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Zbb+NTPP0DC0; Mon,  5 Aug 2013 12:16:57 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id EDB5F3BEE8;
	Mon,  5 Aug 2013 12:16:56 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id CF3703BBA2;
	Mon,  5 Aug 2013 12:16:56 +0200 (CEST)
Received: by grimnir.das-netzwerkteam.de (Postfix, from userid 33)
	id 5D9663BEE8; Mon,  5 Aug 2013 12:16:56 +0200 (CEST)
Received: from m-047.informatik.uni-kiel.de (m-047.informatik.uni-kiel.de
 [134.245.254.47]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Mon, 05 Aug 2013 12:16:56 +0200
Message-ID: <20130805121656.69992m0bdq7s0mu0@mail.das-netzwerkteam.de>
X-Priority: 3 (Normal)
Date: Mon, 05 Aug 2013 12:16:56 +0200
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: 285@bugs.x2go.org
Cc: 285-submitter@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#285: keyboard layout selected in x2go client
 isn't applied to the session
References: <51FEE7A9.7060001@maciej.szmigiero.name>
In-Reply-To: <51FEE7A9.7060001@maciej.szmigiero.name>
MIME-Version: 1.0
Content-Type: multipart/signed;
 boundary="=_2d18hxicr2xk";
 protocol="application/pgp-signature";
 micalg="pgp-sha1"
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) H3 (4.3.4)

[Message part 1 (text/plain, inline)]

Control: tag -1 confirmed

Hi Maciej,

I have taken a look at this issue this morning and I think in some  
parts you are right, in some parts you are wrong.

On Mo 05 Aug 2013 01:45:45 CEST "Maciej S. Szmigiero" wrote:

> Package: x2goserver
> Version: 4.0.1.3
>
> It seems that the keyboard layout selected in x2go client isn't  
> applied to the session.
>
> I've tracked the issue to "keyboard" blocking directory being  
> created by x2gostartagent script:
> if [ "$X2GO_SET_KBD" == "0" ] || [ "$X2GO_KBD_TYPE" != "auto" ]; then
> 	$X2GO_LIB_PATH/x2gosyslog "$0" "info" "blocking creation of agent's  
> keyboard file ${SESSION_DIR}/keyboard as requested by session  
> startup command"
> 	mkdir -p ${SESSION_DIR}/keyboard
> fi
>
> X2GO_KBD_TYPE contains the actual keyboard type, so its not "auto"  
> and the blocking directory gets created.
> I've changed it to "[ "$X2GO_KBD_TYPE" == "auto" ]" and the keyboard  
> layouts gets applied on session startup.

x2gostartagent: here I do not see an issue. Not that in X2Go Server  
there are three ways to set up your keyboard:

  1) no setup at all (setxkb=false in sessions file)
  2) setup a specific setup (e.g. type=pc105/us, layout=us)
  3) automatic setup (-> type=auto, layout=)

The server-side script ,,x2gosetkeyboard'' is only used for 3).

The keyboard setup for 2) is managed from the client side by issuing  
setxkbmap commands via the open SSH channel.

On x2gostartagent, everything (after testing with PyHoca-GUI and X2Go  
Client) works as expected.

> There is also similar code in x2goresume-session:
> # set client-side keyboard model, type, variant, etc.
> if [ "$X2GO_SET_KBD" != "0" ] && [ "$X2GO_KBD_TYPE" == "auto" ]; then
>
> Here it should probably be "[ "$X2GO_KBD_TYPE" != "null/null" ]", as  
> few lines earlier the script
> will change X2GO_KBD_TYPE to this value when it is set to "auto" or  
> when X2GO_SET_KBD is zero.

For x2goresume-session, however, you dug out a minor issue. This issue  
has been fixed now, see the automatic follow-up mail which will point  
you to the code change in X2Go Git.

Thanks for contributing to X2Go,
Mike


-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.