X2Go Bug report logs - #254
race condition in RPM init script

version graph

Package: x2goserver; Maintainer for x2goserver is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver is src:x2goserver.

Reported by: <O.Smorholm@warwick.ac.uk>

Date: Fri, 28 Jun 2013 19:33:02 UTC

Severity: normal

Tags: moreinfo, rpm-packages

Found in version 4.0.1.1

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to x2go-dev@lists.berlios.de, X2Go Developers <x2go-dev@lists.berlios.de>:
Bug#254; Package x2goserver. (Fri, 28 Jun 2013 19:33:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to <O.Smorholm@warwick.ac.uk>:
New Bug report received and forwarded. Copy sent to X2Go Developers <x2go-dev@lists.berlios.de>. (Fri, 28 Jun 2013 19:33:02 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.x2go.org (full text, mbox):

From: Olav Smørholm <ccsmac@live.warwick.ac.uk>
To: <submit@bugs.x2go.org>
Subject: x2goserver (RPM issue)
Date: Fri, 28 Jun 2013 20:25:43 +0100
Package: x2goserver
Version: 4.0.1.1


There is a race condition in the x2gocleansessions init script, causing 
it to kill itself on a fast machine.
Thus the rpm cannot be cleanly uninstalled without disabling %preun scripts.

# /etc/init.d/x2gocleansessions stop
Terminated
# zypper rm x2goserver
Loading repository data...
Reading installed packages...
Resolving package dependencies...

The following package is going to be REMOVED:
  x2goserver

1 package to remove.
After the operation, 203.0 KiB will be freed.
Continue? [y/n/?] (y): y
Removing x2goserver-4.0.1.1-2.5.csc [error]
Removal of (26663)x2goserver-4.0.1.1-2.5.csc.x86_64(@System) failed:
Error: Subprocess failed. Error: RPM failed: /var/tmp/rpm-tmp.7904: line 
7: /etc/init.d/x2gocleansession: No such file or directory
error: %preun(x2goserver-4.0.1.1-2.5.csc.x86_64) scriptlet failed, exit 
status 127


Abort, retry, ignore? [a/r/i] (a):
Problem occured during or after installation or removal of packages:
Installation aborted by user

Please see the above error message for a hint.
# rpm -e  --nopreun x2goserver
#

The init script "fixed" in this way:
stop()
{
                # kill x2gocleansessions, ignore on failure
                if  ps aux | grep x2gocleans | grep -q perl
                then
                        ps aux | grep x2gocleansessions | grep -v init 
|grep -v grep  |  awk '{print $2}' | xargs  kill -9
                fi
}

But this is not really a fix, as the script will fail if the perl script 
exits before it can be killed.
Would be better if the init script or perl script was renamed and used 
pkill -x instead, but pkill has a problem will long program names.

Anoter issue for SLES, is that perl module File::Path is outdated, and 
is still using the legacy mkpath instead of make_path.
So there needs to be a check for this.
Not sure if this changes with SP3, but it is at least the case for SP2.
This causes x2godbadmin --create to fail:
# x2godbadmin --create
"make_path" is not exported by the File::Path module
Can't continue after import errors at /usr/sbin/x2godbadmin line 25
BEGIN failed--compilation aborted at /usr/sbin/x2godbadmin line 25.

But I really do question the wisdom of having an init script call an 
external perl script to do its job.
Ideally it should all be handled by the init script.

Best Regards,
-- 
Olav Smørholm
Centre for Scientific Computing, University of Warwick


Changed Bug title to 'race condition in RPM init script' from 'x2goserver (RPM issue)' Request was from Mike Gabriel <mike.gabriel@das-netzwerkteam.de> to control@bugs.x2go.org. (Mon, 20 Jan 2014 13:05:01 GMT) Full text and rfc822 format available.

Added tag(s) rpm-packages. Request was from Mike Gabriel <mike.gabriel@das-netzwerkteam.de> to control@bugs.x2go.org. (Mon, 20 Jan 2014 13:05:01 GMT) Full text and rfc822 format available.

Information forwarded to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#254; Package x2goserver. (Thu, 08 Jan 2015 23:25:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Mike Gabriel <mike.gabriel@das-netzwerkteam.de>:
Extra info received and forwarded to list. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>. (Thu, 08 Jan 2015 23:25:02 GMT) Full text and rfc822 format available.

Message #14 received at 254@bugs.x2go.org (full text, mbox):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: 254@bugs.x2go.org
Cc: 254-submitter@bugs.x2go.org
Subject: race condition in (upstream) RPM scripts: still a problem?
Date: Thu, 08 Jan 2015 23:24:06 +0000
[Message part 1 (text/plain, inline)]
Control: tag -1 moreinfo

Hi all,

could people you use the X2Go RPM packages provided via  
packages.x2go.org give feedback if they observe race conditions in the  
RPM scripts as described by #254???

Thanks and much appreciated,
Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
[Message part 2 (application/pgp-signature, inline)]

Added tag(s) moreinfo. Request was from Mike Gabriel <mike.gabriel@das-netzwerkteam.de> to 254-submit@bugs.x2go.org. (Thu, 08 Jan 2015 23:25:02 GMT) Full text and rfc822 format available.

Message sent on to <O.Smorholm@warwick.ac.uk>:
Bug#254. (Thu, 08 Jan 2015 23:25:03 GMT) Full text and rfc822 format available.

Information forwarded to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#254; Package x2goserver. (Mon, 28 Sep 2015 09:00:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Phil Naidoo <phil-naidoo@outlook.com>:
Extra info received and forwarded to list. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>. (Mon, 28 Sep 2015 09:00:03 GMT) Full text and rfc822 format available.

Message #24 received at 254@bugs.x2go.org (full text, mbox):

From: Phil Naidoo <kab@euronet.nl>
To: undisclosed-recipients:;
Subject: Dringend unterstützung gesucht!!!
Date: Mon, 28 Sep 2015 10:48:17 +0200 (CEST)
Phil Naidoo                                                                                     
Johannesburg South Africa
E-Mail: phil-naidoo@outlook.com
                                              Dringend unterstützung gesucht!!!
Hallo, 
mein Name ist Phil Naidoo, Chefredakteur der ABSA Bank of South  Africa. Ich war ein sehr enger Freund von Matthias Berger, Staatsbürger  ihres Landes. Matthias Berger arbeitete mit Diamond Mine firma in Botswana zusammen. Am 19 Dezember 2011 verunglückte Matthias Berger mit seiner Familie bei einem Hubschrauberabsturz.  Alle Insassen des Hubschrauber starben bei dem Unfall. Seit dem haben wir zahlreiche Erkundigungen bei Ihre Botschaft hier in Süd Afrika und Botswana angestellt um Verwandte von Herr Matthias Berger ausfindig zu machen. Leider waren wir bisher erfolglos.
Nach zahlreichen ergebnisslosen Versuchen Herr Matthias Berger Verwandten  ausfindig zu machen, habe ich mich entschieden Ihren Namen /E-mail Addresse übers dasoertliche site ausfindig zu machen, da sie die gleiche Nationalität haben. Ich habe Sie kontaktiert um Ihnen dabei zu assistieren Anspruch auf einen Betrag von 8.2 Millionen US Dollar, hinterlassen von meinem Freund Herr Matthias Berger zu erheben, bevor es von der ABSA Bank of South Africa konfeziert wird . Die ABSA Bank of South Afrika hat mich benachrichtigt das ich einen Verwandten ausfindig machen muss oder das Geld wird innerhalb der nächsten 21 Arbeitstagen konfesziert. In meiner Position als Chefredakteur der ABSA Bank of South Afrika ist es mir Möglich das Geld auf ein gültiges ausländisches Konto zu überweien mit der Sicherung das das Geld komplett sein wird bis ich in Ihr Land komme um das Geld mit Ihnen zu teilen.
Da es mir seit Vier Jahren nicht gelungen ist Verwandschaft von Herr Matthias Berger ausfindig zu machen, versuche ich Ihr Einverständnis zu bekommen Sie als nächste Verwandten des Verstorbenen zu präsentieren da Sie die gleiche Nationalität haben und somit das Geld zu Ihnen überwiesen werden kann. Wenn Sie an meinen Vorschlag interessiert sind, können wir die Teilungsverhältnisse und Uberweisungsmodalitäten besprechen. Ich besitze alle nötigen Informationen und gesetzlichen Dokumente um Ihre Anspruchsforderung zu unterstützen falls Se sich dazu entscheiden.
Ich brauche nur Ihre ehrliche Zustimmung zur Zusammenarbeit um uns diese Transaktion zu ermöglichen. Ich garantiere Ihnen das dies nur unter legalen/ gesetzlichen Vorraussetzungen stattfinden wird.
Bitte kontaktiren Sie mich unter meiner E-mail:phil-naidoo@outlook.com
 	
Mit freundlichen Grüssen
Phil Naidoo


Information forwarded to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#254; Package x2goserver. (Mon, 28 Sep 2015 09:00:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Phil Naidoo <phil-naidoo@outlook.com>:
Extra info received and forwarded to list. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>. (Mon, 28 Sep 2015 09:00:04 GMT) Full text and rfc822 format available.

Message sent on to <O.Smorholm@warwick.ac.uk>:
Bug#254. (Mon, 28 Sep 2015 09:00:11 GMT) Full text and rfc822 format available.

Information forwarded to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#254; Package x2goserver. (Sat, 12 Nov 2016 15:10:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to "FedEx International MailService" <clarence.dickson@mymanmoe.com>:
Extra info received and forwarded to list. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>. (Sat, 12 Nov 2016 15:10:02 GMT) Full text and rfc822 format available.

Message #37 received at 254@bugs.x2go.org (full text, mbox):

From: "FedEx International MailService" <clarence.dickson@mymanmoe.com>
To: 254@bugs.x2go.org
Subject: Problems with item delivery, n.00000636009
Date: Sat, 12 Nov 2016 15:07:21 +0000
[Message part 1 (text/plain, inline)]
Dear Customer,

This is to confirm that one or more of your parcels has been shipped.
You can review complete details of your order in the find attached.

Regards,
Clarence Dickson,
Sr. Delivery Manager.

[FedEx_00000636009.zip (application/zip, attachment)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Wed Dec 12 03:34:16 2018; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.