X2Go Bug report logs - #165
Windows session is not set to maximun area available

[Message part 1 (text/plain, inline)]
Package: x2goclient
Version: 4.0.1.1

If you set the session configuration file to use all available area it
doesn't work.

I attach a patch to repair it.

Regards,

[0001-bug-maximun-screen-available-for-a-session.patch (application/octet-stream, attachment)]
[Message part 1 (text/plain, inline)]
On 2013-04-14 17:44, Ricardo Díaz Martín wrote:
> +//        height=st->setting()->value ( sid+"/height",
> +//                                      ( QVariant ) defaultHeight ).toInt();
> +//        width=st->setting()->value ( sid+"/width",
> +//                                     ( QVariant ) defaultWidth ).toInt();

Hi,

is there any reason to keep this code? If it's not needed, just remove it.

Cheers
Morty

-- 
Dipl.-Ing. Moritz 'Morty' Struebe (Wissenschaftlicher Mitarbeiter)
Lehrstuhl für Informatik 4 (Verteilte Systeme und Betriebssysteme)
Friedrich-Alexander-Universität Erlangen-Nürnberg
Martensstr. 1
91058 Erlangen

Tel   : +49 9131 85-25419
Fax   : +49 9131 85-28732
eMail : struebe@informatik.uni-erlangen.de
WWW   : http://www4.informatik.uni-erlangen.de/~morty




[smime.p7s (application/pkcs7-signature, attachment)]
[Message part 1 (text/plain, inline)]
Upss... Something wrong using git. Sorry

Regards,
Ricardo

2013/4/15 Moritz Struebe <Moritz.Struebe@informatik.uni-erlangen.de>:
> On 2013-04-14 17:44, Ricardo Díaz Martín wrote:
>> +//        height=st->setting()->value ( sid+"/height",
>> +//                                      ( QVariant ) defaultHeight ).toInt();
>> +//        width=st->setting()->value ( sid+"/width",
>> +//                                     ( QVariant ) defaultWidth ).toInt();
>
> Hi,
>
> is there any reason to keep this code? If it's not needed, just remove it.
>
> Cheers
> Morty
>
> --
> Dipl.-Ing. Moritz 'Morty' Struebe (Wissenschaftlicher Mitarbeiter)
> Lehrstuhl für Informatik 4 (Verteilte Systeme und Betriebssysteme)
> Friedrich-Alexander-Universität Erlangen-Nürnberg
> Martensstr. 1
> 91058 Erlangen
>
> Tel   : +49 9131 85-25419
> Fax   : +49 9131 85-28732
> eMail : struebe@informatik.uni-erlangen.de
> WWW   : http://www4.informatik.uni-erlangen.de/~morty
>
>
>

[0002-bug-maximun-screen-available-for-a-session.patch (application/octet-stream, attachment)]
[Message part 1 (text/plain, inline)]
Hi again,

Last patch for this issue. Sorry for the extra work!


2013/4/15 Ricardo Díaz Martín <oceanosoftlapalma@gmail.com>

> Upss... Something wrong using git. Sorry
>
> Regards,
> Ricardo
>
> 2013/4/15 Moritz Struebe <Moritz.Struebe@informatik.uni-erlangen.de>:
> > On 2013-04-14 17:44, Ricardo Díaz Martín wrote:
> >> +//        height=st->setting()->value ( sid+"/height",
> >> +//                                      ( QVariant ) defaultHeight
> ).toInt();
> >> +//        width=st->setting()->value ( sid+"/width",
> >> +//                                     ( QVariant ) defaultWidth
> ).toInt();
> >
> > Hi,
> >
> > is there any reason to keep this code? If it's not needed, just remove
> it.
> >
> > Cheers
> > Morty
> >
> > --
> > Dipl.-Ing. Moritz 'Morty' Struebe (Wissenschaftlicher Mitarbeiter)
> > Lehrstuhl für Informatik 4 (Verteilte Systeme und Betriebssysteme)
> > Friedrich-Alexander-Universität Erlangen-Nürnberg
> > Martensstr. 1
> > 91058 Erlangen
> >
> > Tel   : +49 9131 85-25419
> > Fax   : +49 9131 85-28732
> > eMail : struebe@informatik.uni-erlangen.de
> > WWW   : http://www4.informatik.uni-erlangen.de/~morty
> >
> >
> >
>
> _______________________________________________
> X2Go-Dev mailing list
> X2Go-Dev@lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/x2go-dev
>

[Message part 2 (text/html, inline)]
[0003-bug-maximum-screen-available-for-a-session.patch (application/octet-stream, attachment)]
tag #165 pending
fixed #165 4.0.1.1
thanks

Hello,

X2Go issue #165 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=1830e1f

The issue will most likely be fixed in src:x2goclient (4.0.1.1).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 1830e1f54afad8750cef92cb59c866bbe0356795
Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Date:   Sat May 18 20:59:25 2013 +0200

    Fix detection of maximum screen area available for a session. (Fixes: #165).

diff --git a/debian/changelog b/debian/changelog
index b8ecce2..c203fd1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -12,6 +12,11 @@ x2goclient (4.0.1.1-0~x2go1) UNRELEASED; urgency=low
       Let's consider a given SSH private key that fails to log the user
       in as an overall login failure. (Fixes: #141).
 
+  [ Ricardo Díaz Martín ]
+  * New upstream version (4.0.1.1):
+    - Fix detection of maximum screen area available for a session. (Fixes:
+      #165).
+
   [ Otto Kjell ]
   * New upstream version (4.0.1.1):
     - Enable debug mode through cmd line parameter. (Fixes: #142).


[Message part 1 (text/plain, inline)]

________________________________
Från: Britt-Inger Nilsson
Skickat: den 25 maj 2013 07:17
Till: Britt-Inger Nilsson
Ämne: SV: Brief

My Wife Violet and I are donating 2Million Dollars to you.Contact us via my wife email at (violet-foundation03@hotmail.com<mailto:violet-foundation03@hotmail.com>)

[Message part 2 (text/html, inline)]
close #165
thanks

Hello,

we are very hopeful that X2Go issue #165 reported by you
has been resolved in the new release (4.0.1.1) of the
X2Go source project »src:x2goclient«.

You can view the complete changelog entry of src:x2goclient (4.0.1.1)
below, and you can use the following link to view all the code changes
between this and the last release of src:x2goclient.

    http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=dad4fcc24868504be24ccc9a3ab0fcac41859080;hp=1b4260f86a6fda01c5263fa3d27504677a3cdfac

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:x2goclient.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:x2goclient
Version: 4.0.1.1
Status: RELEASE
Date: Wed, 11 Sep 2013 12:06:02 +0200
Fixes: 141 142 151 164 165 177 179 183 214 222 226 243 255
Changes: 
 x2goclient (4.0.1.1) RELEASED; urgency=low
 .
   [ Nicolai Hansen ]
   * New upstream version (4.0.1.1):
     - Update Danish translation file.
 .
   [ Terje Andersen ]
   * New upstream version (4.0.1.1):
     - Update Norwegian Bokmaal translation file.
 .
   [ Oleksandr Shneyder ]
   * New upstream version (4.0.1.1):
     - Use "127.0.0.1" instead of localhost to avoid wrong IPv6 hostname
       resolution. (Fixes: #151).
     - Wait for x2gocmdexitmessage to return before closing in hidden mode.
     - Support for published applications in X2Go Plugin
     - Support for "shadow" mode in X2Go Plugin
 .
   [ Mike Gabriel ]
   * New upstream version (4.0.1.1):
     - If a priv SSH key has been specified, skip the autologin procedure.
       Let's consider a given SSH private key that fails to log the user
       in as an overall login failure. (Fixes: #141).
     - Avoid multiple selectUserSession requests when in broker
       mode.
     - Properly set the remote server address received via selectUserSession
       method when in broker mode. (Fixes: #226).
     - Fix segmentation fault that started occurring since the custom trayIcon
       patch was applied. Segfault only occurred if the tray icon was not used.
     - Show session name in notification bubbles.
     - Update German translation.
     - Add cmdline option --broker-autologoff: Enforce re-authentication against
       X2Go Session Broker after a session has been suspended or terminated.
       (Fixes: #179).
     - Enable full access desktop sharing across user accounts. (Fixes: #222).
     - Make X2Go Client aware of the MATE desktop environment.
     - Make X2Go Client work in SSH broker mode without the need of a auth-id
       file.
 .
   [ Heinrich Schuchardt ]
   * New upstream version (4.0.1.1):
     - Call ssh_clean_pubkey_hash() for deallocating public key hashes instead of
       just calling free(). Required under MS Windows as documented in libssh2
       API. (Fixes: #243). (For further details see:
       http://api.libssh.org/master/group__libssh__session.html).
   * Provide bin:package with debug symbols for X2Go Client. (Fixes: #255).
 .
   [ Ezra Bühler ]
   * New upstream version (4.0.1.1):
     - Fix auto-resume when session type is »Single Application«. (Fixes: #183).
 .
   [ Ricardo Díaz Martín ]
   * New upstream version (4.0.1.1):
     - Fix detection of maximum screen area available for a session. (Fixes:
       #165).
     - Use the session icon as tray icon, pop up notification bubble that informs
       about current session actions. (Fixes: #177).
     - Allow for setting maximum available desktop size as window size via the
       session profile card. Unfortunately, this feature is for now only
       available on Linux. (Fixes: #214).
 .
   [ Otto Kjell ]
   * New upstream version (4.0.1.1):
     - Enable debug mode through cmd line parameter. (Fixes: #142).
     - Standardize output to stdout+stderr and make it parseable.
 .
   [ Orion Poplawski ]
   * New upstream version (4.0.1.1):
     - Instead of using a hard-code DPI of 96, use local DPI settings for new
       sessions if not explicitly set in session profile (Fixes: #164).
 .
   [ Daniel Lindgren ]
   * New upstream version (4.0.1.1):
     - Update Swedish translation file.
 .
   [ Ricardo Díaz Martín ]
   * New upstream version (4.0.1.1):
     - Update Spanish translation file.



X2Go Bug report logs - #165 Windows session is not set to maximun area available

X2Go Bug report logs - #165
Windows session is not set to maximun area available