X2Go Bug report logs - #1500
Wishlist Bug: look for Branding-/Background-SVGs in well-known locations

Full log

Message #10 received at 1500@bugs.x2go.org (full text, mbox, reply):

Received: (at 1500) by bugs.x2go.org; 15 Oct 2020 10:26:17 +0000
From ulrich.sibiller@gmail.com  Thu Oct 15 12:26:14 2020
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.2
Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 784E35DAFB;
	Thu, 15 Oct 2020 12:26:14 +0200 (CEST)
Received: by mail-yb1-f173.google.com with SMTP id h6so1807134ybi.11;
        Thu, 15 Oct 2020 03:26:14 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=fOFRlpAgD9hutFIxVsXWNSHexvki/dbtbCFHfUPBY4E=;
        b=VmTmF+d3QccmAdcaRLxyL2Qroa8XnleXwTF1Js5m9hs6CRLKufx/vbFFs6bwK6r9V8
         Tb6B1JvKebWHP4pyTMAm7wi1ZrSar+5kVurvfwon9UVHGhqXeMOddMu2P7qjeOI+KNRc
         nQvgLw4ocsT0mEyaSqh93ohjjj+Cy31OXVT1UPn5cBvcf5zq/JqJ+4iq/PZn3W3zk6MN
         ZxTDPax1Lvd8OzCJR0MzjpeVjG0h6uLG2loLmQxcCo1Jxwe0StR6Q7DKfQG5uJ2KN5jA
         +ACw026S8eFzU9bWzZtL7QJRdch9/Sr+qO1wBJhQyw6ZIlWvVUmSMvp7QrIGt1C6FOew
         yNSQ==
X-Gm-Message-State: AOAM531+Q5noDzFvgJGwpF4RUcasxm3oDUiAFoNwXdOJikDSomv86R0d
	JW4TDIbd7gS4Sy6847Jhprd0eIoNQ4HqI22LbHc=
X-Google-Smtp-Source: ABdhPJxIACZBYcSJX8ygwdoL21SMjNVDGkXhI9WQoBA3k+TBtGCHz8mUsGCqncv6R1vQ85V1SNICWTXO176W/1NE3p0=
X-Received: by 2002:a25:1ed7:: with SMTP id e206mr4313999ybe.505.1602757543071;
 Thu, 15 Oct 2020 03:25:43 -0700 (PDT)
MIME-Version: 1.0
References: <79f56027-637e-9fb2-a87b-aaf044f7edc7@baur-itcs.de>
In-Reply-To: <79f56027-637e-9fb2-a87b-aaf044f7edc7@baur-itcs.de>
From: Ulrich Sibiller <uli42@gmx.de>
Date: Thu, 15 Oct 2020 12:25:16 +0200
Message-ID: <CANVnVY+_SoLSaqzsuXUjRdA1kjGuTT2FyUCpJ0GpS+n0S71OJQ@mail.gmail.com>
Subject: Re: [X2Go-Dev] Bug#1500: Wishlist Bug: look for Branding-/Background-SVGs
 in well-known locations
To: Stefan Baur <X2Go-ML-1@baur-itcs.de>, 1500@bugs.x2go.org
Cc: submit@bugs.x2go.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Better approach: The default logos will come in a dedicated directory.
In addition there's a defined path .../x2go-branding which is neither
delivered nor created by the x2goclient package. IFF the directory
exists and contains the required files these are taken instead of the
default ones. You can then pack a x2go-branding-mycompany package and
install that completely independently from the x2go installation.
There's a restriction that only one such package may be installed.

Drawback: you cannot use two differently branded x2goclients in
parallel, but can you run x2goclient twice at all?

Uli

On Thu, Oct 15, 2020 at 11:56 AM Stefan Baur <X2Go-ML-1@baur-itcs.de> wrote:
>
> package: x2goclient
> priority: wishlist
>
> At the moment, X2GoClient has two SVGs "baked in", namely the ones for
> the background image and the branding in the lower left corner.  These
> can be overridden with command line parameters.
>
> I would suggest a folder /usr/share/x2goclient/logos on Linux/macOS, and
> <programsdir>\x2goclient\logos on Windows, where these SVGs are placed
> instead. On Linux, /etc/x2goclient/logos should be a symlink to
> /usr/share/x2goclient/logos.
>
> On Client startup, it would then scan /etc/x2goclient/logos (or
> <programsdir>\x2goclient\logos) for these files, and use them.
>
> That way, swapping out these logos does not require adding --background
> or --branding to the call - on Windows, you would simply overwrite them
> with the logos of your choice, on Linux/macOS, you would replace the
> symlink with an actual directory and place your custom logos there -
> just like we do it for /etc/x2go/applications on the server.
>
> The command line parameters should remain in the code to support legacy
> installations.
>
> It MAY make sense to keep a minimum set of logos "baked in" (maybe a
> black on white "ERROR" text) to indicate when the file-based ones could
> not be found.
>
> Kind Regards,
> Stefan Baur
>
> --
> BAUR-ITCS UG (haftungsbeschränkt)
> Geschäftsführer: Stefan Baur
> Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364
> Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243
> _______________________________________________
> x2go-dev mailing list
> x2go-dev@lists.x2go.org
> https://lists.x2go.org/listinfo/x2go-dev

Send a report that this bug log contains spam.