X2Go Bug report logs - #1477
x2goclient doesn't prompt for password after authentication failure if server is using google-authenticator

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Toby <anothercoffee@googlemail.com>

Date: Mon, 8 Jun 2020 17:00:03 UTC

Severity: normal

Found in version 4.1.2.2

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1477: [X2Go-Dev] Bug#1477: Debug output
Reply-To: uli42@gmx.de, 1477@bugs.x2go.org
Resent-From: Ulrich Sibiller <ulrich.sibiller@gmail.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Thu, 18 Jun 2020 11:40:01 +0000
Resent-Message-ID: <handler.1477.B1477.159248039816507@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1477
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
References: <CAEScUDi0z1tWFkcD_znURLO0pgmf5XfsT6yTY6DQMzLgGBWtwA@mail.gmail.com> <CAEScUDhCg3j4W_5v0w=B5AbrwQ34Yoj3qBdtDpY+=iukTkS4-A@mail.gmail.com> <CAEScUDgE8TV-DxYTMhUd3Q3BufEDaGGb8MJHopLjx44wju2rvw@mail.gmail.com> <CAEScUDi6Re2Sk+YRDOWAgfW_HAOkug7AY9h1kCM+CeLOTKxe4Q@mail.gmail.com> <CAEScUDhCg3j4W_5v0w=B5AbrwQ34Yoj3qBdtDpY+=iukTkS4-A@mail.gmail.com>
Received: via spool by 1477-submit@bugs.x2go.org id=B1477.159248039816507
          (code B ref 1477); Thu, 18 Jun 2020 11:40:01 +0000
Received: (at 1477) by bugs.x2go.org; 18 Jun 2020 11:39:58 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.7 required=3.0 tests=BAYES_05,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,FREEMAIL_REPLYTO,
	FREEMAIL_REPLYTO_END_DIGIT,SPF_HELO_NONE,URIBL_BLOCKED autolearn=no
	autolearn_force=no version=3.4.2
Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 116DA5DAE9
	for <1477@bugs.x2go.org>; Thu, 18 Jun 2020 13:39:57 +0200 (CEST)
Received: by mail-yb1-xb29.google.com with SMTP id s1so2953921ybo.7
        for <1477@bugs.x2go.org>; Thu, 18 Jun 2020 04:39:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:reply-to:from:date:message-id
         :subject:to;
        bh=gjo5VJjxZaH3xEaivYsM5/peS/ILFVvWSNLVfIGCLsk=;
        b=SCaAEgwVSxNv8ZmXvgle/GD4aOCif6fBbAcA4RCAj9pyM+Qzl8gC0ij+c+h7CGPpl9
         d0Qu6ZwVeVs+geP6fUKbm8Z/4Zn2dL9PqabQML4V+0vES8gqUQqm0qgQb0rvsvurs0/3
         dK4WnJyTxZ7zB3TxZM2WUHszGwuF1/NluFVy9qb+sfiGDNrYaI/MUUDVk3maVd8zTTnS
         FKe8hqPQfM9jC6cA8P2awbOZZZqOsSbSsg6jr530e0OVHLX61ws5ebv2yjTjENETA/UZ
         S4ocZXZJPlc2CAGZ7YptLpktqScjU/lYsi/n99JKgO+3bfVYhuTSc8WieL1wSgpsgR0u
         TLCg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:reply-to
         :from:date:message-id:subject:to;
        bh=gjo5VJjxZaH3xEaivYsM5/peS/ILFVvWSNLVfIGCLsk=;
        b=p65BRKlaiofBKPOudlcDb//FQzk64f0g2K4eQ7TYZkh0YO9YeG8k/R1eY2qw9tSdBp
         b/AO4Fjme0KjsYey9wIYPcULWenf/ltyxVcX+qoxsXmzwqw2cWbn0a9m1USBsicvRmjT
         +UGFxEoOOSOEwi38C2EDdTo+q27xE7RRDPHfh5qgfngeTd+3NW5r3SzGHUK0dIVvnouW
         tuxpaJ7oo638fA0FuqPcn9yXGvN2njaUl4aX+6LSvWehIG4qS8LbY5aGkZjfk4tWVyF8
         UUfeBGZznG85+fibeLdyAzIXXNwmdrI4zshDYseFORk8jfbJUTXiA6dYB3+0hwRbxNuM
         2pSw==
X-Gm-Message-State: AOAM531TeANabbFidnL0Rdyvy1EBlSMiLX2L5S15nYOgagF75kj0cfw4
	h1VHF2dt1MnHPiLcTxSWkaUqT9h9dhd5UPBBVvQ=
X-Google-Smtp-Source: ABdhPJztuJQoJjkZ8OO3xpLVjY4EGiZSd/ZiPCQ7AItrsafbiP2fGCbodwQXp5iWcKGSN5KDDfOx73mitAL0F62eiNU=
X-Received: by 2002:a25:7ac5:: with SMTP id v188mr5989770ybc.237.1592480395650;
 Thu, 18 Jun 2020 04:39:55 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAEScUDi6Re2Sk+YRDOWAgfW_HAOkug7AY9h1kCM+CeLOTKxe4Q@mail.gmail.com>
From: Ulrich Sibiller <ulrich.sibiller@gmail.com>
Date: Thu, 18 Jun 2020 13:39:29 +0200
Message-ID: <CANVnVYLteCPv-j06cn-tgcT=NYtpFiRbUeYdeT-0_iLeoqZKcA@mail.gmail.com>
To: Toby <anothercoffee@googlemail.com>, 1477@bugs.x2go.org
Content-Type: text/plain; charset="UTF-8"

Thanks for the patch. I have forwarded this to the x2go-dev list. I
hope it will be integrated soon.

Uli

On Thu, Jun 18, 2020 at 11:52 AM Toby <anothercoffee@googlemail.com> wrote:
>
> I appreciate the whole ssh connection process is hairy as ****, and
> thinking I've got a proper fix after a couple of hours poking about
> looking at a single use case is naive, but the removal of one line
> gets the behaviour I expect: if either the password or verification
> code are incorrect, restart the authentication process
>
> diff --git a/src/sshmasterconnection.cpp b/src/sshmasterconnection.cpp
> index 667e0ef..34045de 100644
> --- a/src/sshmasterconnection.cpp
> +++ b/src/sshmasterconnection.cpp
> @@ -1127,7 +1127,7 @@ bool SshMasterConnection::userChallengeAuth()
>              if (has_challenge_auth_code_prompt) {
>                  x2goDebug<<"Verification code request"<<endl;
>
> -                challengeAuthPasswordAccepted=true;
> +                // challengeAuthPasswordAccepted=true;
>                  if(challengeAuthVerificationCode == QString::null)
>                  {
>                      keyPhraseReady=false;
>
>
> This also works in the case of using an ssh proxy server with
> google-authenticator.
>
> Cheers
> Toby
> _______________________________________________
> x2go-dev mailing list
> x2go-dev@lists.x2go.org
> https://lists.x2go.org/listinfo/x2go-dev

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Wed Apr 24 23:52:31 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.