X2Go Bug report logs - #1477
x2goclient doesn't prompt for password after authentication failure if server is using google-authenticator

Full log

Message #15 received at 1477@bugs.x2go.org (full text, mbox, reply):

Received: (at 1477) by bugs.x2go.org; 11 Jun 2020 12:15:10 +0000
From anothercoffee@googlemail.com  Thu Jun 11 14:15:07 2020
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE,URIBL_BLOCKED
	autolearn=ham autolearn_force=no version=3.4.2
Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 2FFC95DD8A
	for <1477@bugs.x2go.org>; Thu, 11 Jun 2020 14:15:07 +0200 (CEST)
Received: by mail-io1-xd29.google.com with SMTP id u13so5981825iol.10
        for <1477@bugs.x2go.org>; Thu, 11 Jun 2020 05:15:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=googlemail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
        bh=ipEEH3VIHh5ywfwftRcIrkVxNvdXyGAd09d+hHkp11o=;
        b=eZ/YEb3eBjCh/wIR831MJQ6lyXnyAg74kUNH5Nw1UuUG4A/qte+/6EwwgAPA3WiEGG
         PmemNlhun4Zf771JEsdjkDXFtkpCuLUSdYSGVpd0aTTvaPGXfewl2xEYxjN/KVDtRwpS
         4efwRtlCcOLShxvu1dQebphgVxN4n9dmpKTcVZK0oEkow4sN5HfiGrWa/hP7SZN3eY+s
         pp7IOOvV8Dz8f/4WXtsjfi5ZfarP5JKm0stlUH3NoCsv5SV95xw9myVd9JmcBh7tnoOD
         6kCKLw2jH4pcqrIyvV7ugY73S8lV/pzAGf2oafbLSmI7k5U5+qAY0zDFIND4SFPd8Cto
         HXEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to;
        bh=ipEEH3VIHh5ywfwftRcIrkVxNvdXyGAd09d+hHkp11o=;
        b=ieF2wMGnqKgeOr+YpegIJ8R1TvOB6YhK0I/8dsEB2p5Y+yNMSSvI5lUVmkm3t0ltbK
         XlLG0vbcscBtsI39Hn7Y5oDGI74aCf+1WJR98FX59s9GBkEqIJpRY3F46Tul4B3kHMj8
         bHqvIzGKwi+lLitHDzHCdoflwWT9xzPUm97KWjuI6liQKzVJp6GTS6ZFkM/W+x/abNfp
         eoUmNHB7fyVP8WaJ/Bt1HMF76/Zi4fum+0vfkQHawCnIUtrbBifUSRwF8+A4U5BWdxm9
         X5+oTGn4bj6paCfk1cc2xFUR7Gw442wX/aIb77Qk5bJUNgCv3Si2eOvR1ZzG/FrJhpKk
         JUZg==
X-Gm-Message-State: AOAM530dgRKGmWUiQQRyUb6nOgDalkN6kvh1gm71zm0BASNnLes31lok
	GICEDIwQlm4o+iUFnwbDcgQTNq3siroL16T3JWI2p1UV
X-Google-Smtp-Source: ABdhPJxjP10/hUMQLylo+j46la2j03KlUpM2CvsitN1KU8jtpRQbv587xtzSDq3P+hXQLKmwDKH2Mi2vZGU21cXJvMo=
X-Received: by 2002:a6b:9355:: with SMTP id v82mr7686151iod.92.1591877705560;
 Thu, 11 Jun 2020 05:15:05 -0700 (PDT)
MIME-Version: 1.0
References: <CAEScUDi0z1tWFkcD_znURLO0pgmf5XfsT6yTY6DQMzLgGBWtwA@mail.gmail.com>
In-Reply-To: <CAEScUDi0z1tWFkcD_znURLO0pgmf5XfsT6yTY6DQMzLgGBWtwA@mail.gmail.com>
From: Toby <anothercoffee@googlemail.com>
Date: Thu, 11 Jun 2020 13:14:39 +0100
Message-ID: <CAEScUDgE8TV-DxYTMhUd3Q3BufEDaGGb8MJHopLjx44wju2rvw@mail.gmail.com>
Subject: Re: Debug output
To: 1477@bugs.x2go.org
Content-Type: text/plain; charset="UTF-8"

In fact further testing shows the same behaviour if you get either
your password or verification code wrong first time - a "Verification
code" loop that you can't get out of even if the password was correct
and the first verification code wasn't.

On Thu, Jun 11, 2020 at 11:32 AM Toby <anothercoffee@googlemail.com> wrote:
>
> Hi
>
> I've now got some debug output (from an ubuntu VM, --debug doesn't
> work for me on fedora).
> With the correct password and validation code:
>
> x2go-DEBUG-../src/sshmasterconnection.cpp:1207> Challenge
> authentication requested.
> x2go-DEBUG-../src/sshmasterconnection.cpp:1085> Have prompts: 1
> x2go-DEBUG-../src/sshmasterconnection.cpp:1089> Prompt[0]: |Password: |
> x2go-DEBUG-../src/sshmasterconnection.cpp:1093> Password request
> x2go-DEBUG-../src/sshmasterconnection.cpp:1085> Have prompts: 1
> x2go-DEBUG-../src/sshmasterconnection.cpp:1089> Prompt[0]: |Verification code: |
> x2go-DEBUG-../src/sshmasterconnection.cpp:1109> Checking against known
> prompt #0: "Verification code:"
> x2go-DEBUG-../src/sshmasterconnection.cpp:1129> Verification code request
> x2go-DEBUG-../src/sshmasterconnection.cpp:1085> Have prompts: 0
> x2go-DEBUG-../src/sshmasterconnection.cpp:1171> Challenge authentication OK.
> x2go-DEBUG-../src/sshmasterconnection.cpp:687> User authentication OK.
> x2go-DEBUG-../src/sshmasterconnection.cpp:1708> LOGIN CHECK:"LOGIN OK\r\n"
> x2go-DEBUG-../src/sshmasterconnection.cpp:1711> don't have interaction
> x2go-DEBUG-../src/sshmasterconnection.cpp:1744> LOOP FINISHED
> x2go-DEBUG-../src/sshmasterconnection.cpp:1748> No interaction needed,
> continue session
> x2go-DEBUG-../src/sshmasterconnection.cpp:702> Login Check - OK
> x2go-DEBUG-../src/onmainwindow.cpp:2947> SSH connection established.
>
> But with an incorrect password, I only get repeated Verification code prompts:
>
> x2go-DEBUG-../src/sshmasterconnection.cpp:1207> Challenge
> authentication requested.
> x2go-DEBUG-../src/sshmasterconnection.cpp:1085> Have prompts: 1
> x2go-DEBUG-../src/sshmasterconnection.cpp:1089> Prompt[0]: |Password: |
> x2go-DEBUG-../src/sshmasterconnection.cpp:1093> Password request
> x2go-DEBUG-../src/sshmasterconnection.cpp:1085> Have prompts: 1
> x2go-DEBUG-../src/sshmasterconnection.cpp:1089> Prompt[0]: |Verification code: |
> x2go-DEBUG-../src/sshmasterconnection.cpp:1109> Checking against known
> prompt #0: "Verification code:"
> x2go-DEBUG-../src/sshmasterconnection.cpp:1129> Verification code request
> x2go-DEBUG-../src/sshmasterconnection.cpp:1085> Have prompts: 1
> x2go-DEBUG-../src/sshmasterconnection.cpp:1089> Prompt[0]: |Password: |
> x2go-DEBUG-../src/sshmasterconnection.cpp:1093> Password request
> x2go-DEBUG-../src/sshmasterconnection.cpp:1085> Have prompts: 1
> x2go-DEBUG-../src/sshmasterconnection.cpp:1089> Prompt[0]: |Verification code: |
> x2go-DEBUG-../src/sshmasterconnection.cpp:1109> Checking against known
> prompt #0: "Verification code:"
> x2go-DEBUG-../src/sshmasterconnection.cpp:1129> Verification code request
> x2go-DEBUG-../src/sshmasterconnection.cpp:1085> Have prompts: 1
> x2go-DEBUG-../src/sshmasterconnection.cpp:1089> Prompt[0]: |Password: |
> x2go-DEBUG-../src/sshmasterconnection.cpp:1093> Password request
> x2go-DEBUG-../src/sshmasterconnection.cpp:1085> Have prompts: 1
> x2go-DEBUG-../src/sshmasterconnection.cpp:1089> Prompt[0]: |Verification code: |
> x2go-DEBUG-../src/sshmasterconnection.cpp:1109> Checking against known
> prompt #0: "Verification code:"
> x2go-DEBUG-../src/sshmasterconnection.cpp:1129> Verification code request
> x2go-DEBUG-../src/sshmasterconnection.cpp:1085> Have prompts: 1
> x2go-DEBUG-../src/sshmasterconnection.cpp:1089> Prompt[0]: |Password: |
> x2go-DEBUG-../src/sshmasterconnection.cpp:1093> Password request

Send a report that this bug log contains spam.