X2Go Bug report logs - #1434
Use login shell for session

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1434: X2Go issue (in src:x2goserver) has been marked as pending for release
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 1434-quiet@bugs.x2go.org
Resent-To: Orion Poplawski <orion@nwra.com>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 16 May 2022 20:00:02 +0000
Resent-Message-ID: <handler.1434.U1434.165273102622466@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: report 1434
X-X2Go-PR-Package: x2goserver
X-X2Go-PR-Keywords: pending patch
References: <939f0e9e-602a-0a1b-b8ae-ff992e3a795d@nwra.com>
Received: via spool by 1434-submitter@bugs.x2go.org id=U1434.165273102622466
          (code U ref 1434); Mon, 16 May 2022 20:00:02 +0000
Received: (at 1434-submitter) by bugs.x2go.org; 16 May 2022 19:57:06 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,NO_RELAYS,
	T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
	version=3.4.2
Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005)
	id 09D1C5DAF0; Mon, 16 May 2022 21:57:03 +0200 (CEST)
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: 1434-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org, 1434@bugs.x2go.org
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Mailer: https://code.x2go.org/gitweb?p=maintenancescripts.git;a=blob;f=git/hooks/x2go-post-receive-tag-pending
Message-Id: <20220516195704.09D1C5DAF0@ymir.das-netzwerkteam.de>
Date: Mon, 16 May 2022 21:57:03 +0200 (CEST)

tag #1434 pending
fixed #1434 4.1.0.4
thanks

Hi!

X2Go issue #1434 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    https://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=2cabb88c3f785d93060d41e3f86eadc508aab553

The issue will most likely be fixed in src:x2goserver (4.1.0.4).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 2cabb88c3f785d93060d41e3f86eadc508aab553
Author: Orion Poplawski <orion@nwra.com>
Date:   Mon May 16 21:55:23 2022 +0200

    x2goserver-xsession/etc/Xsession: Detect $SHELL from getent passwd and use it to launch the session (on RHEL, SUSE, Gentoo and alike). (Fixes: #1434).
    
     X2Go's Xsession file always starts the user's session with /bin/bash (at
     least on RedHat systems where SHELL is set to /bin/bash via ~/.bashrc
     calling /etc/bashrc).  This patch attempts to determine the user's login
     shell and use that for launching the session.  See also:
     .
     https://bugzilla.redhat.com/show_bug.cgi?id=1794660
     .
     Another option might be the judicious use of the --norc option when
     launching x2goruncommand on followers but I'm not sure what other
     effects this will have or where to do that.  Effects might not be to bad
     because I can simulate this by moving away the user's .bash_profile and
     .bashrc files and then the tcsh is used as expected in this case.
     However, while $SHELL does not get set in this case, the xfce4-session
     script still gets launched with bash which triggers some other errors,
     so this patch may be the best option.

diff --git a/debian/changelog b/debian/changelog
index a9cc40af..9aa24304 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -472,6 +472,12 @@ x2goserver (4.1.0.4-0x2go1.2) UNRELEASED; urgency=medium
     - Support for rootless X2GoKdrive sessions.
     - Setting keyboard layout in rootless X2GoKdrive sessions.
 
+  [ Orion Paplowski ]
+  * New upstream version (4.1.0.4):
+    - x2goserver-xsession/etc/Xsession: Detect $SHELL from getent passwd
+      and use it to launch the session (on RHEL, SUSE, Gentoo and alike).
+      (Fixes: #1434).
+
   [ Tom Ruzicka ]
   * debian/po: Add Czech debconf translation.
 

Send a report that this bug log contains spam.