X2Go Bug report logs - #142
x2goclient output on stdout

Full log

🔗 View this message in rfc822 format

X-Loop: git-admin@x2go.org
Subject: Bug#142: x2goclient output on stdout
Reply-To: Kjell Otto <otto.kjell@gmail.com>, 142@bugs.x2go.org
Resent-From: Kjell Otto <otto.kjell@gmail.com>
Resent-To: x2go-dev@lists.berlios.de
Resent-CC: X2Go Developers <x2go-dev@lists.berlios.de>
X-Loop: git-admin@x2go.org
Resent-Date: Mon, 11 Mar 2013 21:33:01 +0000
Resent-Message-ID: <handler.142.B142.136303672227739@bugs.x2go.org>
Resent-Sender: git-admin@x2go.org
X-X2Go-PR-Message: followup 142
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
Received: via spool by 142-submit@bugs.x2go.org id=B142.136303672227739
          (code B ref 142); Mon, 11 Mar 2013 21:33:01 +0000
Received: (at 142) by bugs.x2go.org; 11 Mar 2013 21:18:42 +0000
Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54])
	by ymir (Postfix) with ESMTPS id EDB2B5DB17;
	Mon, 11 Mar 2013 22:18:41 +0100 (CET)
Received: by mail-vb0-f54.google.com with SMTP id l1so1917391vba.27
        for <multiple recipients>; Mon, 11 Mar 2013 14:18:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:x-received:in-reply-to:references:date:message-id
         :subject:from:to:cc:content-type;
        bh=XT0kLTacgAuPLXnxOxgOe+AvpHzkuwOJPFTiiqOY67w=;
        b=tdYE24m77HYzblqf/rloGJGaskYlVm+EyFpdj3w3UGNBA2yXOiltZ+D2qyCSnbD/Vx
         x3lnjqG8GGJXF9oA+/mLzFEc5UA9oJMr3NIdprq7d0lTGbIt+sNyfJgATwMDJc8OiW6Z
         4ovZKr0/jy5TZmpDsLTV9Tmjt0cqaVjYoiuFmZu6DPhl6+c1tAu9el97oglArxoMj1do
         xIuYiBdFBij2dV3gVtfOOjL94j6atAGx2eaWwJoEo/SnVWm0T1vOGRJqnzdOdHpY7bqc
         ydz9fjHYqy/JSTrGDY8WSmT2ee2YI+zBpAawZfXst6vXYgiiskWHYQDBCGkvyRe70sjV
         U0fw==
MIME-Version: 1.0
X-Received: by 10.220.248.74 with SMTP id mf10mr1456681vcb.0.1363036720368;
 Mon, 11 Mar 2013 14:18:40 -0700 (PDT)
Received: by 10.58.24.37 with HTTP; Mon, 11 Mar 2013 14:18:40 -0700 (PDT)
In-Reply-To: <CAHeJaPLjydPxyR4qpjYMNq-pxfeX=ezhDFY4UWgRend-yWeniQ@mail.gmail.com>
References: <CAHeJaPKG2ndmoMFEn3kH91uMzTg3gQAhi-A26Le=Y5cfsHBq-g@mail.gmail.com>
	<20130307160849.9282370a79p2omf5@mail.das-netzwerkteam.de>
	<CAHeJaPLjydPxyR4qpjYMNq-pxfeX=ezhDFY4UWgRend-yWeniQ@mail.gmail.com>
Date: Mon, 11 Mar 2013 22:18:40 +0100
Message-ID: <CAHeJaPKtwCp6J3gWxs3iKNmmfMxMk3NViQiU+7vHyRiYaRC2ig@mail.gmail.com>
From: Kjell Otto <otto.kjell@gmail.com>
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Cc: 142@bugs.x2go.org, control@bugs.x2go.org
Content-Type: multipart/mixed; boundary=bcaec54a37bc889baa04d7acb75e

[Message part 1 (text/plain, inline)]

Hi Mike,

unfortunatly, I seem to have missed a bug that was introduced by this
patch regarding windows builds.
Since I was testing and releasing everything under linux and mac, I
missed it in the first patch. I'm really
sorry for this. Please find the corrected patch attached.

The issue was caused by, patch applied, line 9055 which was then
trying to access undefined variables.
I seem to have falsely uncommented the line while correcting the other
printouts:

@@ -8833,7 +9051,9 @@ void ONMainWindow::startWinServers()
         startPulsed();
     }
 // #ifdef CFGCLIENT
-//     x2goDebug<<"xorg settings: "<<startXorgOnStart <<" "<< useXming<<endl;
+
+    //x2goDebug<<"Xorg settings: "<< startXorgOnStart <<" useXming:
"<< useXming;
+
     if ( useInternalX && (internalX== XMING))
     {
 // #endif

Before, the patch was uncommenting the line above, which was wrong.

I was now able to build the client under windows and linux, and mac :)

Greetings,
Kjellski


2013/3/11 Kjell Otto <otto.kjell@gmail.com>:
> Hi Mike,
>
> here is my patch boiled down to one commit. You can look at it before
> you apply it here:
> https://github.com/kjellski/x2goclient/compare/master...debug-cleanup
>
> Greetings,
> Kjellski
>
> 2013/3/7 Mike Gabriel <mike.gabriel@das-netzwerkteam.de>:
>> Hi Otto,
>>
>> On Do 07 Mär 2013 13:51:25 CET Kjell Otto wrote:
>>
>>> Package: x2goclient
>>>
>>>
>>> The x2goclient has extreme output on stdout while running. It's more
>>> noise then signal and therefor, I've wrapped all the printouts with
>>> #ifdef DEBUG and a #undef DEBUG on the onmainwindow.cpp file.
>>>
>>> Then I've added in printout statements that are parsable with numbered
>>> output and category so that a normal run of the x2goclient would
>>> output like this:
>>>
>>> $ ./client_build/x2goclient --session=x2goserver_RZ --add-to-known-hosts
>>> --hide
>>> x2go-INFO-001> Starting x2goclient...
>>> x2go-WARN-001> Can't load translator: :/x2goclient_en_us
>>> x2go-WARN-002> Can't load translator: :/qt_en_US
>>> x2go-INFO-004> Started  x2goclient.
>>> x2go-INFO-005> $HOME=/home/kjellski
>>> x2go-INFO-029> Starting connection to server: 10.3.0.20:22
>>> x2go-INFO-031> SSH connection established.
>>> x2go-INFO-011> Closing x2goclient...
>>> x2go-INFO-018> Waiting for the SSH connection to finish...
>>> x2go-INFO-019> Waited  for the SSH connection to finish.
>>> x2go-INFO-028> Closed  x2goclient.
>>> $
>>>
>>> No GUI will be shown and no try Icons appear. This reflects a bit more
>>> the --hide param and can be used to make a shortcut to the client that
>>> will just open the window.
>>>
>>> Also I've added a log method and provided a script that lets you show
>>> all outputs on the file.
>>>
>>> All changes can be found on this repository in the branch stdout-cleanup:
>>>
>>> https://github.com/kjellski/x2goclient/tree/stdout-cleanup
>>>
>>> If any additional help from my side is required, please contact me and
>>> I try to support the process.
>>
>>
>> yes, help is required.
>>
>> 1. Create fresh (tmp) branch
>> 2. pull over your patches you wish applied in x2goclient.git
>> 3. rebase, boil all single commits down to one commit
>> 4. send the URL to the exact patch/diff for review
>>
>> Mike
>>
>>
>>
>> --
>>
>> DAS-NETZWERKTEAM
>> mike gabriel, rothenstein 5, 24214 neudorf-bornstein
>> fon: +49 (1520) 1976 148
>>
>> GnuPG Key ID 0x25771B31
>> mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
>>
>> freeBusy:
>> https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[0001-Added-the-debug-parameter-to-x2goclient.patch (application/octet-stream, attachment)]

Send a report that this bug log contains spam.