X2Go Bug report logs - #1418
Attempting to input an IPv6 address as an SSH proxy fails

Full log

Message #19 received at control@bugs.x2go.org (full text, mbox, reply):

Received: (at control) by bugs.x2go.org; 1 Dec 2019 03:56:24 +0000
From x2go@ymir.das-netzwerkteam.de  Sun Dec  1 04:56:14 2019
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,NO_RELAYS,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2
Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005)
	id 135B65DC9E; Sun,  1 Dec 2019 04:56:12 +0100 (CET)
From:  <ionic@ionic.de>
To: 1418-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org, 1418@bugs.x2go.org
Subject: X2Go issue (in src:x2goclient) has been marked as pending for release
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Mailer: http://snipr.com/post-receive-tag-pending
Message-Id: <20191201035613.135B65DC9E@ymir.das-netzwerkteam.de>
Date: Sun,  1 Dec 2019 04:56:12 +0100 (CET)

tag #1418 pending
fixed #1418 4.1.2.2
thanks

Hello,

X2Go issue #1418 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=31a4d6c

The issue will most likely be fixed in src:x2goclient (4.1.2.2).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 31a4d6c1b46c1608a5441e23c80f8e0db5e0d3a7
Author: Mihai Moldovan <ionic@ionic.de>
Date:   Sun Dec 1 04:54:34 2019 +0100

    src/sessionwidget.cpp: stop parsing proxy address as "host:port" if the address contains a colon. Fixes: #1418.
    
    We don't do this for the "normal" host address and this behavior clashes
    with IPv6 addresses.
    
    We COULD, theoretically, keep it, but that would require writing an
    arbitrary address parser. Too much effort for little gain.

diff --git a/debian/changelog b/debian/changelog
index 0a280b4..2a51b0c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -121,6 +121,11 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium
       retranslations required.
     - src/httpbrokerclient.cpp: do not leak password length in debug output
       either.
+    - src/sessionwidget.cpp: stop parsing proxy address as "host:port: if the
+      address contains a colon. Fixes: #1418. We don't do this for the
+      "normal" host address and this behavior clashes with IPv6 addresses. We
+      COULD, theoretically, keep it, but that would require writing an
+      arbitrary address parser. Too much effort for little gain.
   * debian/control:
     + Add build-depend on pkg-config.
   * x2goclient.spec:

Send a report that this bug log contains spam.