X2Go Bug report logs - #1409
Fwd: [Bug 1754220] New: x2gocleansessions kills user desktop shortly after login (~20 secs)

version graph

Package: x2goserver; Maintainer for x2goserver is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver is src:x2goserver.

Reported by: Orion Poplawski <orion@nwra.com>

Date: Sun, 22 Sep 2019 22:55:02 UTC

Severity: normal

Tags: patch

Found in version 4.1.0.3

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#1409; Package x2goserver. (Sun, 22 Sep 2019 22:55:02 GMT) (full text, mbox, link).


Acknowledgement sent to Orion Poplawski <orion@nwra.com>:
New Bug report received and forwarded. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>. (Sun, 22 Sep 2019 22:55:02 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

From: Orion Poplawski <orion@nwra.com>
To: submit@bugs.x2go.org
Subject: Fwd: [Bug 1754220] New: x2gocleansessions kills user desktop shortly after login (~20 secs)
Date: Sun, 22 Sep 2019 16:51:51 -0600
[Message part 1 (text/plain, inline)]
Package: x2goserver
Version: 4.1.0.3
Tags: patch


-------- Forwarded Message --------
Subject: [Bug 1754220] New: x2gocleansessions kills user desktop shortly 
after login (~20 secs)
Date: Sat, 21 Sep 2019 22:07:05 +0000
From: bugzilla@redhat.com
To: orion@nwra.com

https://bugzilla.redhat.com/show_bug.cgi?id=1754220

            Bug ID: 1754220
           Summary: x2gocleansessions kills user desktop shortly after
                    login (~20 secs)
           Product: Fedora
           Version: 30
            Status: NEW
         Component: x2goserver
          Assignee: orion@nwra.com
          Reporter: gregory.lee.bartholomew@gmail.com
        QA Contact: extras-qa@fedoraproject.org
                CC: orion@nwra.com
  Target Milestone: ---
    Classification: Fedora



Description of problem:

Randomly, user sessions are booted after logging in. Usually a stable
connection can be acquired after a few retries.

Version-Release number of selected component (if applicable):

# rpm -q x2goserver
x2goserver-4.1.0.3-3.fc30.x86_64

How reproducible:

Randomly

Steps to Reproduce:

1. Login and wait 20 to 30 seconds (I was using LXDE and occasionally 
running
"sudo -i" in a terminal, but I don't think that is necessary to trigger the
bug).

Actual results:

Session killed shortly after logging in.

Expected results:

Session should not be killed.

Additional info:

To troubleshoot this issue, I did the following:

# mkdir /etc/systemd/system/x2gocleansessions.service.d
# cat << END > /etc/systemd/system/x2gocleansessions.service.d/override.conf
[Service]
Type=simple
ExecStart=
ExecStart=/usr/sbin/x2gocleansessions -d
END
# systemctl daemon-reload
# systemctl restart x2gocleansessions.service

After sprinkling /usr/sbin/x2gocleansessions with printf statements and
x2gocleansessions.service a few times, I eventually traced the problem 
down to
check_pid() being called with a NULL value for $pid (not sure why; seems 
to be
some sort of race condition). The following patch seems to resolve the 
issue.

--- x2gocleansessions.a 2019-09-21 16:46:53.327948763 -0500
+++ x2gocleansessions.b 2019-09-21 16:46:10.076184475 -0500
@@ -62,7 +62,7 @@
        my $pid=shift;
        my $sess=shift;
        my $sec=shift;
-       if ($sec < 30)
+       if (!$pid || $sec < 30)
        {
                return 1;
        }

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[smime.p7s (application/pkcs7-signature, attachment)]

Information forwarded to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#1409; Package x2goserver. (Sun, 22 Sep 2019 23:05:01 GMT) (full text, mbox, link).


Acknowledgement sent to Orion Poplawski <orion@nwra.com>:
Extra info received and forwarded to list. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>. (Sun, 22 Sep 2019 23:05:01 GMT) (full text, mbox, link).


Message #10 received at 1409@bugs.x2go.org (full text, mbox, reply):

From: Orion Poplawski <orion@nwra.com>
To: 1409@bugs.x2go.org
Subject: Fwd: [Bug 1350004] simultaneous x2go and desktop sessions cause dbus conflicts
Date: Sun, 22 Sep 2019 17:04:33 -0600
[Message part 1 (text/plain, inline)]


-------- Forwarded Message --------
Subject: [Bug 1350004] simultaneous x2go and desktop sessions cause dbus 
conflicts
Date: Sat, 21 Sep 2019 01:32:19 +0000
From: bugzilla@redhat.com
To: orion@nwra.com

https://bugzilla.redhat.com/show_bug.cgi?id=1350004



--- Comment #17 from Gregory Lee Bartholomew 
<gregory.lee.bartholomew@gmail.com> ---
It looks like I spoke to soon -- it has started kicking me off after 
about 20
seconds again. So I guess this work-around isn't working after all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[smime.p7s (application/pkcs7-signature, attachment)]

Information forwarded to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#1409; Package x2goserver. (Sun, 22 Sep 2019 23:10:02 GMT) (full text, mbox, link).


Acknowledgement sent to Orion Poplawski <orion@nwra.com>:
Extra info received and forwarded to list. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>. (Sun, 22 Sep 2019 23:10:02 GMT) (full text, mbox, link).


Message #15 received at 1409@bugs.x2go.org (full text, mbox, reply):

From: Orion Poplawski <orion@nwra.com>
To: 1409@bugs.x2go.org
Subject: Sorry, disregard that last one
Date: Sun, 22 Sep 2019 17:05:58 -0600
[Message part 1 (text/plain, inline)]
That was from a different bug report.

-- 
Orion Poplawski
Manager of NWRA Technical Systems          720-772-5637
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                 https://www.nwra.com/

[smime.p7s (application/pkcs7-signature, attachment)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Tue Oct 15 01:18:49 2019; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.