X2Go Bug report logs - #1393
sftp-server binary not found gentoo (profile 17.1)

Full log

Message #33 received at 1393@bugs.x2go.org (full text, mbox, reply):

Received: (at 1393) by bugs.x2go.org; 18 Jun 2019 13:35:14 +0000
From polynomial-c@gentoo.org  Tue Jun 18 15:35:12 2019
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=ham autolearn_force=no
	version=3.4.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 0F4995DAF4
	for <1393@bugs.x2go.org>; Tue, 18 Jun 2019 15:35:12 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id jwCmQiugH2Z3 for <1393@bugs.x2go.org>;
	Tue, 18 Jun 2019 15:35:05 +0200 (CEST)
X-Greylist: delayed 457 seconds by postgrey-1.35 at ymir.das-netzwerkteam.de; Tue, 18 Jun 2019 15:35:04 CEST
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id E31FD5DAE9
	for <1393@bugs.x2go.org>; Tue, 18 Jun 2019 15:35:04 +0200 (CEST)
Received: from abudhabi.paradoxon.rec (p54A9DB3C.dip0.t-ipconnect.de [84.169.219.60])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: polynomial-c)
	by smtp.gentoo.org (Postfix) with ESMTPSA id 9E14E34640F;
	Tue, 18 Jun 2019 13:27:20 +0000 (UTC)
Date: Tue, 18 Jun 2019 15:27:11 +0200
From: Lars Wendler <polynomial-c@gentoo.org>
To: Mihai Moldovan <ionic@ionic.de>
Cc: 1393@bugs.x2go.org, Tobias Ehrig <me@t0by.eu>, voyageur@gentoo.org
Subject: Re: [X2Go-Dev] Bug#1393: Bug#1393: sftp-server binary not found
 gentoo (profile 17.1)
Message-ID: <20190618152711.2f05b797@abudhabi.paradoxon.rec>
In-Reply-To: <10915935-0dfc-e0f2-9db2-41058a5f1a3d@ionic.de>
References: <6f820bb96ef55175c50465dbaa2d98408f1b598c.camel@t0by.eu>
	<10915935-0dfc-e0f2-9db2-41058a5f1a3d@ionic.de>
Organization: Gentoo
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 boundary="Sig_/ergoWjlXOSoHg2fJfbVH6BN"; protocol="application/pgp-signature"

[Message part 1 (text/plain, inline)]

Hello,

On Tue, 18 Jun 2019 11:04:31 +0200 Mihai Moldovan wrote:

>Control: reassign -1 x2goclient
>
>* On 6/18/19 9:12 AM, Tobias Ehrig wrote:
>> Package: net-misc/x2goclient
>> Version: 4.1.2.1
>> 
>> On Gentoo (eselect profile 17.1) the x2goclient can't find the binary
>> sftp-server which is located at
>> 
>> /usr/lib64/misc/sftp-server
>> 
>> 
>> Here is a patch  
>
>I was inclined to NAK this at first.
>
>/usr/lib on a multilib Gentoo system is typically a symlink
>to /usr/lib64, while on non-multilib systems, as far as I remember,
>it's just a normal directory containing all library files.

IMHO you should NAK such a patch as this is definitely an issue coming
from our 17.1 profile's new lib directory structure.
If you commit the suggested patch, all 32bit 17.1 profile installations
will suffer from the bug our 64bit 17.1 profile installations currently
suffer from.


>The entry containing /usr/lib/misc should hence cover your use case as
>well. Did the 17.1 profile remove the /usr/lib symlink? I'm currently
>still on 17.0, but it looks like the whole point of 17.1 is to remove
>the compat symlink, so you seem to be on the right track.

We changed the following directories on 64bit arches with the 17.1
profile:

17.0:

# ls -ld /lib*
lrwxrwxrwx 1 root root    5 May 17 10:24 /lib -> lib64
drwxr-xr-x 1 root root 1174 May 17 10:26 /lib32
drwxr-xr-x 1 root root 5078 Jun 13 18:50 /lib64


17.1:

# ls -ld /lib*
drwxr-xr-x 1 root root 1382 May 13 22:54 /lib
drwxr-xr-x 1 root root 5340 Jun 18 10:23 /lib64


As you can see, "lib32" became "lib" and "lib" is no longer a symlink
pointing to "lib64".

My suggestion is to let the Gentoo package maintainers handle this in
the affected x2go package's ebuild files. We have a function called
"get_libdir" that can be used with sed to set the correct lib dir
name in the affected code. 

>I think I'll apply a slightly modified patch that
>favors /usr/lib64/misc instead (mostly because that's the more common
>arch now, we want to avoid calling 32-bit binaries on 64-bit systems
>even if they are installed and it's highly unlikely to have a
>32-64-bit multilib system [i.e., main system 32-bit, with 64-bit as an
>additional architecture]).
>
>
>
>Mihai
>

Kind regards

-- 
Lars Wendler
Gentoo package maintainer
GPG: 21CC CF02 4586 0A07 ED93  9F68 498F E765 960E 9B39

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.