X2Go Bug report logs - #1305
bad window title encoding for Unicode (Cyrillic) session names

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Ivan Zakharyaschev <imz@altlinux.org>

Date: Fri, 15 Jun 2018 19:30:02 UTC

Severity: normal

Found in version 4.1.1.1

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to x2go-dev@lists.x2go.org, cas@altlinux.org, mcpain@altlinux.org, zerg@altlinux.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#1305; Package x2goclient. (Fri, 15 Jun 2018 19:30:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ivan Zakharyaschev <imz@altlinux.org>:
New Bug report received and forwarded. Copy sent to cas@altlinux.org, mcpain@altlinux.org, zerg@altlinux.org, X2Go Developers <x2go-dev@lists.x2go.org>. (Fri, 15 Jun 2018 19:30:02 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.x2go.org (full text, mbox):

From: Ivan Zakharyaschev <imz@altlinux.org>
To: submit@bugs.x2go.org
Subject: bad window title encoding for Unicode (Cyrillic) session names
Date: Fri, 15 Jun 2018 22:21:35 +0300 (MSK)
[Message part 1 (text/plain, inline)]
Package: x2goclient
Version: 4.1.1.1
Tag: patch

If the session name is written in Cyrillic (I guess, any Unicode), the 
window title is displayed incorrectly (as if Unicode was not understood, 
with strange symbols) in the task bar in the KDE panel.

See the attached screenshot (made by mcpain@).

Patch (by mcpain@ and zerg@) is attached, too: 
x2goclient-4.1.1.1-window-title-encoding.patch

The client and server OS are: ALT Linux (Sisyphus or p8).
The window manager is KDE.
[x2goclient-4.1.1.1-window-title-encoding.patch (text/x-patch, ATTACHMENT)]
From 877cc06728efac1ccd7c01d47c25df0166de42e8 Mon Sep 17 00:00:00 2001
From: Oleg Solovyov <mcpain@altlinux.org>
Date: Fri, 15 Jun 2018 20:55:26 +0300
Subject: [PATCH] fix window title encoding for Unicode (Cyrillic) session
 names

If the session name was written in Cyrillic, the window title would be
displayed incorrectly (as if Unicode was not understood, with strange
symbols) in the task bar in the KDE panel.

Co-authored-by: Sergey V Turchin <zerg@altlinux.org>
---
 src/onmainwindow.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/onmainwindow.cpp b/src/onmainwindow.cpp
index fdc043b..7b2c283 100644
--- a/src/onmainwindow.cpp
+++ b/src/onmainwindow.cpp
@@ -11233,6 +11233,12 @@ void ONMainWindow::setProxyWinTitle()
 #ifdef Q_OS_LINUX
 
     XStoreName(QX11Info::display(), proxyWinId, title.toLocal8Bit().data());
+    XChangeProperty(QX11Info::display(), proxyWinId,
+                    XInternAtom(QX11Info::display(), "_NET_WM_NAME", 0),
+                    XInternAtom(QX11Info::display(), "UTF8_STRING", 0), 8,
+                    PropModeReplace,
+                    (unsigned char*) title.toUtf8().data(),
+                    strlen(title.toUtf8().data()));
 
     XWMHints* win_hints;
 
-- 
2.10.4

[x2go-window-title-encoding-bug-drkonqi.png (image/png, ATTACHMENT)]

Information forwarded to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#1305; Package x2goclient. (Wed, 15 Aug 2018 21:20:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Mike Gabriel <mike.gabriel@das-netzwerkteam.de>:
Extra info received and forwarded to list. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>. (Wed, 15 Aug 2018 21:20:02 GMT) Full text and rfc822 format available.

Message #10 received at 1305@bugs.x2go.org (full text, mbox):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Ivan Zakharyaschev <imz@altlinux.org>, 1305@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#1305: bad window title encoding for Unicode (Cyrillic) session names
Date: Wed, 15 Aug 2018 21:06:54 +0000
[Message part 1 (text/plain, inline)]
Hi Ionic,

On  Fr 15 Jun 2018 21:21:35 CEST, Ivan Zakharyaschev wrote:

> Package: x2goclient
> Version: 4.1.1.1
> Tag: patch
>
> If the session name is written in Cyrillic (I guess, any Unicode), the
> window title is displayed incorrectly (as if Unicode was not understood,
> with strange symbols) in the task bar in the KDE panel.
>
> See the attached screenshot (made by mcpain@).
>
> Patch (by mcpain@ and zerg@) is attached, too:
> x2goclient-4.1.1.1-window-title-encoding.patch
>
> The client and server OS are: ALT Linux (Sisyphus or p8).
> The window manager is KDE.

any opinion on this already. Looks ok to me. For nx-libs we have a  
similar issue which I consider fixing by merging the open PR.

Mike
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Tue Dec 11 08:04:20 2018; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.