#1234 - acl-users-allow=ALL superceeds acl-users-deny

X2Go Bug report logs - #1234
acl-users-allow=ALL superceeds acl-users-deny

Reported by: Walid MOGHRABI <w.moghrabi@servicemagic.eu>

Date: Tue, 21 Nov 2017 17:30:02 UTC

Severity: normal

Tags: patch, pending

Fixed in version 0.0.4.0

Done: X2Go Release Manager X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Subject: Bug#1234: [X2Go-Dev] acl-users-allow=ALL superceeds acl-users-deny
Reply-To: Mihai Moldovan <ionic@ionic.de>, 1234@bugs.x2go.org
Resent-From: Mihai Moldovan <ionic@ionic.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
Resent-Date: Sun, 26 Nov 2017 06:35:01 +0000
Resent-Message-ID: <handler.1234.B1234.151167803426026@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
To: Walid MOGHRABI <w.moghrabi@servicemagic.eu>, 1234@bugs.x2go.org,
 mike.gabriel@sunweavers.net
References: <2074085984.30965501.1511285012453.JavaMail.root@servicemagic.eu>
From: Mihai Moldovan <ionic@ionic.de>
Message-ID: <1ff7d092-aa53-61cb-ba55-cfaeeb35f380@ionic.de>
Date: Sun, 26 Nov 2017 07:33:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <2074085984.30965501.1511285012453.JavaMail.root@servicemagic.eu>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="MbHkASHGOqnVkoWOREAqlHGOlGI4SCnER"

[Message part 1 (text/plain, inline)]

* On 11/21/2017 06:23 PM, Walid MOGHRABI wrote: > When using ACLs with the session broker, I wanted to give access to a session setting to ALL users EXCEPT some (namely "formation{1..9}"). > I tried this but it didn't work : > [...] I really have no idea what the rules are supposed to be. For users, the current rules are (simplified, the actual rules are longer but also redundant): [allow-deny]: allow && !deny [deny-allow]: allow (allow stands for "user explicitly listed in allow list", deny stands for "user explicitly listed in deny list".) This doesn't make sense to me. For instance, a user not explicitly listed in the allowed list will be denied access in deny-allow mode, while in allow-deny mode; a user that is explicitly granted access will still be denied if it is listed in the denied list. What was the original inspiration for this? It's not Apache httpd, since that has different rules... My naïve understanding of this would be that: [allow-deny]: allow user if explicitly mentioned in allowed list, otherwise allow if not explicitly denied [deny-allow]: deny user if explicitly mentioned in denied list, otherwise allow Examples for [allow-deny] ("..." denotes a list *not* containing user): allow = { user, ... }; deny = { user, ... } => ALLOW allow = { user, ... }; deny = { ... } => ALLOW allow = { ... }; deny = { ... } => ALLOW allow = { ... }; deny = { user, ...} => DENY Examples for [deny-allow] ("..." denotes a list *not* containing user): allow = { user, ... }; deny = { user, ... } => DENY allow = { user, ... }; deny = { ... } => ALLOW allow = { ... }; deny = { ... } => ALLOW allow = { ... }; deny = { user, ... } => DENY This is useful because it allows access in the case a user is not a member of any list (emulating the behavior of not using any ACL for a specific user) and otherwise giving correct precedence to a specific list. The current behavior is not explicitly documented either, but only "implicitly" by code and tests, which makes it difficult to understand what is intended and what isn't. For instance, one test case explicitly mentions: [deny-allow] allow = { user }; deny = { ALL }; => ALLOW which just doesn't make sense to me. If all users are denied and the order is deny-allow, why would the user be allowed, even if it's in the allow list? The order isn't allow-deny, so if all users are denied with the deny-allow order, the allow list shouldn't even come into play. Mihai

[signature.asc (application/pgp-signature, attachment)]

X2Go Developers <owner@bugs.x2go.org>. Last modified: Tue Nov 4 10:01:04 2025; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

X2Go Bug report logs - #1234 acl-users-allow=ALL superceeds acl-users-deny

X2Go Bug report logs - #1234
acl-users-allow=ALL superceeds acl-users-deny