X2Go Bug report logs - #1230
x2go fails unhelpfully when a session fails to start

Full log

Message #45 received at 1230@bugs.x2go.org (full text, mbox, reply):

Received: (at 1230) by bugs.x2go.org; 9 Jan 2018 23:18:32 +0000
From x2go@ymir.das-netzwerkteam.de  Wed Jan 10 00:18:14 2018
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00
	autolearn=unavailable autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 758695DAEC;
	Wed, 10 Jan 2018 00:18:14 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id L12Lf_ke7DQF; Wed, 10 Jan 2018 00:17:56 +0100 (CET)
Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005)
	id 9F1285DAEB; Wed, 10 Jan 2018 00:17:54 +0100 (CET)
From: Mihai Moldovan <ionic@ionic.de>
To: 1230-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org, 1230@bugs.x2go.org
Subject: X2Go issue (in src:x2goserver) has been marked as pending for release
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Mailer: http://snipr.com/post-receive-tag-pending
Message-Id: <20180109231754.9F1285DAEB@ymir.das-netzwerkteam.de>
Date: Wed, 10 Jan 2018 00:17:54 +0100 (CET)

tag #1230 pending
fixed #1230 4.0.1.23
thanks

Hello,

X2Go issue #1230 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=7a76b29

The issue will most likely be fixed in src:x2goserver (4.0.1.23).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 7a76b291ed589775ee5d84c34b677fd621ce6d11
Author: Mihai Moldovan <ionic@ionic.de>
Date:   Thu Jan 4 06:16:51 2018 +0100

    x2goserver/bin/x2go{startagent,resume-session}: use x2gogetfreeport instead of duplicating the same code everywhere. Fixes: #1230.
    
    Also, rely on it returning a valid value and try at most 10 times to
    fetch a usable port value, then error out and make the session startup
    or resumption fail.

diff --git a/debian/changelog b/debian/changelog
index 818e823..f8582d4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -51,6 +51,11 @@ x2goserver (4.0.1.23-0x2go1) UNRELEASED; urgency=medium
       quotes on the lib path line.
     - x2goserver/bin/x2goresume-session: properly randomize first port, just
       like in x2gostartagent.
+    - x2goserver/bin/x2go{startagent,resume-session}: use x2gogetfreeport
+      instead of duplicating the same code everywhere. Fixes: #1230. Also,
+      rely on it returning a valid value and try at most 10 times to fetch a
+      usable port value, then error out and make the session startup or
+      resumption fail.
   * x2goserver.spec:
     - RPMify x2goserver-xsession description.
     - Remove qt4 stuff, we're not using the framework here.

Send a report that this bug log contains spam.