X2Go Bug report logs - #1230
x2go fails unhelpfully when a session fails to start

version graph

Package: x2goserver; Maintainer for x2goserver is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver is src:x2goserver.

Reported by: "Norman Gray" <gray@nxg.name>

Date: Fri, 27 Oct 2017 17:05:01 UTC

Severity: normal

Tags: pending

Found in version 4.0.1.20

Fixed in version 4.0.1.23

Full log

Message #22 received at 1230@bugs.x2go.org (full text, mbox, reply):

Received: (at 1230) by bugs.x2go.org; 2 Nov 2017 19:08:54 +0000
From ionic@ionic.de  Thu Nov  2 20:08:51 2017
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.7 required=3.0 tests=BAYES_20,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,RDNS_NONE,URIBL_BLOCKED autolearn=no
	autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 5DA4C5DACE
	for <1230@bugs.x2go.org>; Thu,  2 Nov 2017 20:08:51 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id biFBs2RCelpG for <1230@bugs.x2go.org>;
	Thu,  2 Nov 2017 20:08:44 +0100 (CET)
Received: from mail.ionic.de (unknown [IPv6:2001:41d0:a:588b:1::2])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 4B0D45DACD
	for <1230@bugs.x2go.org>; Thu,  2 Nov 2017 20:08:43 +0100 (CET)
Received: from [10.20.40.15] (178.162.222.163.adsl.inet-telecom.org [178.162.222.163])
	by mail.ionic.de (Postfix) with ESMTPSA id 42CED4F000A3;
	Thu,  2 Nov 2017 20:08:42 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1509649722; bh=946EFCa4w+F3iXBvrcY6ffUCrsAGNnHpU/auc1H1r64=;
	h=Subject:To:References:From:Date:In-Reply-To:From;
	b=K4NkYd/JCPVN0KOPwqAd2kKX5LlAX3/wJSvH9/Q6B/XU+piic9ema7P7Zh8QH81+v
	 XwrmG5KRsVNUJtVA/Cf54weAowHkvxiHnRJ7diJpaEeM+/D0ziIPK1t0bbAIS7dNtt
	 zg8pSpLUXqdmCJcV9Q8XAOPmHM+F6ySFsMggjCDY=
Subject: Re: [X2Go-Dev] x2go fails unhelpfully when a session fails to start
To: Norman Gray <gray@nxg.name>, 1230@bugs.x2go.org
References: <AEF0C8DA-B122-4D28-BBA4-3E3A6463C5DD@nxg.name>
From: Mihai Moldovan <ionic@ionic.de>
Message-ID: <4eef6d5a-03c4-cfa8-d01c-31badb85fc2c@ionic.de>
Date: Thu, 2 Nov 2017 20:08:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <AEF0C8DA-B122-4D28-BBA4-3E3A6463C5DD@nxg.name>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="sW1pREA0nktnmNkG2OS112fNc2nHdLEDS"

[Message part 1 (text/plain, inline)]
Control: tag -1 -pending
Control: notfixed -1 4.0.1.21

On 10/27/2017 07:02 PM, Norman Gray wrote:
> Package: x2goserver
> Version: 4.0.1.20
> 
> When a username is rejected by the 'valid username' test (see separate 
> bug report<https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1229>), the 
> session doesn't fail, but simply seems to hang, giving no feedback about 
> the problem, nor, as far as I can see, reporting anything in the logs.
> 
> To reproduce, attempt to log in using a username such as '123x'.  The 
> session doesn't complete the setup, leaving the user at a blank screen.
> 
> Suggestion: a user-visible error message should be produced, and an 
> informative message sent to the system log.

I've tried catching errors while inserting values into the database, but it
turns out that doing this is not easily possible, since the current code relies
on brute-force adding of new DB entries and ignoring errors until it succeeds.
If a hard error occurs that will make any insertion fail, of course this will
loop forever.

I'll need to implement something more sophisticated that detects hard errors
which will always lead to failures.



Mihai



[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 15:16:51 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.