X2Go Bug report logs - #1228
Implement basic dialog handling in X2Go Server

version graph

Package: x2goserver; Maintainer for x2goserver is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver is src:x2goserver.

Reported by: Alexey Nemov <alexnemov@protonmail.com>

Date: Thu, 26 Oct 2017 06:45:01 UTC

Severity: normal

Found in version 4.0.1.20

Full log

Message #12 received at 1228@bugs.x2go.org (full text, mbox, reply):

Received: (at 1228) by bugs.x2go.org; 26 Oct 2017 07:17:35 +0000
From ionic@ionic.de  Thu Oct 26 09:17:34 2017
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-0.6 required=3.0 tests=BAYES_05,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,URIBL_BLOCKED autolearn=ham autolearn_force=no
	version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 88AA05DAD1
	for <1228@bugs.x2go.org>; Thu, 26 Oct 2017 09:17:34 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id SRTCaH7Y6_NS for <1228@bugs.x2go.org>;
	Thu, 26 Oct 2017 09:17:29 +0200 (CEST)
Received: from mail.ionic.de (ionic.de [87.98.244.45])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id A9A7B5DACC
	for <1228@bugs.x2go.org>; Thu, 26 Oct 2017 09:17:29 +0200 (CEST)
Received: from [10.20.40.15] (178.162.222.163.adsl.inet-telecom.org [178.162.222.163])
	by mail.ionic.de (Postfix) with ESMTPSA id 3B9604F00441;
	Thu, 26 Oct 2017 09:17:29 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1509002249; bh=YRPMsrIfQ1JbE/sd+yTtXE+GyE1AHxUr3AVBCgBl3zM=;
	h=Subject:To:References:From:Date:In-Reply-To:From;
	b=WC9XR/LI5J6f7ZasfM788dBbIpeGoCPp01lSlyli/ZlDk2+8osvi0Peeb/YQJqeww
	 dTsOHPKAsv+13avDYVrbThZ2R6EHnmlYNm7Mqssq3fiRzMqZ8LcARqTV5Rx18InRo+
	 qoHlEiTHkVfipW79YaMhLenj6s6c+AMnPSbyTSRw=
Subject: Re: [X2Go-Dev] Ctrl-Alt-T doesn't terminate connection in "local
 desktop" sessions
To: Alexey Nemov <alexnemov@protonmail.com>, 1228@bugs.x2go.org
References: <yhnB5qoHv8mpsyEx0f88K0TopgX03H_-m9Heml29lUC99kNIGbkUr7xgM_px972KY5kTORpItVj2M8OJ48U6RJ7XPw_1N07OJjFwXvhFhOk=@protonmail.com>
From: Mihai Moldovan <ionic@ionic.de>
Message-ID: <92b9f9ea-e19e-8d62-dd60-b7fea4629f60@ionic.de>
Date: Thu, 26 Oct 2017 09:17:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <yhnB5qoHv8mpsyEx0f88K0TopgX03H_-m9Heml29lUC99kNIGbkUr7xgM_px972KY5kTORpItVj2M8OJ48U6RJ7XPw_1N07OJjFwXvhFhOk=@protonmail.com>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="hQNrmtHVRL2SCLm1x5GFHLNOBn2KBT0XK"

[Message part 1 (text/plain, inline)]
Control: retitle -1 Implement basic dialog handling in X2Go Server

On 10/26/2017 08:32 AM, Alexey Nemov wrote:
> As stated in the wiki https://wiki.x2go.org/doku.php/wiki:advanced:nx-keyboard-shortcuts
> The action "close_session" should terminate the session.
> But, pressing Ctrl-Alt-t in a "local desktop" session does not "terminate" the session.

This is caused by the way we handle dialogs from nxagent. Currently, every
dialog (wrongly) spawns x2gosuspend-session for every message the agent wants to
show.

nxagent sends a KILL SESSION dialog when close_session is executed for
non-persistent sessions (like shadow sessions), but the default handler
x2gosuspend-session that is set via NX_CLIENT is x2gosuspend-session, which is
called and fails to suspend the session (since session suspension doesn't make
sense or works with non-persistent sessions.)

While the general goal should be to relay messages to the client side one day,
currently I want a small wrapper script on the server side which handles
server-side events in a better way.

Thus retitling this bug report.



Mihai


[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 14:58:03 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.