X2Go Bug report logs - #1153
x2goruncommand must stop exporting LD_LIBRARY_PATH with nx-libs 3.6.x

version graph

Package: x2goserver; Maintainer for x2goserver is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver is src:x2goserver.

Reported by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Date: Tue, 7 Mar 2017 18:25:02 UTC

Severity: important

Tags: patch, pending

Found in version 4.1.0.0

Fixed in version 4.0.1.21

Done: X2Go Release Manager X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

Message #12 received at 1153@bugs.x2go.org (full text, mbox, reply):

Received: (at 1153) by bugs.x2go.org; 8 Mar 2017 08:46:17 +0000
From mike.gabriel@das-netzwerkteam.de  Wed Mar  8 09:46:16 2017
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 45FAA5DA85
	for <1153@bugs.x2go.org>; Wed,  8 Mar 2017 09:46:16 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id koFr8EQ2W2NA for <1153@bugs.x2go.org>;
	Wed,  8 Mar 2017 09:46:09 +0100 (CET)
Received: from fregna.das-netzwerkteam.de (fregna.das-netzwerkteam.de [148.251.53.130])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 5428F5DA2B
	for <1153@bugs.x2go.org>; Wed,  8 Mar 2017 09:46:09 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [IPv6:2a01:4f8:202:1381::105])
	by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id 26E2360564
	for <1153@bugs.x2go.org>; Wed,  8 Mar 2017 08:46:09 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 17A5FC3BAF
	for <1153@bugs.x2go.org>; Wed,  8 Mar 2017 09:46:09 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id WIwd0KMrs0d4 for <1153@bugs.x2go.org>;
	Wed,  8 Mar 2017 09:46:04 +0100 (CET)
Received: from das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id B1E61C3BB0
	for <1153@bugs.x2go.org>; Wed,  8 Mar 2017 09:46:04 +0100 (CET)
Received: from m-087.informatik.uni-kiel.de (m-087.informatik.uni-kiel.de
 [134.245.254.87]) by mail.das-netzwerkteam.de (Horde Framework) with HTTPS;
 Wed, 08 Mar 2017 08:46:04 +0000
Date: Wed, 08 Mar 2017 08:46:04 +0000
Message-ID: <20170308084604.Horde.53VoM3rt-PfA9V5aHpkkeZQ@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: 1153@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#1153: x2goruncommand must stop exporting
 LD_LIBRARY_PATH with nx-libs 3.6.x
In-Reply-To: <20170307182311.Horde.oc0qRxkwCoY_s0Qqg1c8yP4@mail.das-netzwerkteam.de>
User-Agent: Horde Application Framework 5
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 134.245.254.87
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Firefox/45.0
Content-Type: multipart/signed; boundary="=_lUkhNky0g7DyNF7B0P780ok";
 protocol="application/pgp-signature"; micalg=pgp-sha256
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]
Hi Mihai

On  Di 07 Mär 2017 19:23:11 CET, Mike Gabriel wrote:

> Package: x2goserver
> Severity: important
> Version: 4.1.0.0
> Control: tags -1 patch
>
>
> In Arctica's nx-libs, we changed the path where the libX11.so  
> symlinks to libNX_X11.so reside.
>
> This makes applications in X2Go behave strange esp. Actually, the  
> LD_LIBRARY_PATH setup is for nx-libs 3.5.0.x and obsolete in 3.6.x.
>
> Here is a simple patch that stops setting LD_LIBRARY_PATH, if  
> nx-libs 3.6.x is installed:
>
> ```
> diff --git a/x2goserver/bin/x2goruncommand b/x2goserver/bin/x2goruncommand
> index 8c3ee62..4593539 100755
> --- a/x2goserver/bin/x2goruncommand
> +++ b/x2goserver/bin/x2goruncommand
> @@ -68,14 +68,16 @@ if [ -S "$SSH_AUTH_SOCK" ]; then
>  fi
>  export SSH_AUTH_SOCK="$X2GOSSH_AUTH_SOCK"
>
> -
> -NX_XINERAMA_LIBS="$(x2gopath xinerama)"
> -NX_LIBS="$(x2gopath nx-x11)"
> -test -n "$LD_LIBRARY_PATH" && \
> -       LD_LIBRARY_PATH="$NX_XINERAMA_LIBS:$NX_LIBS:$LD_LIBRARY_PATH" || \
> -       LD_LIBRARY_PATH="$NX_XINERAMA_LIBS:$NX_LIBS"
> -"$X2GO_LIB_PATH/x2gosyslog" "$0" "debug" "exporting  
> LD_LIBRARY_PATH=$LD_LIBRARY_PATH"
> -export LD_LIBRARY_PATH
> +if ! x2gofeature X2GOAGENT_RANDRXINERAMA 1>/dev/null; then
> +
> +       NX_XINERAMA_LIBS="$(x2gopath xinerama)"
> +       NX_LIBS="$(x2gopath nx-x11)"
> +       test -n "$LD_LIBRARY_PATH" && \
> +                
> LD_LIBRARY_PATH="$NX_XINERAMA_LIBS:$NX_LIBS:$LD_LIBRARY_PATH" || \
> +               LD_LIBRARY_PATH="$NX_XINERAMA_LIBS:$NX_LIBS"
> +       "$X2GO_LIB_PATH/x2gosyslog" "$0" "debug" "exporting  
> LD_LIBRARY_PATH=$LD_LIBRARY_PATH"
> +       export LD_LIBRARY_PATH
> +fi
>
>  if [ "$sndsys" == "esd" ]; then
>         export ESPEAKER="localhost:$4"
>
> ```

Can you make sure that this patch is also backported to the  
release/4.0.1.x branch? In case X2Go switches to nx-libs 3.6.x earlier  
than releasing X2Go Server 4.1.0.0.

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de


[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 16:22:54 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.