X2Go Bug report logs - #1122
x2goclient spurously asks for passphrase on autologin

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Arne Wichmann <aw@anhrefn.saar.de>

Date: Thu, 8 Dec 2016 18:05:02 UTC

Severity: normal

Tags: patch, pending

Found in version 4.0.5.2

Fixed in version 4.1.1.1

Done: X2Go Release Manager X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

Message #12 received at control@bugs.x2go.org (full text, mbox, reply):

Received: (at control) by bugs.x2go.org; 8 Mar 2017 12:54:14 +0000
From aw@old-forest.org  Wed Mar  8 13:54:05 2017
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 1A6FF5DA85;
	Wed,  8 Mar 2017 13:54:05 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id oJMjHbLV8j4x; Wed,  8 Mar 2017 13:53:58 +0100 (CET)
X-Greylist: delayed 569 seconds by postgrey-1.35 at ymir.das-netzwerkteam.de; Wed, 08 Mar 2017 13:53:58 CET
Received: from apu.snow-crash.org (crusty.snow-crash.org [213.239.193.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 39D8D5DA2B;
	Wed,  8 Mar 2017 13:53:58 +0100 (CET)
Received: from chao-revive (arne.local [10.99.0.2])
	by apu.snow-crash.org (Postfix) with ESMTP id 0F1F78061B;
	Wed,  8 Mar 2017 13:44:29 +0100 (CET)
Received: from [192.168.10.23] (helo=anhrefn.saar.de)
	by chao-revive with esmtps (Exim 4.88)
	(envelope-from <aw@old-forest.org>)
	id 1clayk-00077b-U5; Wed, 08 Mar 2017 13:46:06 +0100
Received: from aw by anhrefn.saar.de with local (Exim 4.88)
	(envelope-from <aw@old-forest.org>)
	id 1clax4-0006eM-0S; Wed, 08 Mar 2017 13:44:22 +0100
Date: Wed, 8 Mar 2017 13:44:11 +0100
From: Arne Wichmann <aw@anhrefn.saar.de>
To: 1122@bugs.x2go.org
Cc: control@bugs.x2go.org
Subject: Patch
Message-ID: <20170308124411.GB16588@anhrefn.saar.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="0eh6TmSyL6TZE2Uz"
Content-Disposition: inline
Return-Receipt-To: aw@anhrefn.saar.de
X-message-flag: Outluck ist kaputt :-)
User-Agent: Mutt/1.5.23 (2014-03-12)

[Message part 1 (text/plain, inline)]
tag #1122 patch
thanks

Hi...

So, I created an experimental patch which makes the problem go away.

cu

AW

----
diff --git a/debian/changelog b/debian/changelog
index dc1fbbf..c57c678 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+x2goclient (4.1.0.1-0x2go1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Do not ask passphrase on autologin
+
+ -- Arne Wichmann <aw@saar.de>  Wed, 08 Mar 2017 13:32:51 +0100
+
 x2goclient (4.1.0.1-0x2go1) UNRELEASED; urgency=medium
 
   [ Mihai Moldovan ]
diff --git a/src/sshmasterconnection.cpp b/src/sshmasterconnection.cpp
index 8e620c2..ab6398e 100644
--- a/src/sshmasterconnection.cpp
+++ b/src/sshmasterconnection.cpp
@@ -1150,6 +1150,8 @@ bool SshMasterConnection::userAuthAuto()
 {
     int rc = ssh_userauth_autopubkey ( my_ssh_session, "" );
     int i=0;
+#define NO_PASSPHRASE_ON_AUTOLOGIN
+#ifndef NO_PASSPHRASE_ON_AUTOLOGIN
     while(rc != SSH_AUTH_SUCCESS)
     {
         keyPhraseReady=false;
@@ -1173,6 +1175,7 @@ bool SshMasterConnection::userAuthAuto()
             break;
         }
     }
+#endif
 
     if ( rc != SSH_AUTH_SUCCESS )
     {
----

-- 
[...] If you don't want to be restricted, don't agree to it. If you are
coerced, comply as much as you must to protect yourself, just don't support
it. Noone can free you but yourself. (crag, on Debian Planet)
Arne Wichmann (aw@saar.de)

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 18:24:49 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.