X2Go Bug report logs - #1096
Qt5 build: qmake does not bundle resources correctly

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Bernard Cafarelli <voyageur@gentoo.org>

Date: Wed, 28 Sep 2016 20:45:01 UTC

Severity: normal

Tags: patch, pending

Found in version 4.0.5.2

Fixed in version 4.0.5.3

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 28 Sep 2016 20:43:18 +0000
From voyageur@gentoo.org  Wed Sep 28 22:43:15 2016
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_50,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 50C755DA96
	for <submit@bugs.x2go.org>; Wed, 28 Sep 2016 22:43:15 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 6yPLyAvIaWze for <submit@bugs.x2go.org>;
	Wed, 28 Sep 2016 22:43:08 +0200 (CEST)
X-Greylist: delayed 483 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Wed, 28 Sep 2016 22:43:08 CEST
Received: from intrepid.cafarelli.fr (intrepid.cafarelli.fr [195.154.119.210])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 860A75DA95
	for <submit@bugs.x2go.org>; Wed, 28 Sep 2016 22:43:07 +0200 (CEST)
Received: from enterprise.cafarelli.fr (unknown [IPv6:2001:bc8:33c5:8::1000])
	by intrepid.cafarelli.fr (Postfix) with ESMTPSA id 5DDC08007D
	for <submit@bugs.x2go.org>; Wed, 28 Sep 2016 22:35:00 +0200 (CEST)
DKIM-Filter: OpenDKIM Filter v2.10.3 intrepid.cafarelli.fr 5DDC08007D
Date: Wed, 28 Sep 2016 22:35:00 +0200
From: Bernard Cafarelli <voyageur@gentoo.org>
To: submit@bugs.x2go.org
Subject: Qt5 build: qmake does not bundle resources correctly
Message-ID: <20160928223500.2d8a55a6@enterprise.cafarelli.fr>
Organization: Gentoo Foundation, Inc.
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
X-Face: 7~4(Qk<`!us|JEfF`9/56!o9Lag,791'IUv</}aWl2ZPY?fFxeUzqxXWz]]gw.+0R0Q_d[r
 }+t0sse3,4kQO,*R<g"TAS)}NITD@d9=<@Vf+OC/&^6q"SIJ$U]<xN3_FO!9X2*yn4YBK4<p2NS|Xa
 yp):>mH;`8s>5orOs['3K9z-]Z+q\P>g'
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_/OAdaAOdvYdODieN1bseKbaY"
X-Virus-Scanned: clamav-milter 0.99 at intrepid
X-Virus-Status: Clean

[Message part 1 (text/plain, inline)]
Package: x2goclient
Version: 4.0.5.2

While updating the x2goclient Gentoo package to support a Qt5 build, I
found out that the binary did not have bundled resources (images and
translations), even if the same build with Qt4 worked fine.
Sample errors:
x2go-WARNING-1> "Non-fatal: can't load
translator: :/i18n/x2goclient_fr_fr"
[...]
Cannot open file ':/img/svg/x2gologo.svg', because: No such file or
directory
[...]

Huge thanks to Michael Palimaka <kensington@gentoo.org> who found out
the root cause:
rcc is the compiled version of qrc, so it looks like for some reason
qmake5 assumes the rcc files are already compiled, and bundles them
as-is instead of processing them

The fix is to rename the resources files from .rcc to .qrc (and update
the project file accordingly). Patch attached, tested and working fine
on Gentoo with Qt 4.8.7 and 5.6.1

-- 
Bernard Cafarelli (Voyageur)
Gentoo developer

[x2goclient-4.0.5.2-rcc_to_qrc.patch (text/x-patch, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 18:58:49 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.