X2Go Bug report logs - #1034
Fix a segfault in x2goclient with OpenBSD

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Denis Fondras <openbsd@ledeuns.net>

Date: Sat, 14 May 2016 10:30:01 UTC

Severity: normal

Found in version 4.0.5.1

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#1034; Package x2goclient. (Sat, 14 May 2016 10:30:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Denis Fondras <openbsd@ledeuns.net>:
New Bug report received and forwarded. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>. (Sat, 14 May 2016 10:30:02 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.x2go.org (full text, mbox):

From: Denis Fondras <openbsd@ledeuns.net>
To: submit@bugs.x2go.org
Subject: Fix a segfault in x2goclient with OpenBSD
Date: Sat, 14 May 2016 12:19:12 +0200
[Message part 1 (text/plain, inline)]
Package: x2goclient
Version: 4.0.5.1
Tag: patch

When compiling X2Go client on OpenBSD5.9/amd64, x2goclient will segfault in
SshMasterConnection::channelLoop(). The culprit is the declaration of buffer[]
inside the code of this function, moving it outside of channelLoop() fixes the
segfault.

[patch-src_sshmasterconnection_cpp (text/plain, attachment)]

Information forwarded to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#1034; Package x2goclient. (Sun, 15 May 2016 07:25:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Denis Fondras <openbsd@ledeuns.net>:
Extra info received and forwarded to list. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>. (Sun, 15 May 2016 07:25:02 GMT) Full text and rfc822 format available.

Message #10 received at 1034@bugs.x2go.org (full text, mbox):

From: Denis Fondras <openbsd@ledeuns.net>
To: 1034@bugs.x2go.org
Subject: Fix a segfault in x2goclient with OpenBSD
Date: Sun, 15 May 2016 09:14:04 +0200
Event better patch from Jeremie on OpenBSD mailing-list :
https://marc.info/?l=openbsd-ports&m=146327448112980&w=2


Information forwarded to x2go-dev@lists.x2go.org, X2Go Developers <x2go-dev@lists.x2go.org>:
Bug#1034; Package x2goclient. (Sat, 26 May 2018 08:20:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Mihai Moldovan <ionic@ionic.de>:
Extra info received and forwarded to list. Copy sent to X2Go Developers <x2go-dev@lists.x2go.org>. (Sat, 26 May 2018 08:20:03 GMT) Full text and rfc822 format available.

Message #15 received at 1034@bugs.x2go.org (full text, mbox):

From: Mihai Moldovan <ionic@ionic.de>
To: Denis Fondras <openbsd@ledeuns.net>, 1034@bugs.x2go.org
Cc: Jeremie Courreges-Anglas <jca@wxcvbn.org>
Subject: Re: Fix a segfault in x2goclient with OpenBSD
Date: Sat, 26 May 2018 10:18:20 +0200
[Message part 1 (text/plain, inline)]
* On 05/15/2016 09:14 AM, Denis Fondras wrote:
> Event better patch from Jeremie on OpenBSD mailing-list :
> https://marc.info/?l=openbsd-ports&m=146327448112980&w=2

Yeah, I had to work around that for OS X already in the past.

Thanks for the heads-up.


What about other OSes, though?

I've read that FreeBSD raised the default thread stack size to 2 MB starting
with 10.4, but I guess it wouldn't hurt to do it for that platform either.


I haven't really found any information regarding HPUX, AIX, NetBSD, OS/2,
Solaris (though I think the workaround is needed there as well), HURD (though I
think I've seen a bug report that mentions that changing the thread stack size
might not even work there, due to them using a fixed amount).

Any insights?



Mihai

[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Mon Dec 10 04:09:44 2018; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.