X2Go Bug report logs - #1003
x2goclient sshd (for folder sharing) weak host key

Full log

Message #19 received at control@bugs.x2go.org (full text, mbox, reply):

Received: (at control) by bugs.x2go.org; 24 May 2016 23:19:46 +0000
From x2go@ymir.das-netzwerkteam.de  Wed May 25 01:19:37 2016
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	URIBL_BLOCKED autolearn=unavailable version=3.3.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id D1D355DAD2;
	Wed, 25 May 2016 01:19:36 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id O4sFCkGbgDQJ; Wed, 25 May 2016 01:19:30 +0200 (CEST)
Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005)
	id 7DFF25DACF; Wed, 25 May 2016 01:19:30 +0200 (CEST)
From: Mihai Moldovan <ionic@ionic.de>
To: 1003-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org, 1003@bugs.x2go.org
Subject: X2Go issue (in src:x2goclient) has been marked as pending for release
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Mailer: http://snipr.com/post-receive-tag-pending
Message-Id: <20160524231930.7DFF25DACF@ymir.das-netzwerkteam.de>
Date: Wed, 25 May 2016 01:19:30 +0200 (CEST)

tag #1003 pending
fixed #1003 4.0.5.2
thanks

Hello,

X2Go issue #1003 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=6122d36

The issue will most likely be fixed in src:x2goclient (4.0.5.2).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 6122d36037f703c81e3936c52e8a17bf6b7820a4
Author: Mihai Moldovan <ionic@ionic.de>
Date:   Wed May 25 00:56:14 2016 +0200

    src/onmainwindow.h: rename ONMainWindow::generateHostDsaKey () to ONMainWindow::generateHostKey () and make key type selectible. Fixes: #1003.
    
    Host key type selection currently only works within the code. Replace
    calls to former ONMainWindow::generateHostDsaKey () with the generalized
    function and request an RSA-type key.

diff --git a/debian/changelog b/debian/changelog
index e96500e..7efe994 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -25,6 +25,11 @@ x2goclient (4.0.5.2-0x2go1) UNRELEASED; urgency=medium
     - src/{onmainwindow,sshmasterconnection}.cpp: refactoring and whitespace only
       changes following up the #1027 patch.
     - src/onmainwindow.h: add new enum for selecting SSH host key types.
+    - src/onmainwindow.h: rename ONMainWindow::generateHostDsaKey () to
+      ONMainWindow::generateHostKey () and make key type selectible. Fixes:
+      #1003. Host key type selection currently only works within the code. Replace
+      calls to former ONMainWindow::generateHostDsaKey () with the generalized
+      function and request an RSA-type key.
 
   [ Mike DePaulo ]
   * New upstream release (4.0.5.2):

Send a report that this bug log contains spam.