X2Go Bug report logs - #1000
[PATCH 1/1] sshmasterconnection.cpp: invalid proxy socket

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Date: Sun, 21 Feb 2016 23:15:02 UTC

Severity: normal

Tags: pending

Found in version 4.0.5.1

Fixed in version 4.0.5.1

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 21 Feb 2016 23:14:11 +0000
From xypron.glpk@gmx.de  Mon Feb 22 00:14:07 2016
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_50,FREEMAIL_FROM,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 4DD805DA96
	for <submit@bugs.x2go.org>; Mon, 22 Feb 2016 00:14:07 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Lz5kQ2OiYGTU for <submit@bugs.x2go.org>;
	Mon, 22 Feb 2016 00:14:00 +0100 (CET)
X-Greylist: delayed 304 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Mon, 22 Feb 2016 00:14:00 CET
Received: from mout.gmx.net (mout.gmx.net [212.227.15.15])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 8D9E75DA95
	for <submit@bugs.x2go.org>; Mon, 22 Feb 2016 00:14:00 +0100 (CET)
Received: from LT001.lan ([37.24.8.189]) by mail.gmx.com (mrgmx001) with
 ESMTPSA (Nemesis) id 0LymHf-1ZuykH0KNL-016A7z; Mon, 22 Feb 2016 00:08:50
 +0100
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: submit@bugs.x2go.org
Cc: Stefan Baur <X2Go-ML-1@baur-itcs.de>,
	Mihai Moldovan <ionic@ionic.de>,
	Orion Poplawski <orion@cora.nwra.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: [PATCH 1/1] sshmasterconnection.cpp: invalid proxy socket
Date: Mon, 22 Feb 2016 00:08:28 +0100
Message-Id: <1456096108-16599-1-git-send-email-xypron.glpk@gmx.de>
X-Mailer: git-send-email 2.1.4
X-Provags-ID: V03:K0:hAQ+Uptkvt4F57jG0nyAMSJkpETT0LPIAXIajuUUXOreBiNg6G2
 q8N5ey9iW0yF9tp8w3wawe/f1E4sRIH32eKDp3LqTdpo5ROz3nH/tjAmhKlvyjJYuAEOrSa
 /LlQW1cyvV8dfD7uhNUpRXYtvzsSQpBHm7cOKDXq/IHVOXGmRRo9zH+3yNL7jIMwS8758+d
 eHoytJMk7SOFwd8EY9YEw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:1/HLEaKg4Oc=:n5XPraHBjDznQ8yqY0H6Sn
 +c6syrCyHFQ5U3nI2tKJgSZz4mM3pe3BD0BpzdAA7nzsV8B2qePLy3mhCOAH2yfX+beANYD1G
 QDcOfTMj5XR4X1GUGanhjtDPbmRd4P0xN94xcNfs4CtN3eiiEkfrGoWO/Rm1F0/83N5Ss0jyZ
 JOcZjXDJ0yEyhfHou/8UrRMI5Yh/4AJPJQ6Z/QN4NWF1C6UwEzHl6eHzzTwKkEC9EyZrfsikH
 my0udqdFkHvxseBB9gQmDLQnGZEhTF9A3kwnjPygw6917M0ehqmZ4XXZKGBPuyAWY6LZzClhI
 +Zft+sF0hxeMfntz1GUlfboXSsl05vbE7ytyYJ8dHbUCXYfZ+Ee14gdjacM5Vzis5d8fqe0Mt
 epDVc4Qjx/8SrUedVQaZtK86k0udgSzBeKYdOwSLz3Pa9ouBy2k/9txQtZAexHkqklXeMkj0S
 Vb2oKGpVo42rsdrJ0OnidjWqP6DSe8hUmzmun/F7hySp1oVURd82VhF3OcSOKN7Ytat0JEvzo
 vuGIpgw37id++qvISaYi7kSYbq48U2sKNIhrc+MQT1thW3Ek5CXlJRbCdKhh26PcnbdJEc5K5
 +bzmHSVph6PcJPxgX06Tz2CI9nvNXNj90muW+u6qxvYqsbBOWjaG78R14iJ4xWJWdnMJeQn2t
 0imzmLRhQSs4a8BNAKlPVG6NUwjG7sqNtfidctXRCU67IhpSZb1XYgbZYse2JOOQo2p7v3tb7
 YrbJpdvM97NzqyZj3EIex/nZv5ek9b5lupmJIuXpgFGKxkmK+gKQ4XLrXlI=

Package: x2goclient
Version: 4.0.5.1

x2goclient shows proxy socket -1 (invalid).

http://doc.qt.io/qt-4.8/qabstractsocket.html#socketDescriptor:
The socket descriptor is not available when QAbstractSocket is in
UnconnectedState.

So we have first to connect to the proxy server before retrieving the
native socket.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 src/sshmasterconnection.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sshmasterconnection.cpp b/src/sshmasterconnection.cpp
index 5b3cff5..bb69047 100644
--- a/src/sshmasterconnection.cpp
+++ b/src/sshmasterconnection.cpp
@@ -548,7 +548,6 @@ void SshMasterConnection::run()
         tcpProxySocket = new QTcpSocket();
         tcpProxySocket->setProxy( *tcpNetworkProxy );
         tcpProxySocket->connectToHost(host, port);
-        proxysocket = tcpProxySocket->socketDescriptor();
         if (!tcpProxySocket->waitForConnected(30000))
         {
             QString message=tr ( "Cannot connect to proxy server." );
@@ -560,6 +559,7 @@ void SshMasterConnection::run()
             quit();
             return;
         }
+        proxysocket = tcpProxySocket->socketDescriptor();
 #ifdef DEBUG
         x2goDebug << "Created HTTP proxy socket: " << proxysocket << endl;
 #endif
-- 
2.1.4

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Nov 23 13:02:28 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.