X2Go Bug report logs - #1000
[PATCH 1/1] sshmasterconnection.cpp: invalid proxy socket

Full log

Message #14 received at control@bugs.x2go.org (full text, mbox, reply):

Received: (at control) by bugs.x2go.org; 22 Feb 2016 01:27:04 +0000
From x2go@ymir.das-netzwerkteam.de  Mon Feb 22 02:26:55 2016
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	URIBL_BLOCKED autolearn=unavailable version=3.3.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id D02BE5DA97;
	Mon, 22 Feb 2016 02:26:54 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id skyun4M+ch1D; Mon, 22 Feb 2016 02:26:48 +0100 (CET)
Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005)
	id 6669A5DA96; Mon, 22 Feb 2016 02:26:48 +0100 (CET)
From: Mihai Moldovan <ionic@ionic.de>
To: 1000-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org, 1000@bugs.x2go.org
Subject: X2Go issue (in src:x2goclient) has been marked as pending for release
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Mailer: http://snipr.com/post-receive-tag-pending
Message-Id: <20160222012648.6669A5DA96@ymir.das-netzwerkteam.de>
Date: Mon, 22 Feb 2016 02:26:48 +0100 (CET)

tag #1000 pending
fixed #1000 4.0.5.1
thanks

Hello,

X2Go issue #1000 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=2b70cfc

The issue will most likely be fixed in src:x2goclient (4.0.5.1).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 2b70cfccc00295a029015c9e181f8afdd21901e4
Author: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date:   Mon Feb 22 00:08:28 2016 +0100

    sshmasterconnection.cpp: don't fetch invalid proxy socket. Fixes: #1000.
    
    From http://doc.qt.io/qt-4.8/qabstractsocket.html#socketDescriptor: The
    socket descriptor is not available when QAbstractSocket is in
    UnconnectedState. So we have to connect to the proxy server first
    before retrieving the native socket.
    
    Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

diff --git a/debian/changelog b/debian/changelog
index cfea700..b680248 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -113,6 +113,15 @@ x2goclient (4.0.5.1-0x2go1) UNRELEASED; urgency=low
   * New upstream version (4.0.5.1):
     - res/i18n/x2goclient_nb_no.ts: update Bokmål (Norway) translation file.
 
+  [ Heinrich Schuchardt ]
+  * New upstream version (4.0.5.1):
+    - sshmasterconnection.cpp: don't fetch invalid proxy socket. Fixes: #1000.
+      From http://doc.qt.io/qt-4.8/qabstractsocket.html#socketDescriptor:
+      The socket descriptor is not available when QAbstractSocket is in
+      UnconnectedState.
+      So we have to connect to the proxy server first before retrieving the
+      native socket.
+
  -- X2Go Release Manager <git-admin@x2go.org>  Tue, 28 Jul 2015 06:05:27 +0200
 
 x2goclient (4.0.5.0-0x2go1) unstable; urgency=low

Send a report that this bug log contains spam.