X2Go Bug report logs - #1611
[PATCH] x2goclient: Replace deprecated uses of QString::null

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

From: Nico Roeser <nico@roeserundroeser.de>

To: submit@bugs.x2go.org

Subject: [PATCH] x2goclient: Replace deprecated uses of QString::null

Date: Tue, 15 Aug 2023 19:20:35 +0200

[Message part 1 (text/plain, inline)]

Package: x2goclient
Version: 4.1.2.3
Tag: patch

Related to: #864

On one of my Gentoo systems, x2goclient-4.1.2.3 did not build against qtcore-5.15.10. The attached patch changes deprecated occurrences of QString::null into isEmpty calls or construction of new null QStrings, which fixes the build problems.

I have not verified whether everything still functions perfectly. However, the change follows the Qt recommendations, and looks good to me when peeking at the QString documentation. I know that there still are strange constructions in the code, which I have not changed. Reason is that I tried the change to be as minimal as possible.

I do not intend to invest more time/work in this in the nearer future; if this patch is not sufficient, I hope someone else can pick it up and continue from there. Or just throw it away. ☺ Happy coding!

Attachment: 0001-x2goclient-Replace-deprecated-uses-of-QString-null.patch

Thanks
-- 
Nico

[0001-x2goclient-Replace-deprecated-uses-of-QString-null.patch (text/plain, attachment)]

Send a report that this bug log contains spam.