X2Go Bug report logs - #610
Add versioning information to nxcomp

version graph

Package: nx-libs; Maintainer for nx-libs is X2Go Developers <x2go-dev@lists.x2go.org>;

Reported by: Nito Martinez <Nito@Qindel.ES>

Date: Sun, 14 Sep 2014 22:40:01 UTC

Severity: normal

Tags: pending

Found in version 3.5.0.27

Fixed in version 2:3.5.0.28

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log


🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#610: [X2Go-Dev] Bug#610: Add versioning information to nxcomp
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 610@bugs.x2go.org
Resent-From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 15 Sep 2014 10:05:01 +0000
Resent-Message-ID: <handler.610.B610.141077535624203@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 610
X-X2Go-PR-Package: nx-libs
X-X2Go-PR-Keywords: 
Received: via spool by 610-submit@bugs.x2go.org id=B610.141077535624203
          (code B ref 610); Mon, 15 Sep 2014 10:05:01 +0000
Received: (at 610) by bugs.x2go.org; 15 Sep 2014 10:02:36 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 47A495DB54
	for <610@bugs.x2go.org>; Mon, 15 Sep 2014 12:02:33 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id BB84810A7;
	Mon, 15 Sep 2014 12:02:32 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 6CD6F3BCB5;
	Mon, 15 Sep 2014 12:02:32 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id JAquQSnH91t7; Mon, 15 Sep 2014 12:02:31 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id B5C2E3BCC3;
	Mon, 15 Sep 2014 12:02:29 +0200 (CEST)
Received: from m-031.informatik.uni-kiel.de (m-031.informatik.uni-kiel.de
 [134.245.254.31]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Mon, 15 Sep 2014 10:02:26 +0000
Date: Mon, 15 Sep 2014 10:02:26 +0000
Message-ID: <20140915100226.Horde.D6SPBRPnuoLmC3FHixJFeA1@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Nito Martinez <Nito@qindel.es>, 610@bugs.x2go.org
In-Reply-To: <541616A3.2020300@Qindel.ES>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.0)
Accept-Language: en,de
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 134.245.254.31
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101
 Firefox/32.0 Iceweasel/32.0
Content-Type: multipart/signed; boundary="=_XMY1_0dQneGD2gIjdwdZ3A1";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0
[Message part 1 (text/plain, inline)]
Control: notfound -1 3.5.0-27
Control: found -1 3.5.0.27

Hi Nito,

On  Mo 15 Sep 2014 00:28:51 CEST, Nito Martinez wrote:

> Package: nx-libs
> Version: 3.5.0-27
>
> It would be desirable to add some versions to be able to get the  
> version of the
> NXComp library.
> These should be defined in NX.h, to be used from other clients, and
>
> Attached is a patch that defines the following functions:
>
> extern const char* NXVersion();
> extern int NXMajorVersion();
> extern int NXMinorVersion();
> extern int NXPatchVersion();
>
> In the patch assigned the VERSION has been set to 3.5.28, just to  
> highlight that
> it would be good to change the VERSION of nxcomp whenever a patch is applied
> to the code.
>
> Regards,
>
> Nito

Thanks for sending in that patch.

However, the next upstream release of NX redistributed is planned to  
be 3.5.0.28.

The idea starting the NX version with 3.5.0 was to reflect what  
"upstream" version we obtained from NoMachine (they use three digits,  
NX redistributed uses _four_ digits in the version string). The fourth  
part of the version quadruple is the NX/X2Go/QVD redistributed patch  
level, so to say.

If that will not cause any technical issues, can you rewrite that  
patch so it handles four digit version strings (major, minor, micro,   
X2Go/QVD-patchlevel).

Please also note that an upstream version like 3.5.0-28 will cause  
convention issues with most Linux distributions. In Debian, for  
example, the part left of the "-" denotes the upstream version, the  
part right of the "-" denotes the package revision inside Debian. So  
we should avoid using a dash in the NX-libs upstream version.

Thanks!
Mike



-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Aug 17 17:45:41 2019; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.