X2Go Bug report logs - #1051
failing .deb builds due to flaw in code-to-version conversion scripts

Package: buildscripts; Maintainer for buildscripts is X2Go Developers <x2go-dev@lists.x2go.org>;

Reported by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Date: Mon, 4 Jul 2016 12:45:02 UTC

Severity: important

Done: Stefan Baur <X2Go-ML-1@baur-itcs.de>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1051: [X2Go-Dev] failing .deb builds due to flaw in code-to-version conversion scripts
Reply-To: Mihai Moldovan <ionic@ionic.de>, 1051@bugs.x2go.org
Resent-From: Mihai Moldovan <ionic@ionic.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 04 Jul 2016 20:20:02 +0000
Resent-Message-ID: <handler.1051.B1051.146766354110187@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1051
X-X2Go-PR-Package: buildscripts
X-X2Go-PR-Keywords: 
Received: via spool by 1051-submit@bugs.x2go.org id=B1051.146766354110187
          (code B ref 1051); Mon, 04 Jul 2016 20:20:02 +0000
Received: (at 1051) by bugs.x2go.org; 4 Jul 2016 20:19:01 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham
	version=3.3.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 863DF5DDCD
	for <1051@bugs.x2go.org>; Mon,  4 Jul 2016 22:18:59 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 8RGop1D3mf1I for <1051@bugs.x2go.org>;
	Mon,  4 Jul 2016 22:18:53 +0200 (CEST)
Received: from Root24.de (powered.by.root24.eu [5.135.3.88])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 35D435DA93
	for <1051@bugs.x2go.org>; Mon,  4 Jul 2016 22:18:53 +0200 (CEST)
Received: from nopileos.local (178.162.222.41.adsl.inet-telecom.org [178.162.222.41])
	by mail.ionic.de (Postfix) with ESMTPSA id 5C6F14F00062;
	Mon,  4 Jul 2016 22:18:52 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1467663532; bh=zy8IMCEu+mrH5dXE8ZbGv+q16yMB24SBI8nJZWFTYQs=;
	h=Subject:To:References:From:Date:In-Reply-To:From;
	b=I68TPwwA8we8nzu2Kh4AgWZ4oijLJYMcaKY8AGmuwZRsQUL5AnAQLedavj4I8Y+Wn
	 LbMaSoT6USqE2WEOloalfoAGBxilJTvhj/bu/lA4nceM9J4O83jwywmf6AXljrIe1E
	 KlbolrxD5F0VwHwtXBxAC0Y3xkWiCR7C12XPp7xo=
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 1051@bugs.x2go.org
References: <20160704124016.Horde.woIhUz_6S6kNm-zOMVjduSj@mail.das-netzwerkteam.de>
From: Mihai Moldovan <ionic@ionic.de>
Message-ID: <4e964262-1878-1761-3b66-1c7c6263e59b@ionic.de>
Date: Mon, 4 Jul 2016 22:18:40 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0)
 Gecko/20100101 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <20160704124016.Horde.woIhUz_6S6kNm-zOMVjduSj@mail.das-netzwerkteam.de>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="9RFXrcCL31mJ3P5TXsbsXSQUSJ8C9WFS9"

[Message part 1 (text/plain, inline)]
On 04.07.2016 02:40 PM, Mike Gabriel wrote:
> Package: buildscripts
> Severity: important
> 
> Hi Mihai,
> 
> I have played with X2Go Server a little today, trying to get the new  
> execution logic for nxagent/x2goagent into X2Go Server 4.1.0.0. While  
> doing that, I stumbled over build failures due to a flaw in the  
> buildscripts.
> 
> This fixes the occurring issues:
> 
> ```
> jenkins@japsand:~/buildscripts$ git diff
> diff --git a/bin/debian-codename-to-version.sh  
> b/bin/debian-codename-to-version.sh
> index 8bd0384..315fcbd 100755
> --- a/bin/debian-codename-to-version.sh
> +++ b/bin/debian-codename-to-version.sh
> @@ -76,7 +76,5 @@ case "${codename}" in
>          ("rex") echo "1.2";;
>          ("buzz") echo "1.1";;
> 
> -       (*) ret="1";;
> +       (*) echo "1";;
>   esac
> -
> -return "${ret}"
> diff --git a/bin/ubuntu-codename-to-version.sh  
> b/bin/ubuntu-codename-to-version.sh
> index 943e130..f0c1418 100755
> --- a/bin/ubuntu-codename-to-version.sh
> +++ b/bin/ubuntu-codename-to-version.sh
> @@ -66,7 +66,5 @@ case "${codename}" in
>          ("hoary") echo "5.04";;
>          ("warty") echo "4.10";;
> 
> -       (*) ret="1";;
> +       (*) echo "1";;
>   esac
> -
> -return "${ret}"
> ```

NAK, that would go against the script's contract as detailed in the comments.
There shouldn't be any output in case the code name provided is invalid, the
status is supposed to be reflected by the return value. There were a few
problems I fixed, though.

How about

http://code.x2go.org/gitweb?p=buildscripts.git;a=commitdiff;h=3153ec59c323cdc2efb3d394f0e4e2f98ca28c93

and

http://code.x2go.org/gitweb?p=buildscripts.git;a=commitdiff;h=8bb92fd510b40fe80759460fb96c1fafa1423fba

instead?



Mihai


[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Apr 27 00:45:03 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.