X2Go Bug report logs - #587
x2goclient is missing VcXsrv/zlib1.dll

Full log

Message #36 received at 587@bugs.x2go.org (full text, mbox, reply):

Received: (at 587) by bugs.x2go.org; 29 Aug 2014 12:41:01 +0000
From mikedep333@gmail.com  Fri Aug 29 14:41:00 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham version=3.3.2
Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 9C4A05DB3E
	for <587@bugs.x2go.org>; Fri, 29 Aug 2014 14:41:00 +0200 (CEST)
Received: by mail-wg0-f44.google.com with SMTP id m15so2055646wgh.3
        for <587@bugs.x2go.org>; Fri, 29 Aug 2014 05:41:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:date:message-id:subject:from:to:content-type;
        bh=vt+8HDHqfgd1ROo7OsNaYaeFQ4IbByNElI+U9Wa0fZw=;
        b=eeLM0K/zVMeSSPOF9xkF253a3PgghFQeDjZoX25XQa0wA1yxRmXBfX/QoYKtEFKWbV
         +hX8mNVyeHPXgOPMekLwTI8oFytK0hRFFHyhDtSRx3gz/HSpdkgK6ILLx2IbhbLjvtET
         HPxr7DLP+y0FLU1fAh0ICXBFs6RcayMQ0RIYFMFOGSM9pnIU+xMnz+rXmGn9Gbaa5GB8
         xwCupyySkToy6zR4jFW+N7LwuTQfAe+D1+zQBua4ehb1nGdKkw1JPL56wHrb0bSOGBCJ
         +KTphQRmJkgRSL3bLswd81kfgew5CFa7wQCs3+ftd8zORQzq9OWmZ56J2jDcw+tLqkYU
         LtWQ==
MIME-Version: 1.0
X-Received: by 10.194.118.201 with SMTP id ko9mr12704979wjb.26.1409316059800;
 Fri, 29 Aug 2014 05:40:59 -0700 (PDT)
Received: by 10.180.238.66 with HTTP; Fri, 29 Aug 2014 05:40:59 -0700 (PDT)
Date: Fri, 29 Aug 2014 08:40:59 -0400
Message-ID: <CAMKht8hgaQTeyriO1fLhvujsPoFL8yhZbHQ6KycjD1G-Yy6f-w@mail.gmail.com>
Subject: I believe I should fix this
From: Michael DePaulo <mikedep333@gmail.com>
To: 587@bugs.x2go.org
Content-Type: text/plain; charset=UTF-8

On Fri, Aug 29, 2014 at 11:04 AM, Mike Gabriel
<mike.gabriel@das-netzwerkteam.de> wrote:
> Thanks for reporting your observed issue.
>
> I close this bug as the problem seems to be related to your setup.
>
> Launching X2Go Client always requires to cwd to its installation directory,
> otherwise its DLLs will not be found.

Hi Mike#1 and Ivan,

I believe I should fix this bug. I am going to re-open it.

Unless I hear new reasons otherwise, in about 10 hours I will:
1. re-release the .zips for VcXsrv 1.14.3.2
http://code.x2go.org/releases/binary-win32/3rd-party/vcxsrv-modified-by-x2go-project/
2. update the X2GoWinBuilder VM that handles nightly builds
3. launch X2Go Client 4.0.2.1+hotfix-build4 with the fix.

This is why I believe I should fix this bug:

1. Every Windows program searches its own directory for DLLs, before
searching the PATH and cwd. This is the design of Windows. We can fix
X2GoClient being able to start successfully with your cwd being
different by including VcXsrv\zlib1.dll. There is no need to register
the DLL system-wide. And it's not a cygwin DLL anyway; its a native
Windows binary built from the VcXsrv/VcXsrv-xp source tree.

2. On my system, I can launch X2Go Client successfully from another
cwd. This includes x2goclient.exe, vcxsrv.exe, sshd.exe (cygwin) and
nxproxy.exe (cygwin). The only reason vcxsrv.exe does work is that I
have c:\gnuwin\bin\ZLIB1.dll in my PATH, where as most users likely do
not have any zlib1.dll in their PATH. (I determined this using
Dependency Walker.)

3. My manual build instructions state that I should include
VcXsrv\zlib1.dll. During the manual build process, I included
VcXsrv\xwininfo.exe instead of zlib1.dll.

4. We should provide vcxsrv.exe with its own zlib1.dll. It is
VcXsrv-xp's own version of the file for reasons mentioned in #1.

Respectfully,
-Mike#2

Send a report that this bug log contains spam.