X2Go Bug report logs - #211
RPM packaging of X2Go Session Broker

Full log

🔗 View this message in rfc822 format

MIME-Version: 1.0
X-Mailer: MIME-tools 5.502 (Entity 5.502)
X-Loop: owner@bugs.x2go.org
From: owner@bugs.x2go.org (X2Go Bug Tracking System)
Subject: Bug#211 closed by Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
 (X2Go issue (in src:x2gobroker) has been marked as closed)
Message-ID: <handler.211.c.136896028131085.notifdone@bugs.x2go.org>
References: <20130519104345.9D59E5DB28@ymir>
X-X2go-PR-Keywords: pending
X-X2go-PR-Message: they-closed 211
X-X2go-PR-Package: x2gobroker
X-X2go-PR-Source: x2gobroker
Date: Sun, 19 May 2013 10:48:05 +0000
Content-Type: multipart/mixed; boundary="----------=_1368960485-702-0"

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your Bug report
which was filed against the x2gobroker package:

#211: RPM packaging of X2Go Session Broker

It has been closed by Mike Gabriel <mike.gabriel@das-netzwerkteam.de>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Mike Gabriel <mike.gabriel@das-netzwerkteam.de> by
replying to this email.


-- 
X2Go Bug Tracking System
Contact owner@bugs.x2go.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: 211-submitter@bugs.x2go.org

Cc: control@bugs.x2go.org, 211@bugs.x2go.org

Subject: X2Go issue (in src:x2gobroker) has been marked as closed

Date: Sun, 19 May 2013 12:43:45 +0200 (CEST)

close #211
thanks

Hello,

we are very hopeful that X2Go issue #211 reported by you
has been resolved in the new release (0.0.2.1) of the
X2Go source project »src:x2gobroker«.

You can view the complete changelog entry of src:x2gobroker (0.0.2.1)
below, and you can use the following link to view all the code changes
between this and the last release of src:x2gobroker.

    http://code.x2go.org/gitweb?p=x2gobroker.git;a=commitdiff;h=e7ba5f8e1a81d814f4d3e9f82ad6e9bc2855e7cd;hp=363a8fb21e215d403ef81c9bfc0d079d431bacce

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:x2gobroker.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:x2gobroker
Version: 0.0.2.1
Status: RELEASE
Date: Sun, 19 May 2013 12:41:06 +0200
Fixes: 201 210 211
Changes: 
 x2gobroker (0.0.2.1) RELEASED; urgency=low
 .
   [ Mike Gabriel ]
   * New upstream version (0.0.2.1):
     - Remove trailing slashes from ManagementServer URLs.
     - In Apache2 vhost configuration example, move WSGI environment
       variable settings into VirtualHost setup.
     - Remove unused, not-yet-developed broker backends and frontends.
     - Remove old cruft from x2gobroker.conf.
     - Security fix for setuid wrapper x2gobroker-agent.c. Hard-code path to
       x2gobroker-agent.pl during build via defining a macro in the Makefile.
       Thanks to Richard Weinberger for spotting this!!!
     - Handle URLs in plain WebUI that have slashes (and subpaths) in the
       backend name.
     - In WSGI mode: only populate os.environ with variables matching
       »X2GOBROKER_*«.
     - Make X2GOBROKER_SESSIONPROFILES configurable via a SetEnv WSGI parameter
       in the httpd configuration possible. (Fixes: #210).
   * Provide init scripts and *.default files outside of /debian folder (as
     they are also relevant for non-Debian packaging).
 .
   [ Jan Engelhardt ]
   * New upstream version (0.0.2.1):
     - Populate install target of Makefile. (Fixes: #201).
     - Install man pages and default files through Makefile, as well. (Fixes:
       #211).

[Message part 3 (message/rfc822, inline)]

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: Jan Engelhardt <jengelh@inai.de>

Cc: submit@bugs.x2go.org

Subject: RPM packaging of X2Go Session Broker

Date: Wed, 15 May 2013 22:21:54 +0200

[Message part 4 (text/plain, inline)]

Package: x2gobroker
Version: 0.0.2.1
Severity: important

Hi Jan,

I open up a new bug for this. Please post updates to the new bug  
number, if any.

@all: this is a follow up of issue #201.

On Mi 15 Mai 2013 16:37:06 CEST Jan Engelhardt wrote:

>
> On Tuesday 2013-05-14 12:48, Mike Gabriel wrote:
>> python-x2gobroker (mostly covered by setup.py):
>>
>> /.
>> /etc
>> /etc/default
>> /etc/default/python-x2gobroker
> [...]

I comment in the lines below where to find that file in the source  
project x2gobroker.git (or in the installed package fileset)...

Absolute paths mean: this is the path when installed.
Relative paths mean: this is the path in x2gobroker.git

> --- yourlist	2013-05-15 16:34:44.890113044 +0200
> +++ susepkg	2013-05-15 16:31:32.657658085 +0200
> @@ -1,22 +1,11 @@
> -/etc
> -/etc/apache2
> -/etc/apache2/conf.d
> -/etc/apache2/conf.d/x2gobroker-wsgi

Symlink -> /etc/x2go/x2gobroker-wsgi.apache.conf

> -/etc/apache2/sites-available
> -/etc/apache2/sites-available/x2gobroker

Symlink -> /etc/x2go/x2gobroker-wsgi.apache.vhost

> -/etc/default
> -/etc/default/python-x2gobroker

x2gobroker.git/debian/python-x2gobroker.default

> -/etc/default/x2gobroker-authservice

x2gobroker.git/debian/x2gobroker-authservice.default

> -/etc/default/x2gobroker-daemon

x2gobroker.git/debian/x2gobroker-daemon.default

The files from /etc/default/* get sourced by the init scripts (see below).

> -/etc/init.d
> -/etc/init.d/x2gobroker-authservice

x2gobroker.git/debian/x2gobroker-authservice.init

> -/etc/init.d/x2gobroker-daemon

x2gobroker.git/debian/x2gobroker-daemon.init

> -/etc/logrotate.d
>  /etc/logrotate.d/x2gobroker-authservice
>  /etc/logrotate.d/x2gobroker-daemon
>  /etc/logrotate.d/x2gobroker-wsgi
>  /etc/pam.d
>  /etc/pam.d/x2gobroker
> +/etc/permissions.d/x2gobroker.easy
> +/etc/permissions.d/x2gobroker.paranoid
> +/etc/permissions.d/x2gobroker.secure

What are these for? Anything we should adopt in the Debian package(s)?

>  /etc/x2go
>  /etc/x2go/broker
>  /etc/x2go/broker/x2gobroker-authservice-logger.conf
> @@ -25,178 +14,108 @@
>  /etc/x2go/x2gobroker-wsgi.apache.conf
>  /etc/x2go/x2gobroker-wsgi.apache.vhost
>  /etc/x2go/x2gobroker.conf
> -/usr
> -/usr/bin
>  /usr/bin/x2gobroker-testauth
> -/usr/lib
> -/usr/lib/python2.7
> -/usr/lib/python2.7/site-packages
>  /usr/lib/python2.7/site-packages/x2gobroker
> -/usr/lib/python2.7/site-packages/x2gobroker-0.0.2.1.egg-info

[... skipping the python egg related files... ]

>  /usr/lib/x2go
>  /usr/lib/x2go/x2gobroker-agent
>  /usr/lib/x2go/x2gobroker-agent.pl
> -/usr/sbin
>  /usr/sbin/x2gobroker
>  /usr/sbin/x2gobroker-authservice
>  /usr/sbin/x2gobroker-keygen
>  /usr/sbin/x2gobroker-pubkeyauthorizer
> -/usr/share
> -/usr/share/doc
> -/usr/share/doc/python-x2gobroker
> -/usr/share/doc/python-x2gobroker/NEWS.gz
> -/usr/share/doc/python-x2gobroker/README
> -/usr/share/doc/python-x2gobroker/TODO
> -/usr/share/doc/python-x2gobroker/buildinfo_all.gz
> -/usr/share/doc/python-x2gobroker/changelog.Debian.gz
> -/usr/share/doc/python-x2gobroker/copyright
> -/usr/share/doc/x2gobroker
> -/usr/share/doc/x2gobroker-agent
> -/usr/share/doc/x2gobroker-agent/NEWS.gz
> -/usr/share/doc/x2gobroker-agent/README
> -/usr/share/doc/x2gobroker-agent/TODO

NEWS.gz, README, TODO are rendered from  
x2gobroker.git/{MEWS,README,TODO} for each bin:package.

> -/usr/share/doc/x2gobroker-agent/buildinfo_amd64.gz

This file is auto-generated during build.

> -/usr/share/doc/x2gobroker-agent/changelog.Debian.gz

x2gobroker.git/debian/changelog (abused as upstream changelog by X2Go  
Dev Team)

> -/usr/share/doc/x2gobroker-agent/copyright

x2gobroker.git/debian/copyright

> -/usr/share/doc/x2gobroker-authservice
> -/usr/share/doc/x2gobroker-authservice/NEWS.gz
> -/usr/share/doc/x2gobroker-authservice/README
> -/usr/share/doc/x2gobroker-authservice/TODO
> -/usr/share/doc/x2gobroker-authservice/buildinfo_all.gz
> -/usr/share/doc/x2gobroker-authservice/changelog.Debian.gz
> -/usr/share/doc/x2gobroker-authservice/copyright
> -/usr/share/doc/x2gobroker-daemon
> -/usr/share/doc/x2gobroker-daemon/NEWS.gz
> -/usr/share/doc/x2gobroker-daemon/README
> -/usr/share/doc/x2gobroker-daemon/TODO
> -/usr/share/doc/x2gobroker-daemon/buildinfo_all.gz
> -/usr/share/doc/x2gobroker-daemon/changelog.Debian.gz
> -/usr/share/doc/x2gobroker-daemon/copyright
> -/usr/share/doc/x2gobroker-wsgi
> -/usr/share/doc/x2gobroker-wsgi/NEWS.gz
> -/usr/share/doc/x2gobroker-wsgi/README
> -/usr/share/doc/x2gobroker-wsgi/TODO
> -/usr/share/doc/x2gobroker-wsgi/buildinfo_all.gz
> -/usr/share/doc/x2gobroker-wsgi/changelog.Debian.gz
> -/usr/share/doc/x2gobroker-wsgi/copyright
> -/usr/share/doc/x2gobroker/NEWS.gz
> -/usr/share/doc/x2gobroker/README
> -/usr/share/doc/x2gobroker/TODO
> -/usr/share/doc/x2gobroker/buildinfo_all.gz
> -/usr/share/doc/x2gobroker/changelog.Debian.gz
> -/usr/share/doc/x2gobroker/copyright

Dito for the bin:package above.

> -/usr/share/man
> -/usr/share/man/man8
> -/usr/share/man/man8/x2gobroker-authservice.8.gz
> -/usr/share/man/man8/x2gobroker-keygen.8.gz
> -/usr/share/man/man8/x2gobroker-pubkeyauthorizer.8.gz
> -/usr/share/man/man8/x2gobroker-testauth.8.gz
> -/usr/share/man/man8/x2gobroker.8.gz

These should get installed into your package, I guess. You can find them in

x2gobroker.git/man/man8/*

> -/usr/share/pyshared
> -/usr/share/pyshared/x2gobroker
> -/usr/share/pyshared/x2gobroker-0.0.2.1.egg-info

[ ... skipping some more python files ... ]

> -/var
> -/var/log

>  /var/log/x2gobroker

make sure to install this directory

  2750 x2gobroker:x2gobroker

> +/var/lib/x2gobroker

This is the home directory of system user x2gobroker. Not that there  
is some postinst magic in x2gobroker.git/debian/*.postinst scripts.  
The magic does:

  * create system user x2gobroker (x2gobroker-daemon, x2gobroker-wsgi,
    x2gobroker-authservice, x2gobroker-agent requires that user)
  * set permissions on the log directory

Another thing that your package x2gobroker-agent should handle: the  
file /usr/lib/x2go/x2gobroker-agent (the setuid wrapper for  
x2gobroker-agent.pl) has to be installed setuid root.

  4750 root:x2gobroker /usr/lib/x2go/x2gobroker-agent

I hope this gets us a bit further.

Mike



-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 5 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.